View Issue Details

IDProjectCategoryView StatusLast Update
0010190ScribusUser Interfacepublic2011-09-15 19:29
ReporterVladimir Savic Assigned Tocbradney  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
PlatformLinuxOSUbuntuOS Version11.04
Product Version1.5.0svn 
Fixed in Version1.4.0svn 
Summary0010190: Add options for transfering page origin to Top Center and Bottom Center positions
DescriptionAs above. Patch included. Two new options added to RMB menu for defining page origin. Two new strings introduced and, since I'm not native English speaker obviously, need review.

Cheers
TagsNo tags attached.
Patch

Activities

Vladimir Savic

2011-08-16 16:19

reporter  

morePageOrigins.diff (1,765 bytes)   
Index: scribus/ui/rulermover.cpp
===================================================================
--- scribus/ui/rulermover.cpp	(revision 16787)
+++ scribus/ui/rulermover.cpp	(working copy)
@@ -91,6 +91,8 @@
 				pmen2->addAction( tr("Origin at Bottom Left"), this, SLOT(moveRulerBottomLeft()));
 				pmen2->addAction( tr("Origin at Bottom Right"), this, SLOT(moveRulerBottomRight()));
 				pmen2->addAction( tr("Origin at Center"), this, SLOT(moveRulerCenter()));
+                                pmen2->addAction( tr("Origin at Top Center"), this, SLOT(moveRulerTopCenter()));
+                                pmen2->addAction( tr("Origin at Bottom Center"), this, SLOT(moveRulerBottomCenter()));
 				pmen->addMenu(pmen2);
 			}
 		}
@@ -143,3 +145,17 @@
 	currView->Doc->rulerYoffset = currView->Doc->currentPage()->height() / 2.0;
 	currView->DrawNew();
 }
+
+void RulerMover::moveRulerTopCenter()
+{
+        currView->Doc->rulerXoffset = currView->Doc->currentPage()->width() / 2.0;
+        currView->Doc->rulerYoffset = 0;
+        currView->DrawNew();
+}
+
+void RulerMover::moveRulerBottomCenter()
+{
+        currView->Doc->rulerXoffset = currView->Doc->currentPage()->width() / 2.0;
+        currView->Doc->rulerYoffset = currView->Doc->currentPage()->height();
+        currView->DrawNew();
+}
Index: scribus/ui/rulermover.h
===================================================================
--- scribus/ui/rulermover.h	(revision 16787)
+++ scribus/ui/rulermover.h	(working copy)
@@ -50,6 +50,8 @@
 	void moveRulerBottomLeft();
 	void moveRulerBottomRight();
 	void moveRulerCenter();
+        void moveRulerTopCenter();
+        void moveRulerBottomCenter();
 private: // Private attributes
 	ScribusView *currView;
 	RulerGesture* rulerGesture;
morePageOrigins.diff (1,765 bytes)   

Vladimir Savic

2011-08-16 21:14

reporter   ~0026728

Thanks a lot, but is it OK to introduce new string this late in release process? Shouldn't this go in 1.5.0 instead?

cbradney

2011-08-16 21:33

administrator   ~0026730

Its in 1.5.0 too, but given 1.4.0 is a bit from release, I think it is ok. People will have another opportunity to update translation files.

Issue History

Date Modified Username Field Change
2011-08-16 16:19 Vladimir Savic New Issue
2011-08-16 16:19 Vladimir Savic File Added: morePageOrigins.diff
2011-08-16 20:52 cbradney Assigned To => cbradney
2011-08-16 20:52 cbradney Status new => assigned
2011-08-16 21:04 cbradney Status assigned => resolved
2011-08-16 21:04 cbradney Fixed in Version => 1.4.0svn
2011-08-16 21:04 cbradney Resolution open => fixed
2011-08-16 21:14 Vladimir Savic Note Added: 0026728
2011-08-16 21:33 cbradney Note Added: 0026730
2011-09-15 19:29 cbradney Status resolved => closed