View Issue Details

IDProjectCategoryView StatusLast Update
0010267ScribusUser Interfacepublic2014-03-09 09:38
ReporterJLuc Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformPCOS7 
Product Version1.4.0svn 
Fixed in Version1.4.4.svn 
Summary0010267: Better Search dialog initial state
DescriptionWhen opening the search dialog, no input is selected, all inputs are unavailable.
One has to select an input before inputing, and most of the time, at least "text" input is selected.

The proposition is :
"searched text" input should be preselected as a default input so as to avoid - most of the time - one click to select it and open the input.

If not wanted, it is allways possible to unselect it. But unwanted is sure way not as often as wanted.
TagsNo tags attached.
Patch

Activities

JLuc

2014-02-25 20:06

developer   ~0031398

I uploaded new patch to fix this issue.
Please test and merge if possible.

Explanations : issue only happens first time Scribus is launched because prefs.xml are not available. Patch says default value for text search and replace is "clicked" in such cases.

JLuc

2014-02-25 20:09

developer  

jl_defaultsearchtext.diff (1,134 bytes)   
Index: scribus/ui/search.cpp
===================================================================
--- scribus/ui/search.cpp	(révision 18833)
+++ scribus/ui/search.cpp	(copie de travail)
@@ -998,7 +998,7 @@
 	SFont->setChecked(m_prefs->getBool("SFont", false));
 	SStyle->setChecked(m_prefs->getBool("SStyle", false));
 	SAlign->setChecked(m_prefs->getBool("SAlign", false));
-	SText->setChecked(m_prefs->getBool("SText", false));
+	SText->setChecked(m_prefs->getBool("SText", true));
 	SEffect->setChecked(m_prefs->getBool("SEffect", false));
 	REffect->setChecked(m_prefs->getBool("REffect", false));
 	STextVal->setText(m_prefs->get("STextVal", ""));
@@ -1022,7 +1022,7 @@
 	RFont->setChecked(m_prefs->getBool("RFont", false));
 	RStyle->setChecked(m_prefs->getBool("RStyle", false));
 	RAlign->setChecked(m_prefs->getBool("RAlign", false));
-	RText->setChecked(m_prefs->getBool("RText", false));
+	RText->setChecked(m_prefs->getBool("RText", true));
 	RTextVal->setText(m_prefs->get("RTextVal", ""));
 	tmp = m_prefs->getInt("RStyleVal", findParagraphStyle(m_doc, m_doc->currentStyle));
 	if (tmp < 0 || tmp >= RStyleVal->count())
jl_defaultsearchtext.diff (1,134 bytes)   

Issue History

Date Modified Username Field Change
2011-09-16 10:38 JLuc New Issue
2014-02-25 20:03 JLuc File Added: jl_defaultsearchtext.diff
2014-02-25 20:06 JLuc Note Added: 0031398
2014-02-25 20:09 JLuc File Deleted: jl_defaultsearchtext.diff
2014-02-25 20:09 JLuc File Added: jl_defaultsearchtext.diff
2014-02-25 21:31 cbradney Status new => resolved
2014-02-25 21:31 cbradney Fixed in Version => 1.5.0svn
2014-02-25 21:31 cbradney Resolution open => fixed
2014-02-25 21:31 cbradney Assigned To => cbradney
2014-02-25 21:33 cbradney Fixed in Version 1.5.0svn => 1.4.3.svn
2014-02-26 18:59 christoph_s Status resolved => closed
2014-03-09 09:38 jghali Fixed in Version 1.4.3.svn => 1.4.4.svn