View Issue Details

IDProjectCategoryView StatusLast Update
0010569ScribusGeneralpublic2015-10-03 20:18
Reporternakamoto Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.1.svn 
Summary0010569: Preference dialog's widget list becomes too narrow in Japanese environment
DescriptionPreference dialog's widget list items (general, document, ... ) show both icon and title text using QListWidgetItem. later, Scribus tries to find "required minimal" width in OptionListWidget::arrangeIcons().
When Qt tries to keep the title width from getting too large, it "folds" the text at every possible breakable-position.
Unfortunately, Japanese text is breakable almost everywhere, and the title is folded to generate many rows, each of which contain a few characters and has the same width as icon.
As a result, preference dialog's item list width becomes too narrow to show its contents.
Steps To ReproduceSelect "Japanese" as UI language in preference dialog, close and reopen the preference dialog.
Additional InformationThough it's a Qt problem, a simple work around is set some minimum width in calculating widget list width. Here I attach a patch to set the value to 100 ( this value seems a little bit smaller than the calculated English value).
TagsNo tags attached.
Patch

Activities

nakamoto

2012-02-03 05:47

reporter  

prefsdialogbase.cpp.patch (313 bytes)   
--- prefsdialogbase.cpp.old	2012-02-03 14:28:20.303415410 +0900
+++ prefsdialogbase.cpp	2012-02-03 14:30:52.795417572 +0900
@@ -48,7 +48,7 @@
 
 void OptionListWidget::arrangeIcons()
 {
-	int maxWidth = 0;
+	int maxWidth = 100; // some minimum width
 	setWrapping(false);
 	QListWidgetItem* ic;
 	int startY = 5;
prefsdialogbase.cpp.patch (313 bytes)   

cbradney

2012-06-16 14:34

administrator   ~0028165

Would there be a way we can check for the locale before applying this value?

nakamoto

2012-06-16 23:15

reporter   ~0028168

Current UI language of Scribus ?

cbradney

2012-06-17 11:12

administrator   ~0028170

Ok, committed to 1.4.2.svn but it doesn't look like its helping.. can you pleas re-test?

How does 1.5.0.svn perform? The prefs there are completely re-designed.

nakamoto

2012-06-18 02:45

reporter   ~0028174

Last edited: 2012-06-18 02:46

Dialog strings in 1.4.2.svn has become visible, where only left halves of icons were shown. Though it still looks ugly in Japanese setting ( strings are folded too compactly ), much better than unreadable.

Concerning 1.5.0, the revision 17580 which I built on Ubuntu 12.04 crashed ( segmentation fault ), so I cannot tell the result.

Kunda

2015-05-08 01:40

updater   ~0035072

Hey Craig, does "Use Small Widgets on Pallete" change anything for you here?

cbradney

2015-05-08 18:40

administrator   ~0035074

No, it cannot, there's no code for applying small widgets in anything other than the palettes.

Kunda

2015-06-30 16:47

updater   ~0035579

This looks fixed in 1.5.1svn r20224
Added Screenshots

Kunda

2015-06-30 16:47

updater  

Scribus-ja-Preferences.png (83,339 bytes)   
Scribus-ja-Preferences.png (83,339 bytes)   

Kunda

2015-06-30 16:48

updater  

Scribus-ja-Doc-Settings.png (72,998 bytes)   
Scribus-ja-Doc-Settings.png (72,998 bytes)   

Kunda

2015-06-30 16:50

updater   ~0035580

Not sure when this was fixed. Resolving for now. See Screenshots for my reasoning.

Issue History

Date Modified Username Field Change
2012-02-03 05:47 nakamoto New Issue
2012-02-03 05:47 nakamoto File Added: prefsdialogbase.cpp.patch
2012-02-03 07:23 jghali Severity major => minor
2012-06-16 14:34 cbradney Note Added: 0028165
2012-06-16 23:15 nakamoto Note Added: 0028168
2012-06-17 11:12 cbradney Note Added: 0028170
2012-06-17 11:12 cbradney Assigned To => cbradney
2012-06-17 11:12 cbradney Status new => assigned
2012-06-18 02:45 nakamoto Note Added: 0028174
2012-06-18 02:46 nakamoto Note Edited: 0028174
2015-05-08 01:40 Kunda Note Added: 0035072
2015-05-08 18:40 cbradney Note Added: 0035074
2015-06-30 16:47 Kunda Note Added: 0035579
2015-06-30 16:47 Kunda File Added: Scribus-ja-Preferences.png
2015-06-30 16:48 Kunda File Added: Scribus-ja-Doc-Settings.png
2015-06-30 16:50 Kunda Note Added: 0035580
2015-06-30 16:50 Kunda Status assigned => resolved
2015-06-30 16:50 Kunda Resolution open => fixed
2015-10-03 20:18 cbradney Status resolved => closed