![]() |
|
![]() |
![]() |
|
||
| · Hosting provided by Anduin.net / Øverby Consulting · | ||||||
| Anonymous | Login | Signup for a new account | 2013-06-18 07:45 CEST | ![]() |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0010725 | Scribus | Plug-ins | public | 12-May-30 20:14 | 12-Jun-14 23:10 | ||||
| Reporter | rm | ||||||||
| Assigned To | jghali | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | 1.5.0svn | ||||||||
| Target Version | Fixed in Version | 1.5.0svn | |||||||
| Summary | 0010725: misc patches for plugins/ | ||||||||
| Description | cleanup-some-copy-paste-code.diff: remove some duplicate code, this may be pointless but found the code while investigating cppcheck reports. [scribus/plugins/import/shape/importshape.cpp:549]: (warning) Missing bounds check for extra iterator increment in loop. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
Notes |
|
|
(0028051) rm (reporter) 12-May-30 20:15 |
fix-resource-leaks-ai.diff: do some sanity checks around fopen and fix resource leaks on error paths spotted by cppcheck |
|
(0028052) rm (reporter) 12-May-30 20:33 |
use-correct-deallocator.diff: free with delete[] what we allocate with new [] , also spotted by cppcheck |
|
(0028053) jghali (administrator) 12-May-30 21:17 |
Committed, thanks! Btw syntax for delete[] is : delete[] line; not : delete line[]; |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 12-May-30 20:14 | rm | New Issue | |
| 12-May-30 20:14 | rm | File Added: cleanup-some-copy-paste-code.diff | |
| 12-May-30 20:15 | rm | Note Added: 0028051 | |
| 12-May-30 20:32 | rm | File Added: fix-resource-leaks-ai.diff | |
| 12-May-30 20:32 | rm | File Added: use-correct-deallocator.diff | |
| 12-May-30 20:33 | rm | Note Added: 0028052 | |
| 12-May-30 21:17 | jghali | Note Added: 0028053 | |
| 12-May-30 21:17 | jghali | Status | new => resolved |
| 12-May-30 21:17 | jghali | Fixed in Version | => 1.5.0svn |
| 12-May-30 21:17 | jghali | Resolution | open => fixed |
| 12-May-30 21:17 | jghali | Assigned To | => jghali |
| 12-Jun-14 23:10 | cbradney | Status | resolved => closed |
| Main | My View | View Issues | Change Log | Roadmap |
| Copyright © 2000 - 2013 MantisBT Team |