Mantis Issue Tracking for Scribus
· Hosting provided by Anduin.net / Øverby Consulting ·

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010725ScribusPlug-inspublic12-May-30 20:1412-Jun-14 23:10
Reporterrm 
Assigned Tojghali 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.5.0svn 
Target VersionFixed in Version1.5.0svn 
Summary0010725: misc patches for plugins/
Descriptioncleanup-some-copy-paste-code.diff: remove some duplicate code, this may be pointless but found the code while investigating cppcheck reports. [scribus/plugins/import/shape/importshape.cpp:549]: (warning) Missing bounds check for extra iterator increment in loop.
TagsNo tags attached.
Attached Filesdiff file icon cleanup-some-copy-paste-code.diff [^] (2,792 bytes) 12-May-30 20:14 [Show Content]
diff file icon fix-resource-leaks-ai.diff [^] (1,150 bytes) 12-May-30 20:32 [Show Content]
diff file icon use-correct-deallocator.diff [^] (364 bytes) 12-May-30 20:32 [Show Content]

- Relationships

-  Notes
(0028051)
rm (reporter)
12-May-30 20:15

fix-resource-leaks-ai.diff: do some sanity checks around fopen and fix resource leaks on error paths spotted by cppcheck
(0028052)
rm (reporter)
12-May-30 20:33

use-correct-deallocator.diff: free with delete[] what we allocate with new [] , also spotted by cppcheck
(0028053)
jghali (administrator)
12-May-30 21:17

Committed, thanks! Btw syntax for delete[] is :

delete[] line;

not :

delete line[];

- Issue History
Date Modified Username Field Change
12-May-30 20:14 rm New Issue
12-May-30 20:14 rm File Added: cleanup-some-copy-paste-code.diff
12-May-30 20:15 rm Note Added: 0028051
12-May-30 20:32 rm File Added: fix-resource-leaks-ai.diff
12-May-30 20:32 rm File Added: use-correct-deallocator.diff
12-May-30 20:33 rm Note Added: 0028052
12-May-30 21:17 jghali Note Added: 0028053
12-May-30 21:17 jghali Status new => resolved
12-May-30 21:17 jghali Fixed in Version => 1.5.0svn
12-May-30 21:17 jghali Resolution open => fixed
12-May-30 21:17 jghali Assigned To => jghali
12-Jun-14 23:10 cbradney Status resolved => closed



Copyright © 2000 - 2013 MantisBT Team
Powered by Mantis Bugtracker