View Issue Details

IDProjectCategoryView StatusLast Update
0012440ScribusStylespublic2014-07-07 15:55
Reporterdougray Assigned Tojghali  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Platformintel 64bit (core 2 duo)OSubuntu gnomeOS Version13.10
Product Version1.4.4 
Fixed in Version1.4.5.svn 
Summary0012440: para styles using "Based On:" character inheritance trigger incorrect text display
Descriptiontext box displays red-outline square glyphs instead of chars, whenever I use a style composed with inherited character details via the "Based On:" drop-down selector under the "Character Style" tab.

This is using the same font that is set as default;
the font displays fine if the font is selected explicitly,
without any "Based On:" inheritance. (I'm using Liberation Serif)
Steps To Reproduce"edit" -> "styles"
select "Default paragraph style";
"Edit>>"
select "Character Style" tab
open the "Based On:" drop-down menu
select "Default Character Style"
click "Apply"; click "<<Done"

create a text box
Ctrl-T into story editor
enter text, set style to "Default Paragraph Style", Ctrl-U update.

Text is displayed as blank square-outline glyphs.

[Return to style editor, reset the "Based On:" field to blank,
"Apply", "<<Done"... text appears in text box as normal]
Additional InformationThere are also problems with defining character styles "Based On"
other character styles, but you can reproduce the above problem with
just the default character style

Another quirk of using "based on" is that the font family is unpredictably hard to assign using the "use parent font" entry at the bottom of the drop-down font-family selector, but the first bug, above, is independent of this.
TagsNo tags attached.
Patch

Activities

JLuc

2014-06-26 20:31

developer   ~0032330

Last edited: 2014-06-26 20:32

dougray : can you upload a sample SLA showing the issued ?

dougray

2014-06-27 13:31

reporter  

dougray

2014-06-27 13:49

reporter   ~0032343

Last edited: 2014-06-27 14:05

Ah. more complicated than I thought, an extra step is needed to reproduce:
after selecting "Default Character Style" in "Based On:" field:
*** open the "Style:" drop-down and select "Use Parent Font";
then continue with "Apply", "<<Done".

RE-OPENING THE UPLOADED FILE it will appear normal.
RE-EDITING THE STYLE with the above step makes the bug reappear.

THERE IS SOME INTERACTION with story editor: the style is reset to the first
font in /usr/share/fonts/ (for me, Abyssinica SIL Regular). If I open the
story editor when first opening the sample file, it shows the default
"Liberation Serif Regular"; but after tweaking the
"Default Paragraph Style"->"Character Style"->"basic formatting":"Style"->"Use Parent Font", "Apply",
re-opening the story editor now shows a style of "Abyssinica SIL Regular".
THIS DOESN"T CHANGE WHEN I RESET THE STYLE TO "Default Paragraph Style"
(excuse caps).

(I have a more complicated file in which some texts maintain brokeness across
closing scribus / re-opening file; I'll try to break it into something smaller
that still has this property. Sometime tomorrow.)

dougray

2014-06-28 13:13

reporter  

destyledInheritance.sla (12,734 bytes)

dougray

2014-06-28 13:49

reporter   ~0032354

Okay, new file "destyledInheritance.sla" shows the bug and is consistent across close/re-open.

Opening destyledInheritance.sla, the fourth line in the textbox displays
as empty square glyphs for me.

(My scribus has a 1.4.2 splash screen, "Scribus 1.4.3.svn" title bar, and
top of .sla file says 4.3, but the package is labelled 1.4.2.dfsg+r18)

The problems come from using the "Use Parent Font" option in the Style: field
of a Character Style. That's for both the files. (I think that using
"Use Parent Font" gives equivalent results wherever it is used: in the
Family: field, or the Style: field, and in Character Styles or within a
Paragraph Style's Character Style tab.)

The "Use Parent Font" option only appears when the "Based On:" field is set,
so all Paragraph and Character styles here use an explicit value in "Based On:".

StyleFontInheritance-styleUseParent.sla just trips the Style: field in the
"Default Paragraph Style". The bug is displayed, but disappears after file
close / reopen.

destyledInheritance.sla" uses one level of indirection: we define a couple
of character styles; one has the Style: field destyled to the
"Use Parent Font" value (the other char style also uses a Based On: setting,
but the Style: field is untouched). Then we define an extra paragraph style.
One paragraph style is based on the destyled character style.
The other paragraph style is based on the clone character style ("Style:" field
unaltered from default).

(I saw another bug with "Use Parent Font" in the Family: field, where clicking
that value set the field to the last font in the font list. I haven't pursued that and it was intermittent.)

Thanks

JLuc

2014-06-28 17:02

developer   ~0032359

It has been fixed. Can you test and confirm the fix ?

dougray

2014-06-29 12:17

reporter   ~0032361

That was so quick! Thanks again.

Testing may take some days, I hadn't planned on using this box as a development
machine.

Have installed subversion, opened svn on the firewall, checked out 14x.
Currently installing 600MB dependencies...

dougray

2014-06-29 13:57

reporter   ~0032362

Confirming fixed (compiled from scribus 1.4.5 r19296):

test files display okay;
re-setting "Use Parent Font" / apply, still displays okay;
new text entered from story editor in style w. inherited char styles also okay.

good work, guys

FirasH

2014-07-07 15:55

developer   ~0032548

Closing as tested by dougray.

Issue History

Date Modified Username Field Change
2014-06-26 13:40 dougray New Issue
2014-06-26 20:31 JLuc Note Added: 0032330
2014-06-26 20:32 JLuc Note Edited: 0032330
2014-06-27 13:31 dougray File Added: StyleFontInheritance-styleUseParent.sla
2014-06-27 13:49 dougray Note Added: 0032343
2014-06-27 14:00 dougray Note Edited: 0032343
2014-06-27 14:02 dougray Note Edited: 0032343
2014-06-27 14:05 dougray Note Edited: 0032343
2014-06-28 13:13 dougray File Added: destyledInheritance.sla
2014-06-28 13:49 dougray Note Added: 0032354
2014-06-28 15:36 jghali Summary para styles using "Based On:" character inheritance not displayed in Scribus 1.4.3 => para styles using "Based On:" character inheritance trigger incorrect text display
2014-06-28 15:40 jghali Status new => resolved
2014-06-28 15:40 jghali Fixed in Version => 1.4.5.svn
2014-06-28 15:40 jghali Resolution open => fixed
2014-06-28 15:40 jghali Assigned To => jghali
2014-06-28 17:02 JLuc Note Added: 0032359
2014-06-28 18:53 jghali Product Version => 1.4.4
2014-06-29 12:17 dougray Note Added: 0032361
2014-06-29 13:57 dougray Note Added: 0032362
2014-07-07 15:55 FirasH Note Added: 0032548
2014-07-07 15:55 FirasH Status resolved => closed