View Issue Details

IDProjectCategoryView StatusLast Update
0012604ScribusUser Interfacepublic2014-08-31 18:18
ReporterFirasH Assigned Tojghali  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0012604: [PATCH] "Convert To" should be "Convert to" under Item menu
Description"Convert To" should be "Convert to" under Item.
That is needed to keep consistency with other Item menu entries + right-click menu on Canvas where the function is already named "Convert to" with small cap.
Additional Information1.5.0.svn (19418)
TagsNo tags attached.
Patch

Relationships

related to 0012201 closedjghali [PATCH] Empty tooltips in Preferences window 
related to 0012507 closedcbradney [PATCH] Added tooltip "Create range of pages" to ellipsis icon in all Scribus export dialogs 
related to 0012615 closedjghali [PATCH] Fix some untranslatable UI strings (3) 

Activities

FirasH

2014-08-14 00:44

developer   ~0033246

I have a question: are the .patch files correct? I mean are they as a .patch file is supposed to be or the format is not correct?

FirasH

2014-08-14 00:50

developer   ~0033247

Added as related 2 reports which contain .patch files to fix those trivial issues (trying to understand a bit how it works ;) ).

ale

2014-08-15 08:34

manager   ~0033256

hi firash,

nice to see you creating patches!

two comments from my side:
- it would imo be better not to zip the patches, but upload them individually: that way they can be viewed in mantis itself
- when doing the diff, you have to be in the main scribus directory (the one below the "scribus/" directory that contains the whole code).
- as jluc mentioned on irc, you'd better use "svn diff" for the patches... that way you don't have to keep a copy of the original file, but can "auomatically" compare to the version you got the last time you updated the repository.

FirasH

2014-08-15 13:37

developer  

12604-part1 (762 bytes)   
Index: scribus/scribus.cpp
===================================================================
--- scribus/scribus.cpp	(revisione 19425)
+++ scribus/scribus.cpp	(copia locale)
@@ -876,7 +876,7 @@
	scrMenuMgr->addMenuItemString("itemPDFIsBookmark", "ItemPDFOptions");
	scrMenuMgr->addMenuItemString("itemPDFAnnotationProps", "ItemPDFOptions");
	scrMenuMgr->addMenuItemString("itemPDFFieldProps", "ItemPDFOptions");
-	scrMenuMgr->createMenu("ItemConvertTo", tr("C&onvert To"), "Item");
+	scrMenuMgr->createMenu("ItemConvertTo", tr("C&onvert to"), "Item");
	scrMenuMgr->addMenuItemString("ItemConvertTo", "Item");
	scrMenuMgr->addMenuItemString("itemConvertToTextFrame", "ItemConvertTo");
	scrMenuMgr->addMenuItemString("itemConvertToImageFrame", "ItemConvertTo");
12604-part1 (762 bytes)   

FirasH

2014-08-15 13:38

developer  

12604-part2 (637 bytes)   
Index: scribus/ui/scmwmenumanager.cpp
===================================================================
--- scribus/ui/scmwmenumanager.cpp	(revisione 19425)
+++ scribus/ui/scmwmenumanager.cpp	(copia locale)
@@ -43,7 +43,7 @@
	setText("ItemLayer", tr("Send to Layer"));
	setText("ItemPreviewSettings", tr("Previe&w Settings"));
	setText("ItemPDFOptions", tr("&PDF Options"));
-	setText("ItemConvertTo", tr("C&onvert To"));
+	setText("ItemConvertTo", tr("C&onvert to"));
 //			setText("ItemPathOps", tr("Path Tools"));
	setText("Insert", ActionManager::defaultMenuNameEntryTranslated("Insert"));
	setText("InsertChar", tr("Character"));
12604-part2 (637 bytes)   

jghali

2014-08-19 11:29

administrator   ~0033283

Applied, thanks!

FirasH

2014-08-31 18:18

developer   ~0033406

Thanks jghali!
Fixed in 1.5.0.svn (19468).

Issue History

Date Modified Username Field Change
2014-08-14 00:21 FirasH New Issue
2014-08-14 00:42 FirasH File Added: patch12604.zip
2014-08-14 00:44 FirasH Note Added: 0033246
2014-08-14 00:44 FirasH Summary "Convert To" should be "Convert to" under Item menu => [PATCH] "Convert To" should be "Convert to" under Item menu
2014-08-14 00:48 FirasH Relationship added related to 0012201
2014-08-14 00:49 FirasH Relationship added related to 0012507
2014-08-14 00:50 FirasH Note Added: 0033247
2014-08-15 08:34 ale Note Added: 0033256
2014-08-15 13:37 FirasH File Deleted: patch12604.zip
2014-08-15 13:37 FirasH File Added: 12604-part1
2014-08-15 13:38 FirasH File Added: 12604-part2
2014-08-17 22:36 FirasH Relationship added related to 0012615
2014-08-18 13:16 Kunda Status new => feedback
2014-08-19 11:29 jghali Note Added: 0033283
2014-08-19 11:29 jghali Status feedback => resolved
2014-08-19 11:29 jghali Fixed in Version => 1.5.0svn
2014-08-19 11:29 jghali Resolution open => fixed
2014-08-19 11:29 jghali Assigned To => jghali
2014-08-31 18:18 FirasH Note Added: 0033406
2014-08-31 18:18 FirasH Status resolved => closed