View Issue Details

IDProjectCategoryView StatusLast Update
0012841ScribusGeneralpublic2014-11-30 20:12
ReporterFirasH Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.5.svn 
Target Version1.4.5Fixed in Version1.4.5.svn 
Summary0012841: Backport 0012668 fix to 1.4.5.svn
DescriptionBackport 0012668 fix to 1.4.5.svn.
Without this patch clicking Deselect All while editing:

1) Nodes: palette remains active with no shape selected, clicking on canvas leads to crash.
2) Gradient Vector: crash
TagsNo tags attached.
PatchYes

Relationships

related to 0012668 closedcbradney "Edit > Deselect All" may lead to crash Editing Shapes 

Activities

FirasH

2014-11-30 12:59

developer  

12841-Backport.diff (510 bytes)   
Index: scribus/scribus.cpp
===================================================================
--- scribus/scribus.cpp	(revisione 19650)
+++ scribus/scribus.cpp	(copia locale)
@@ -5539,7 +5539,11 @@

 void ScribusMainWindow::deselectAll()
 {
-	if (doc->appMode == modeEdit)
+	bool inEditMode = (doc->appMode == modeEdit ||
+					   doc->appMode == modeEditClip ||
+					   doc->appMode == modeEditGradientVectors
+					   ) ? true : false;
+	if (inEditMode)
	{
		if (doc->m_Selection->count() <= 0)
			return;
12841-Backport.diff (510 bytes)   

jghali

2014-11-30 17:39

administrator   ~0034261

Applied, thanks!

FirasH

2014-11-30 20:12

developer   ~0034264

Thanks jghali!

Issue History

Date Modified Username Field Change
2014-11-30 12:59 FirasH New Issue
2014-11-30 13:00 FirasH File Added: 12841-Backport.diff
2014-11-30 13:00 FirasH Relationship added related to 0012668
2014-11-30 17:39 jghali Note Added: 0034261
2014-11-30 17:39 jghali Status new => resolved
2014-11-30 17:39 jghali Fixed in Version => 1.4.5.svn
2014-11-30 17:39 jghali Resolution open => fixed
2014-11-30 17:39 jghali Assigned To => jghali
2014-11-30 17:39 jghali Target Version 1.4.5.svn => 1.4.5
2014-11-30 20:12 FirasH Note Added: 0034264
2014-11-30 20:12 FirasH Status resolved => closed