View Issue Details

IDProjectCategoryView StatusLast Update
0013378ScribusUser Interfacepublic2015-09-29 11:04
ReporterFirasH Assigned ToFirasH  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.1svn 
Fixed in Version1.5.1svn 
Summary0013378: Fix non updated strings in "gradienteditor" after language change
DescriptionFix non updated strings in "gradienteditor" after language change.
Additional Information1.5.1.svn (20430)
TagsNo tags attached.
PatchYes

Activities

FirasH

2015-09-28 08:11

developer  

13378-Patch.diff (2,211 bytes)   

diff --git a/scribus/ui/gradienteditor.ui b/scribus/ui/gradienteditor.ui
--- a/scribus/ui/gradienteditor.ui
+++ b/scribus/ui/gradienteditor.ui
@@ -58,7 +58,7 @@
     </widget>
    </item>
    <item row="1" column="0">
-    <widget class="QLabel" name="Desc">
+    <widget class="QLabel" name="stopPosLabel">
      <property name="text">
       <string>Position:</string>
      </property>
@@ -75,7 +75,7 @@
     </widget>
    </item>
    <item row="2" column="0">
-    <widget class="QLabel" name="label">
+    <widget class="QLabel" name="stopColorLabel">
      <property name="text">
       <string>Color:</string>
      </property>
@@ -85,7 +85,7 @@
     <widget class="ColorCombo" name="stopColor"/>
    </item>
    <item row="3" column="0">
-    <widget class="QLabel" name="label_2">
+    <widget class="QLabel" name="stopOpacityLabel">
      <property name="text">
       <string>Opacity:</string>
      </property>
@@ -108,7 +108,7 @@
     </widget>
    </item>
    <item row="4" column="0">
-    <widget class="QLabel" name="label_3">
+    <widget class="QLabel" name="stopShadeLabel">
      <property name="text">
       <string>Shade:</string>
      </property>
diff --git a/scribus/ui/gradienteditor.cpp b/scribus/ui/gradienteditor.cpp
--- a/scribus/ui/gradienteditor.cpp
+++ b/scribus/ui/gradienteditor.cpp
@@ -171,8 +171,11 @@
 
 void GradientEditor::languageChange()
 {
-	Desc->setText( tr( "Position:" ) );
-	stopPos->setSuffix( tr(" %") );
+	stopPosLabel->setText( tr( "Position:" ));
+	stopPos->setSuffix( tr(" %"));
+	stopColorLabel->setText( tr("Color:"));
+	stopOpacityLabel->setText( tr("Opacity:"));
+	stopShadeLabel->setText( tr("Shade:"));
 }
 
 bool GradientEditor::event(QEvent * event)
diff --git a/scribus/ui/propertiespalette_line.cpp b/scribus/ui/propertiespalette_line.cpp
--- a/scribus/ui/propertiespalette_line.cpp
+++ b/scribus/ui/propertiespalette_line.cpp
@@ -649,7 +649,7 @@
 	lineType->updateList();
 	lineType->addItem( tr("Custom"));
 	lineType->setCurrentIndex(oldLineStyle);
-	int oldLineMode=lineMode->currentIndex();
+	int oldLineMode = lineMode->currentIndex();
 	lineMode->clear();
 	lineMode->addItem( tr("Left Point"));
 	lineMode->addItem( tr("End Points"));
13378-Patch.diff (2,211 bytes)   

Kunda

2015-09-28 18:52

updater   ~0036430

will these end up being in the translation files ?

jghali

2015-09-28 23:33

administrator   ~0036440

This is typically the case where the uic created retranslateUi() method can be used. So I modified the patch to use that method directly.

FirasH

2015-09-29 11:04

developer   ~0036443

Thanks jghali! This is for sure an easier and smarter fix!
Fixed in 1.5.1.svn (20435).

Issue History

Date Modified Username Field Change
2015-09-28 08:10 FirasH New Issue
2015-09-28 08:11 FirasH File Added: 13378-Patch.diff
2015-09-28 18:52 Kunda Note Added: 0036430
2015-09-28 23:33 jghali Note Added: 0036440
2015-09-28 23:33 jghali Status new => resolved
2015-09-28 23:33 jghali Fixed in Version => 1.5.1svn
2015-09-28 23:33 jghali Resolution open => fixed
2015-09-28 23:33 jghali Assigned To => FirasH
2015-09-29 11:04 FirasH Note Added: 0036443
2015-09-29 11:04 FirasH Status resolved => closed