View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0013467 | Scribus | General | public | 2015-10-25 08:08 | 2015-10-26 20:33 |
Reporter | aliyousuf | Assigned To | jghali | ||
Priority | normal | Severity | crash | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.5.1svn | ||||
Fixed in Version | 1.5.1svn | ||||
Summary | 0013467: crash when deleting footnote's frame | ||||
Description | Deleting a footnote's frame crashes scribes | ||||
Steps To Reproduce | create doc create text frame insert paragraph insert footnote in the middle of paragraph type text for footnote delete footnote's frame see crash | ||||
Additional Information | The crash I was fixing happens when you select the whole footnote frame (not the text inside it) and delete it, but from what I see this is not the issue being reported here. | ||||
Tags | HOST-Oman | ||||
Patch | Yes | ||||
|
issue13467.patch (515 bytes)
Index: scribus/pageitem_textframe.cpp =================================================================== --- scribus/pageitem_textframe.cpp (revision 20483) +++ scribus/pageitem_textframe.cpp (working copy) @@ -4936,6 +4936,10 @@ } else //remove marks without undo marksNum = removeMarksFromText(false); + + start = itemText.startOfSelection(); + stop = itemText.endOfSelection(); + itemText.setCursorPosition(start); //for sure text is still selected itemText.select(start, stop - start - marksNum); |
|
I upload issue1346.patch file that is answer for this assue |
|
In pageitem_textframe.cpp I found that calling m_Doc->deleteNote(note); at line 4905 causes itemText.length() to be decrease the footnote symbol has been deleted. Line 4941 call itemText.select() with old start and stop values. I fixed this ,My updating start and stop values. |
|
Patch applied, thanks! |
|
Fantastic! Committed in r20495 Thank you aliyousuf, KhaledHosny, and jean :) |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-10-25 08:08 | aliyousuf | New Issue | |
2015-10-25 08:10 | aliyousuf | File Added: issue13467.patch | |
2015-10-25 08:13 | aliyousuf | Note Added: 0036905 | |
2015-10-25 08:27 | aliyousuf | Note Added: 0036906 | |
2015-10-25 10:13 | jghali | Summary | crash when deleting footnote's fram => crash when deleting footnote's frame |
2015-10-25 10:13 | jghali | Steps to Reproduce Updated | |
2015-10-25 10:16 | jghali | Note Added: 0036907 | |
2015-10-25 10:16 | jghali | Status | new => resolved |
2015-10-25 10:16 | jghali | Fixed in Version | => 1.5.1svn |
2015-10-25 10:16 | jghali | Resolution | open => fixed |
2015-10-25 10:16 | jghali | Assigned To | => jghali |
2015-10-25 13:39 |
|
Tag Attached: HOST-Oman | |
2015-10-26 20:33 | Kunda | Note Added: 0036952 | |
2015-10-26 20:33 | Kunda | Status | resolved => closed |