View Issue Details

IDProjectCategoryView StatusLast Update
0013556ScribusInternalpublic2016-01-18 13:37
Reporteraliyousuf Assigned Tocbradney  
PriorityhighSeverityfeatureReproducibilitysometimes
Status closedResolutionfixed 
Product Version1.5.0 
Fixed in Version1.5.1svn 
Summary0013556: set of naming convention on scribus code
DescriptionNames are the heart of programming therefore I would like to use naming convention for scribus project to reduce the effort needed to read and understand source code so,Programmer can develop scribus very easy without going to understand syntax and naming standards.
It's best to choose a consistent set of naming conventions for use throughout scribus code , It help the developer to understand the scribus cod .In addition,I would recommend to start private member of class with m_ e.g.: m_finally,I would like to set naming conventions for classes, functions and objects..etc on scribus project to help developer/programmer.

https://github.com/AliYousuf/scribus/commit/da8d817e8d3e753ee0db61913511d332fb04e5a4
TagsHOST-Oman
PatchYes

Activities

cbradney

2015-11-24 22:34

administrator   ~0037656

r20577

aliyousuf

2015-11-25 15:50

reporter  

prefix1.zip (34,385 bytes)

aliyousuf

2015-11-25 15:55

reporter   ~0037676

I attache prifix1.zip
prefix private member in following class:
canvasmode_copyproperties
canvasmode_editmeshpatch
canvasmode_editpolygon
canvasmode_editspiral
canvasmode_editweldpoint
canvasmode_framelinks
canvasmode_imageimport
canvasmode_magnifier
canvasmode_nodeedit
canvasmode_normal
canvasmode_objimport
colorblind
filewatcher

the branch link : https://github.com/scribusproject/scribus/pull/36

Kunda

2015-11-27 14:09

updater   ~0037700

More patches have been attached to this ticket. Reopening

jghali

2015-11-27 23:35

administrator   ~0037709

Applied second patch.

Kunda

2015-11-27 23:49

updater   ~0037710

r20593

aliyousuf

2015-11-28 14:09

reporter  

prefix2.zip (30,621 bytes)

aliyousuf

2015-11-28 14:09

reporter   ~0037720

I attache prifix2.zip
I set prefix private member in following class:
fpoint
fpointarray
gtaction
gtfont
gtframestyle
gtgettext
gtmeasure
gtwriter
guidemanagercore
guidesmodel
langmgr
langmgr
latexhelpers
the branch link : https://github.com/scribusproject/scribus/pull/36 [^]

Kunda

2015-11-28 18:30

updater   ~0037724

aliyousuf FTW adding yet more patches. Re-opening

cbradney

2015-11-30 22:01

administrator   ~0037753

prefix2 files committed. please be careful with file names of the diff files. thanks!

Kunda

2015-11-30 22:02

updater   ~0037754

committed in r20606

Kunda

2015-12-01 21:30

updater   ~0037777

aliyousuf? Are there anymore ?

aliyousuf

2015-12-02 19:16

reporter   ~0037802

Kunda,Yes there are more?

Kunda

2015-12-02 22:17

updater   ~0037803

aliyousuf, sorry, hope you didn't take that the wrong way. I saw that you submitted more files to https://github.com/scribusproject/scribus/pull/36#commits-pushed-dc759aa

aliyousuf

2015-12-07 10:27

reporter   ~0037845

Last edited: 2015-12-07 18:46

I attache prefix3.zip for subdirectory "scribus/scribus" on scribus code
Setting prefix private member in following class:
localemgr, notesParStyle, pageitem_textfram, pagesize, pdflib, pdfwriter, prefscontext, prefsfile, prefsmanager, prefsreader, prefstable, qtiocompressor
sampleitem, sccolor, scfonts, scpainter, scration, scribus, scribusapp, scribuscore, scribusdoc, scribusview, selection, textwriter, undomanager, undostack, upgradechecker, util_formats, serializer

aliyousuf

2015-12-07 10:28

reporter  

prefix3.zip (102,532 bytes)

aliyousuf

2015-12-07 19:07

reporter   ~0037856

I attache prefix4.zip for subdirectory "scribus/scribus/desaxe" on scribus code
Setting prefix private member in following class:
digester, saxXML, uniqueide

aliyousuf

2015-12-07 19:08

reporter  

prefix4.zip (3,863 bytes)

aliyousuf

2015-12-07 19:10

reporter   ~0037857

Last edited: 2015-12-07 19:11

I attache prefix5.zip for subdirectory "scribus/scribus/downloadmanager" on scribus code
Setting prefix private member in following class:
scdlmgr, scdlthread

aliyousuf

2015-12-07 19:10

reporter  

prefix5.zip (3,153 bytes)

aliyousuf

2015-12-07 19:13

reporter   ~0037858

I attache prefix6.zip for subdirectory "scribus/scribus/fonts" on scribus code
Setting prefix private member in following class:
cff, ftface, scface, scface_ttf, sfnt

aliyousuf

2015-12-07 19:13

reporter  

prefix6.zip (12,994 bytes)

aliyousuf

2015-12-07 19:17

reporter   ~0037859

I attache prefix7.zip for subdirectory "scribus/scribus/imagedataloaders" on scribus code
Setting prefix private member in following class:
scimgdataloader_ora, scimgdataloader_pict, scimgdataloader_ps, scimgdataloader_psd, scimgdataloader_tiff

aliyousuf

2015-12-07 19:17

reporter  

prefix7.zip (17,635 bytes)

aliyousuf

2015-12-07 19:22

reporter   ~0037860

I attache prefix8.zip for subdirectory "scribus/scribus/style" and"scribus/scribus/text" on scribus code
Setting prefix private member in following class:
fsize, paragraphstyle

aliyousuf

2015-12-07 19:22

reporter  

prefix8.zip (3,550 bytes)

aliyousuf

2015-12-07 19:27

reporter   ~0037861

I attache prefix9.zip for subdirectory "scribus/scribus/tt/simpletreemodel"on scribus code
Setting prefix private member in following class:
treeitem, treemodel

aliyousuf

2015-12-07 19:27

reporter  

prefix9.zip (1,926 bytes)

JLuc

2015-12-30 22:23

developer   ~0038006

to be merged ?

Fahad

2016-01-13 08:08

developer   ~0038103

any update on this?

Kunda

2016-01-18 13:37

updater   ~0038239

Thanks so much aliyousuf for this effort and patch!
Commmitted by craig in r20691
Closing

Issue History

Date Modified Username Field Change
2015-11-24 06:50 aliyousuf New Issue
2015-11-24 21:35 Kunda Category General => Internal
2015-11-24 22:34 cbradney Status new => resolved
2015-11-24 22:34 cbradney Fixed in Version => 1.5.1svn
2015-11-24 22:34 cbradney Resolution open => fixed
2015-11-24 22:34 cbradney Assigned To => cbradney
2015-11-24 22:34 cbradney Note Added: 0037656
2015-11-25 05:04 Fahad Tag Attached: HOST-Oman
2015-11-25 07:36 aliyousuf File Added: prefix private member of class .patch
2015-11-25 07:37 aliyousuf File Deleted: prefix private member of class .patch
2015-11-25 15:50 aliyousuf File Added: prefix1.zip
2015-11-25 15:55 aliyousuf Note Added: 0037676
2015-11-27 14:09 Kunda Note Added: 0037700
2015-11-27 14:09 Kunda Status resolved => feedback
2015-11-27 14:09 Kunda Resolution fixed => reopened
2015-11-27 23:35 jghali Note Added: 0037709
2015-11-27 23:35 jghali Status feedback => resolved
2015-11-27 23:35 jghali Resolution reopened => fixed
2015-11-27 23:49 Kunda Note Added: 0037710
2015-11-28 14:09 aliyousuf File Added: prefix2.zip
2015-11-28 14:09 aliyousuf Note Added: 0037720
2015-11-28 18:30 Kunda Note Added: 0037724
2015-11-28 18:30 Kunda Status resolved => feedback
2015-11-28 18:30 Kunda Resolution fixed => reopened
2015-11-29 17:47 Kunda Patch No => Yes
2015-11-29 23:48 Kunda Sticky Issue No => Yes
2015-11-30 22:01 cbradney Note Added: 0037753
2015-11-30 22:02 Kunda Note Added: 0037754
2015-12-01 01:05 Kunda Status feedback => resolved
2015-12-01 21:30 Kunda Note Added: 0037777
2015-12-02 19:16 aliyousuf Note Added: 0037802
2015-12-02 22:17 Kunda Note Added: 0037803
2015-12-07 10:27 aliyousuf Note Added: 0037845
2015-12-07 10:28 aliyousuf File Added: prefix3.zip
2015-12-07 10:28 aliyousuf Note Edited: 0037845
2015-12-07 10:29 aliyousuf Note Edited: 0037845
2015-12-07 14:15 Kunda Status resolved => feedback
2015-12-07 18:46 aliyousuf Note Edited: 0037845
2015-12-07 19:07 aliyousuf Note Added: 0037856
2015-12-07 19:07 aliyousuf Status feedback => assigned
2015-12-07 19:08 aliyousuf File Added: prefix4.zip
2015-12-07 19:10 aliyousuf Note Added: 0037857
2015-12-07 19:10 aliyousuf File Added: prefix5.zip
2015-12-07 19:11 aliyousuf Note Edited: 0037857
2015-12-07 19:13 aliyousuf Note Added: 0037858
2015-12-07 19:13 aliyousuf File Added: prefix6.zip
2015-12-07 19:17 aliyousuf Note Added: 0037859
2015-12-07 19:17 aliyousuf File Added: prefix7.zip
2015-12-07 19:22 aliyousuf Note Added: 0037860
2015-12-07 19:22 aliyousuf File Added: prefix8.zip
2015-12-07 19:27 aliyousuf Note Added: 0037861
2015-12-07 19:27 aliyousuf File Added: prefix9.zip
2015-12-30 22:23 JLuc Note Added: 0038006
2016-01-13 08:08 Fahad Note Added: 0038103
2016-01-17 14:39 cbradney Status assigned => resolved
2016-01-17 14:39 cbradney Resolution reopened => fixed
2016-01-17 15:56 jghali Sticky Issue Yes => No
2016-01-18 13:37 Kunda Note Added: 0038239
2016-01-18 13:37 Kunda Status resolved => closed