Mantis Issue Tracking for Scribus
· Hosting provided by Anduin.net / Øverby Consulting ·

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002947ScribusScripterpublic05-Dec-31 18:2706-May-04 23:42
ReporterTomK32 
Assigned Tofschmid 
PrioritynormalSeveritytweakReproducibilityalways
StatusfeedbackResolutionreopened 
PlatformMacOSXOSMacOSXOS Version10.4 Tiger
Product Version1.3.2cvs 
Target VersionFixed in Version 
Summary0002947: faster FinishScriptRun
DescriptionI'm not absolutely sure if that litte if shouldn't be somewhere more in the core than in the scripter, but it is an improvment for me.

BTW: What is GroupOnPage() doing?


p54916e07:/Users/tomk32/Downloads/scribus/Scribus/scribus/plugins/scriptplugin root# cvs diff -u scriptercore.cpp
cvs diff: warning: failed to open /var/root/.cvspass for reading: No such file or directory
Index: scriptercore.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/plugins/scriptplugin/scriptercore.cpp,v
retrieving revision 1.1.2.38
diff -u -r1.1.2.38 scriptercore.cpp
--- scriptercore.cpp 28 Dec 2005 21:59:41 -0000 1.1.2.38
+++ scriptercore.cpp 31 Dec 2005 17:22:30 -0000
@@ -151,9 +151,12 @@
                for (uint azz=0; azz<ScMW->doc->Items->count(); ++azz)
                {
                        PageItem *ite = ScMW->doc->Items->at(azz);
+
                        if (ite->Groups.count() != 0)
                                ScMW->doc->GroupOnPage(ite);
                        else
+ if ( ! ite->Dirty)
+ continue;
                                ite->OwnPage = ScMW->doc->OnPage(ite);
                        //ScMW->view->setRedrawBounding(ite);
                        ite->setRedrawBounding();
TagsNo tags attached.
Attached Files

- Relationships
child of 0003813acknowledged Metabug: Scripter 

-  Notes
(0007876)
plinnell (administrator)
06-Jan-01 01:53

Reminder sent to: subik

Thoughts on this ?
(0007888)
subik (manager)
06-Jan-01 18:37

well, I'll look at it. Unfortunatelly I'm not an author of this code ;)
(0007905)
fschmid (administrator)
06-Jan-03 10:56

This patch would result in a faster execution sure, but the results would be incorrect as the dirty flag is meant for fast redraw of already correct layouted textframes. This is not the case here, textframe need a complete relayouting here.
(0007906)
TomK32 (reporter)
06-Jan-03 11:14

Right now the complete document is redraw, not only the text frame. and with my 60+ pages documentes, even if half empty, it's a pain and takes half a minute sometimes.
(0009972)
mhanski (developer)
06-Apr-14 22:07

is it a "won't fix", can we close?
(0010936)
plinnell (administrator)
06-May-04 23:42

This will get fixed with Andrea's refactoring of some of the drawing code.

- Issue History
Date Modified Username Field Change
05-Dec-31 18:27 TomK32 New Issue
06-Jan-01 01:52 plinnell Status new => assigned
06-Jan-01 01:52 plinnell Assigned To => fschmid
06-Jan-01 01:53 plinnell Note Added: 0007876
06-Jan-01 18:37 subik Note Added: 0007888
06-Jan-03 10:56 fschmid Status assigned => resolved
06-Jan-03 10:56 fschmid Resolution open => won't fix
06-Jan-03 10:56 fschmid Note Added: 0007905
06-Jan-03 11:14 TomK32 Status resolved => feedback
06-Jan-03 11:14 TomK32 Resolution won't fix => reopened
06-Jan-03 11:14 TomK32 Note Added: 0007906
06-Apr-14 22:07 mhanski Note Added: 0009972
06-May-04 23:10 mhanski Note Added: 0010927
06-May-04 23:10 mhanski Note Deleted: 0010927
06-May-04 23:42 plinnell Note Added: 0010936
06-May-13 23:01 christoph_s Relationship added child of 0003813



Copyright © 2000 - 2013 MantisBT Team
Powered by Mantis Bugtracker