View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007701 | Scribus | Import / Export | public | 2009-01-03 22:25 | 2009-01-09 21:14 |
Reporter | dbolack | Assigned To | jghali | ||
Priority | normal | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86_64 | OS | Fedora | OS Version | 10 |
Product Version | 1.3.5svn | ||||
Fixed in Version | 1.3.5svn | ||||
Summary | 0007701: ODT Import segfaults | ||||
Description | Importing of valid ODT files segfaults. This was caused by two issues. 1) A call to the stylereader parser passing it the content filename. I did not dig deeper into this one at the moment as it seems like this is an error. The line was commented out. 2) An assumption that a liststyle is present for all lists. This doesn't seem to be an absolute requirement. This was handled by watching for a NULL Liststyle and not trying to run methods off of it. | ||||
Steps To Reproduce | 1. Import any odt document. 2. Import any ODT document with a list in the "default" style. | ||||
Additional Information | Patch attached. | ||||
Tags | No tags attached. | ||||
Patch | |||||
2009-01-03 22:25
|
|
|
slightly modified patch applied |
|
This still segfaults. Look at the line sreader->parse( filename ) in the contentreader.cpp's contentreader::parse method. The filename being pased is the "content" file rather than the "style" file and I think this may be the issue. I'm not sure. comment out this line and everything behaves correctly. I'm attaching a file that never fails to segfault for me. |
2009-01-05 04:19
|
|
|
The line sreader->parse( filename ) is not an error, must be kept and must parse the content file. |
2009-01-05 11:38
|
|
|
I found an issue in stylereader.cpp, it was not gracefully handling a lookup of the default style in the style map when the default style was not created. I put in a "Is it there?" check and it gets on fine. I attached a patch. I imagine you'll also want to figure out why the default wasn't created. |
|
Fixed in a slightly different way. |
Date Modified | Username | Field | Change |
---|---|---|---|
2009-01-03 22:25 | dbolack | New Issue | |
2009-01-03 22:25 | dbolack | File Added: odtim.dff | |
2009-01-04 21:43 | jghali | Note Added: 0020865 | |
2009-01-04 21:43 | jghali | Status | new => resolved |
2009-01-04 21:43 | jghali | Fixed in Version | => 1.3.5svn |
2009-01-04 21:43 | jghali | Resolution | open => fixed |
2009-01-04 21:43 | jghali | Assigned To | => jghali |
2009-01-05 04:19 | dbolack | Note Added: 0020871 | |
2009-01-05 04:19 | dbolack | Status | resolved => feedback |
2009-01-05 04:19 | dbolack | Resolution | fixed => reopened |
2009-01-05 04:19 | dbolack | File Added: AbiWord_Graphics.odt | |
2009-01-05 07:08 | jghali | Note Added: 0020872 | |
2009-01-05 11:38 | dbolack | File Added: odtim.diff2 | |
2009-01-05 11:40 | dbolack | Note Added: 0020878 | |
2009-01-05 18:06 | jghali | Note Added: 0020880 | |
2009-01-05 18:06 | jghali | Status | feedback => resolved |
2009-01-05 18:06 | jghali | Resolution | reopened => fixed |
2009-01-09 21:14 | cbradney | Status | resolved => closed |