View Issue Details

IDProjectCategoryView StatusLast Update
0008442ScribusCanvaspublic2011-03-06 16:20
Reporterale Assigned Toale  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.0svn 
Target Version1.4.0svnFixed in Version1.4.0svn 
Summary0008442: ctrl+d should import vector files
Descriptionif no frame is selected, ctrl+d should show the import dialog for vector files.
TagsNo tags attached.
Patch

Activities

GurgiONE

2009-09-23 07:51

reporter   ~0022518

Please use some other key combination. CTRL+D is often duplicate object!

jghali

2009-09-23 09:43

administrator   ~0022521

Yep, Ctrl+D should be avoided for vector import.

ale

2009-09-23 20:41

manager   ~0022525

then, ctrl+d should be avoided for all imports!

i'm comfortable to have ctrl+d for duplicate (btw, i proposed to use ctrl+d to import vector when nothing is selected: i don't know what you would duplicate when nothing is selected)

i propose to use ctrl+g for get on text and image frames and for vector if none of both are currently selected. (even if it may be better to use ctrl+g as a go to page...)

or ctrl+i for import?

the goal of my bug report is to have the same key for all the imports... i don't care which key is choosen (but, please, choose a ctrl+letter shortcut, since it's something which should be very fast and painless to use)

christoph_s

2009-09-24 04:29

administrator   ~0022529

Agreed. Ctrl+I sounds reasonable for a context-sensitive import.

ale

2009-10-25 23:47

manager   ~0022746

Last edited: 2009-10-26 00:09

the first two patches define ctrl+d as the shortcut to import vector files when nothing is selected.

this implementation disables importing vectors when a frame (or any object) is already selected:
* on the one side this a functionality regression.
* on the other side, it may be the expected behaviour.
* finally: i'm not sure if the current framework allows another way to implement it.

ale

2009-10-26 00:00

manager   ~0022747

Last edited: 2009-10-26 00:10

the third one, on top of the first, replaces ctrl-d with ctrl-i for importing content and sets ctrl-d as the shortcut for duplicating an item.

ale

2009-10-26 17:34

manager   ~0022749

uploaded the two *.03.patch: they replace the precedent ones.

2009-10-26 17:35

 

actionmanager.cpp.03.patch (1,142 bytes)   
--- actionmanager.cpp~	2009-10-25 23:09:40.000000000 +0100
+++ actionmanager.cpp	2009-10-26 17:40:17.000000000 +0100
@@ -1594,8 +1594,9 @@
 	defKeys.insert("fileClose", QKeySequence::Close);
 	defKeys.insert("fileSave", QKeySequence::Save);
 	defKeys.insert("fileSaveAs", Qt::CTRL+Qt::SHIFT+Qt::Key_S);
-	defKeys.insert("fileImportText", Qt::CTRL+Qt::Key_D);
-	defKeys.insert("fileImportImage", Qt::CTRL+Qt::Key_D);
+	defKeys.insert("fileImportText", Qt::CTRL+Qt::Key_I);
+	defKeys.insert("fileImportImage", Qt::CTRL+Qt::Key_I);
+	defKeys.insert("fileImportVector", Qt::CTRL+Qt::Key_I);
 	defKeys.insert("filePrint", QKeySequence::Print);
 	defKeys.insert("PrintPreview", Qt::CTRL+Qt::ALT+Qt::Key_P);
 	defKeys.insert("fileQuit", Qt::CTRL+Qt::Key_Q);
@@ -1616,7 +1617,7 @@
 	defKeys.insert("styleImageEffects", Qt::CTRL+Qt::Key_E);
 
 	//Item Menu
-	defKeys.insert("itemDuplicate", Qt::CTRL+Qt::ALT+Qt::SHIFT+Qt::Key_D);
+	defKeys.insert("itemDuplicate", Qt::CTRL+Qt::Key_D);
 	defKeys.insert("itemDelete", Qt::CTRL+Qt::Key_K);
 	defKeys.insert("itemGroup", Qt::CTRL+Qt::Key_G);
 	defKeys.insert("itemUngroup", Qt::CTRL+Qt::SHIFT+Qt::Key_G);
actionmanager.cpp.03.patch (1,142 bytes)   

2009-10-26 22:39

 

scribus.cpp.03.patch (2,896 bytes)   
--- scribus.cpp~	2009-10-25 23:31:04.000000000 +0100
+++ scribus.cpp	2009-10-26 23:41:13.000000000 +0100
@@ -645,6 +645,7 @@
 	scrActions["fileImportText"]->setEnabled(false);
 	scrActions["fileImportText2"]->setEnabled(false);
 	scrActions["fileImportImage"]->setEnabled(false);
+    scrActions["fileImportVector"]->setEnabled(false);
 	scrActions["fileImportAppendText"]->setEnabled(false);
 	scrActions["pageImport"]->setEnabled(false);
 	scrActions["fileExportText"]->setEnabled(false);
@@ -2957,6 +2958,7 @@
 		scrActions["fileImportText"]->setEnabled(false);
 		scrActions["fileImportText2"]->setEnabled(false);
 		scrActions["fileImportImage"]->setEnabled(false);
+		scrActions["fileImportVector"]->setEnabled(true);
 		scrActions["fileImportAppendText"]->setEnabled(false);
 		scrActions["fileExportText"]->setEnabled(false);
 		scrMenuMgr->setMenuEnabled("Item", false);
@@ -2994,6 +2996,7 @@
 		scrActions["fileImportText"]->setEnabled(false);
 		scrActions["fileImportText2"]->setEnabled(false);
 		scrActions["fileImportImage"]->setEnabled(true);
+		scrActions["fileImportVector"]->setEnabled(false);
 		scrActions["editCut"]->setEnabled(true);
 		scrActions["editCopy"]->setEnabled(true);
 		scrMenuMgr->setMenuEnabled("EditContents", true);
@@ -3026,6 +3029,7 @@
 		scrActions["fileImportText"]->setEnabled(true);
 		scrActions["fileImportText2"]->setEnabled(true);
 		scrActions["fileImportImage"]->setEnabled(false);
+		scrActions["fileImportVector"]->setEnabled(false);
 		scrActions["fileImportAppendText"]->setEnabled(true);
 		scrActions["fileExportText"]->setEnabled(true);
 		scrActions["editCut"]->setEnabled(true);
@@ -3129,6 +3133,7 @@
 		scrActions["fileImportText"]->setEnabled(true);
 		scrActions["fileImportText2"]->setEnabled(true);
 		scrActions["fileImportImage"]->setEnabled(false);
+		scrActions["fileImportVector"]->setEnabled(false);
 		scrActions["fileImportAppendText"]->setEnabled(true);
 		scrActions["fileExportText"]->setEnabled(true);
 		scrActions["editCut"]->setEnabled(true);
@@ -3176,6 +3181,7 @@
 		scrActions["fileImportText"]->setEnabled(false);
 		scrActions["fileImportText2"]->setEnabled(false);
 		scrActions["fileImportImage"]->setEnabled(false);
+		scrActions["fileImportVector"]->setEnabled(true);
 		scrActions["fileImportAppendText"]->setEnabled(false);
 		scrActions["fileExportText"]->setEnabled(false);
 		scrActions["editCut"]->setEnabled(true);
@@ -4310,7 +4316,7 @@
 			slotDocCh();
 			styleManager->setDoc(doc);
 		}
-	}
+    }
 }
 
 void ScribusMainWindow::slotGetContent2() // kk2006
@@ -4659,6 +4665,7 @@
 		scrActions["fileImportText"]->setEnabled(false);
 		scrActions["fileImportText2"]->setEnabled(false);
 		scrActions["fileImportImage"]->setEnabled(false);
+		scrActions["fileImportVector"]->setEnabled(false);
 		scrActions["fileImportAppendText"]->setEnabled(false);
 		scrActions["pageImport"]->setEnabled(false);
 
scribus.cpp.03.patch (2,896 bytes)   

ale

2010-04-14 21:00

manager   ~0023694

is there any reason why there is no comment in here from the team and the patches have not been applied?

cbradney

2010-04-14 21:34

administrator   ~0023695

control i would be used for italics... one day

ale

2010-04-15 21:26

manager   ~0023703

can we have control-i only do italics when being in text edit modus? and otherwise import?

... there are not so much letter on the keyboard...

cbradney

2010-06-10 21:59

administrator   ~0024039

We can't apply this patch for a number of reasons:
a) image frames support importing pixel formats, plus some vectors like eps, so both actions need to be active. Your patch removes this functionality
b) you disable importing vectors when there are no frames
c) some of the other enable/disable lines are not required

a) is the biggest issue, and cannot be fixed without removing the idea of having the same shortcut for importing images and vectors

Of course, swapping the shortcuts is a trivial thing

ale

2010-06-11 05:56

manager   ~0024040

sorry, craig, i really don't understand to what case a) should apply.

if you want to import a vector file into an image frame you have to use load image, which is what ctrl-d will do when you have an image frame selected.

even if it is something i'd really love to have, there is currently no way to import a vector file into a frame without using "load image".


b) may be an issue, i have to check it. this should not happen.

c) you may have to be a more specific here...


and the biggest issue, for me, is that it took the team 8 months to go through this almost trivial patch.
i understand that your time resources are tight, but "scaring away" people contributing patches is imo the latest thing you need.

cbradney

2010-06-12 09:41

administrator   ~0024056

a) you need to have both import image and import vector active when image frames are selected, you can't do that if they have the same shortcut as then both will run when you press the shortcut
b/c) just too much code in the patch.. unnecessary enables and disables. import vector should be active when the doc is new and, by your patch, when nothing is selected.

cbradney

2010-06-17 20:50

administrator   ~0024121

Control I/D have been swapped in SVn, nuke your shortcut prefs to see this.

plinnell

2011-02-16 10:54

viewer   ~0025607

Moving to later release.

Issue History

Date Modified Username Field Change
2009-09-18 21:37 ale New Issue
2009-09-18 21:37 ale Product Version 1.3.6svn => 1.5.0svn
2009-09-19 02:04 christoph_s Status new => acknowledged
2009-09-19 02:05 christoph_s Target Version => 1.4.0
2009-09-23 07:51 GurgiONE Note Added: 0022518
2009-09-23 09:43 jghali Note Added: 0022521
2009-09-23 20:41 ale Note Added: 0022525
2009-09-24 04:29 christoph_s Note Added: 0022529
2009-10-25 23:41 ale File Added: actionmanager.cpp.patch
2009-10-25 23:41 ale File Added: scribus.cpp.patch
2009-10-25 23:47 ale Note Added: 0022746
2009-10-25 23:47 ale Note Edited: 0022746
2009-10-26 00:00 ale Note Added: 0022747
2009-10-26 00:02 ale File Added: actionmanager.cpp.02.patch
2009-10-26 00:09 ale Note Edited: 0022746
2009-10-26 00:10 ale Note Edited: 0022747
2009-10-26 17:34 ale Note Added: 0022749
2009-10-26 17:35 ale File Deleted: actionmanager.cpp.patch
2009-10-26 17:35 ale File Deleted: scribus.cpp.patch
2009-10-26 17:35 ale File Deleted: actionmanager.cpp.02.patch
2009-10-26 17:35 ale File Added: actionmanager.cpp.03.patch
2009-10-26 17:35 ale File Added: scribus.cpp.03.patch
2009-10-26 22:38 ale File Deleted: scribus.cpp.03.patch
2009-10-26 22:39 ale File Added: scribus.cpp.03.patch
2010-04-14 21:00 ale Note Added: 0023694
2010-04-14 21:34 cbradney Note Added: 0023695
2010-04-15 21:26 ale Note Added: 0023703
2010-06-10 21:59 cbradney Note Added: 0024039
2010-06-11 05:56 ale Note Added: 0024040
2010-06-12 09:41 cbradney Note Added: 0024056
2010-06-17 20:50 cbradney Note Added: 0024121
2011-02-16 10:54 plinnell Note Added: 0025607
2011-02-16 10:54 plinnell Assigned To => ale
2011-02-16 10:54 plinnell Target Version 1.4.0 => 1.4.1.svn
2011-02-16 16:07 cbradney Status acknowledged => resolved
2011-02-16 16:07 cbradney Fixed in Version => 1.4.0svn
2011-02-16 16:07 cbradney Resolution open => fixed
2011-02-16 16:07 cbradney Status resolved => closed
2011-03-06 16:20 cbradney Target Version 1.4.1.svn => 1.4.0svn