View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0009543 | Scribus | Undo/Redo | public | 2010-12-01 17:17 | 2010-12-03 02:04 |
Reporter | bubu | Assigned To | ale | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Fixed in Version | 1.4.0svn | ||||
Summary | 0009543: Add horizontal guide displayed as vertical in history | ||||
Description | Add horizontal guide to the page. On Action History palette displayed as "Add vertical guide". Moving guide produces the same error. See attached screenshot. | ||||
Tags | No tags attached. | ||||
Patch | |||||
|
|
|
guidemanagercore.cpp.patch (1,446 bytes)
--- guidemanagercore.cpp 2010-12-01 21:37:17.000000000 +0100 +++ guidemanagercore.cpp~ 2010-12-01 21:37:08.000000000 +0100 @@ -73,7 +73,7 @@ horizontalStdG.append(value); if (UndoManager::undoEnabled()) { - SimpleState* ss = new SimpleState(Um::AddVGuide, 0, Um::IGuides); + SimpleState* ss = new SimpleState(Um::AddHGuide, 0, Um::IGuides); ss->set("ADD_H", value); undoManager->action(m_page, ss); } @@ -153,7 +153,7 @@ horizontalStdG.removeAt(horizontalStdG.indexOf(value)); if (UndoManager::undoEnabled()) { - SimpleState* ss = new SimpleState(Um::DelVGuide, 0, Um::IGuides); + SimpleState* ss = new SimpleState(Um::DelHGuide, 0, Um::IGuides); ss->set("REMOVE_H", value); undoManager->action(m_page, ss); } @@ -345,7 +345,7 @@ { for (int i = 0; i < horizontalStdG.count(); ++i) { - SimpleState* ss = new SimpleState(Um::DelVGuide, 0, Um::IGuides); + SimpleState* ss = new SimpleState(Um::DelHGuide, 0, Um::IGuides); ss->set("REMOVE_H", horizontalStdG[i]); undoManager->action(m_page, ss); } @@ -412,7 +412,7 @@ horizontalStdG.append(to); if (UndoManager::undoEnabled()) { - SimpleState* ss = new SimpleState(Um::MoveVGuide, 0, Um::IGuides); + SimpleState* ss = new SimpleState(Um::MoveHGuide, 0, Um::IGuides); ss->set("MOVE_H_FROM", from); ss->set("MOVE_H_TO", to); undoManager->action(m_page, ss); |
|
the patch fixes the issue in 1.5svn ... that was not really hard... :-) |
|
Comitted! Thanks! |
Date Modified | Username | Field | Change |
---|---|---|---|
2010-12-01 17:17 | bubu | New Issue | |
2010-12-01 17:17 | bubu | File Added: action_history.png | |
2010-12-01 18:56 | christoph_s | Assigned To | => christoph_s |
2010-12-01 18:56 | christoph_s | Status | new => confirmed |
2010-12-01 20:35 | ale | File Added: guidemanagercore.cpp.patch | |
2010-12-01 21:36 | ale | Note Added: 0024957 | |
2010-12-01 21:37 | ale | Assigned To | christoph_s => ale |
2010-12-01 21:37 | ale | Status | confirmed => assigned |
2010-12-01 21:38 | ale | Status | assigned => confirmed |
2010-12-02 23:42 | jghali | Summary | Add horizontal guide displayed as vertical => Add horizontal guide displayed as vertical in history |
2010-12-02 23:43 | jghali | Note Added: 0024965 | |
2010-12-02 23:43 | jghali | Status | confirmed => resolved |
2010-12-02 23:43 | jghali | Fixed in Version | => 1.4.0svn |
2010-12-02 23:43 | jghali | Resolution | open => fixed |
2010-12-03 02:04 | christoph_s | Status | resolved => closed |