View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010631 | Scribus | User Interface | public | 2012-03-15 06:34 | 2016-12-22 14:01 |
| Reporter | richardpaulhall | Assigned To | Kunda | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | unable to reproduce | ||
| Platform | PC | OS | WIndows | OS Version | XP SP3 |
| Product Version | 1.4.0 | ||||
| Summary | 0010631: Use Close Gadget, Scribus Always Asks To Save | ||||
| Description | When finished with a Scribus document I type Ctrl-S to save and then click the Red X, the Windows Close gadget. Scribus ALWAYS prompts if I want to save my document. But I have saved the file, so the file cannot be 'dirty'. | ||||
| Steps To Reproduce | Open a file in Scribus, type Ctrl-S to save and then click the Red X, the Windows Close gadget. | ||||
| Tags | dirty | ||||
| Patch | Yes | ||||
| related to | 0014482 | new | Closing Scribus After Saving File (ctrl-S), User Prompted to Save File |
|
|
Unable to reproduce here. |
|
|
This issue isn't Windows-specific, at least on Ubuntu it still appears (r17372 in /branches/Version14x with a hopefully unrelated patch, the latest one in 0010581, applied), I've just tested. When I save an edit, then use close gadget, the the prompt about saving appears. If I choose "Cancel" there, the document is marked as "changed" (the asterisk) and the prompt will reappear on another close by the close gadget, but if I save after such a "Cancel" (despite not having changed anything), then it closes OK. |
|
|
scribus.cpp.patch (423 bytes)
Index: scribus/scribus.cpp
===================================================================
--- scribus/scribus.cpp (revision 17422)
+++ scribus/scribus.cpp (working copy)
@@ -1661,7 +1661,9 @@
{
newActWin(windows.at(i));
tw = ActWin;
+ bool isModified = ActWin->doc()->isModified;
slotSelect();
+ ActWin->doc()->setModified(isModified);
ActWin->close();
if (tw == ActWin)
{
|
|
|
After the file is save isModified flag of doc is set to false. When the close button is clicked, in slot select isModified flag is changing. slotSelect() triggers other functions(one of them is pageItem->update() ). This page item update emits the doc changed signal. So isModified flas is unnecessarily getting modified. |
|
|
Let me see if I understand: (OSX 10.10.5 1.5.3svn r21350 OR 1.4.6) 1) Open a document 2) Save it 3) click on 'Close' icon (AKA ctrl+w) Result: No prompt to save So, I can't reproduce. |
|
|
Resolving unless someone can reproduce. |
|
|
Closing |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-03-15 06:34 | richardpaulhall | New Issue | |
| 2012-03-15 22:04 | jghali | Note Added: 0027819 | |
| 2012-03-15 22:08 | mabri | Note Added: 0027820 | |
| 2012-03-15 22:15 | mabri | Note Edited: 0027820 | |
| 2012-04-13 09:44 | janardhan | File Added: scribus.cpp.patch | |
| 2012-04-13 10:11 | janardhan | Note Added: 0027925 | |
| 2013-02-01 07:49 | christoph_s | Assigned To | => christoph_s |
| 2013-02-01 07:49 | christoph_s | Status | new => confirmed |
| 2013-02-01 07:50 | christoph_s | Assigned To | christoph_s => |
| 2016-05-24 13:41 | Kunda | Tag Attached: dirty | |
| 2016-05-24 13:43 | Kunda | Patch | => Yes |
| 2016-05-24 13:44 | Kunda | Tag Attached: #please_test | |
| 2016-05-24 14:54 | Kunda | Target Version | => 1.6 milestone |
| 2016-05-24 16:28 | Kunda | Note Added: 0041373 | |
| 2016-05-24 16:28 | Kunda | Tag Attached: #pending | |
| 2016-05-24 16:28 | Kunda | Tag Attached: #tobeclosed | |
| 2016-05-24 16:30 | Kunda | Note Edited: 0041373 | |
| 2016-05-24 16:31 | Kunda | Note Added: 0041374 | |
| 2016-05-24 16:31 | Kunda | Status | confirmed => resolved |
| 2016-05-24 16:31 | Kunda | Resolution | open => unable to reproduce |
| 2016-05-24 16:31 | Kunda | Assigned To | => Kunda |
| 2016-05-29 14:41 | Kunda | Note Added: 0041544 | |
| 2016-05-29 14:41 | Kunda | Status | resolved => closed |
| 2016-05-29 14:42 | Kunda | Tag Detached: #tobeclosed | |
| 2016-05-29 14:42 | Kunda | Tag Detached: #please_test | |
| 2016-05-29 14:42 | Kunda | Tag Detached: #pending | |
| 2016-11-21 02:00 | Kunda | Target Version | 1.6 milestone => |
| 2016-12-22 14:01 | Kunda | Relationship added | related to 0014482 |
