View Issue Details

IDProjectCategoryView StatusLast Update
0011185ScribusBuild Systempublic2012-11-22 07:50
Reporterale Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0011185: trunk does not compile (/importpdf.cpp:104:25: error: no matching function for call to ‘SplashOutputDev::startDoc(PDFDoc*&)’)
Description/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp: In member function ‘QImage PdfPlug::readThumbnail(QString)’:
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:104:25: error: no matching function for call to ‘SplashOutputDev::startDoc(PDFDoc*&)’
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:104:25: note: candidate is:
In file included from /home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:24:0:
/usr/include/poppler/SplashOutputDev.h:348:8: note: void SplashOutputDev::startDoc(XRef*)
/usr/include/poppler/SplashOutputDev.h:348:8: note: no known conversion for argument 1 from ‘PDFDoc*’ to ‘XRef*’
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp: In member function ‘bool PdfPlug::convert(QString)’:
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:728:43: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:732:45: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:741:48: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:361:6: warning: unused variable ‘currentLayer’ [-Wunused-variable]
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp: In member function ‘QImage PdfPlug::readPreview(int, int, int)’:
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:846:24: error: no matching function for call to ‘SplashOutputDev::startDoc(PDFDoc*&)’
/home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:846:24: note: candidate is:
In file included from /home/ale/docs/src/scribus/scribus/plugins/import/pdf/importpdf.cpp:24:0:
/usr/include/poppler/SplashOutputDev.h:348:8: note: void SplashOutputDev::startDoc(XRef*)
/usr/include/poppler/SplashOutputDev.h:348:8: note: no known conversion for argument 1 from ‘PDFDoc*’ to ‘XRef*’
make[2]: *** [scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/importpdf.cpp.o] Error 1
make[1]: *** [scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/all] Error 2
make: *** [all] Error 2
TagsNo tags attached.
Patch

Activities

ale

2012-11-21 16:01

manager   ~0029230

maybe...

--- a/Scribus/scribus/plugins/import/pdf/importpdf.cpp
+++ b/Scribus/scribus/plugins/import/pdf/importpdf.cpp
@@ -99,7 +99,7 @@ QImage PdfPlug::readThumbnail(QString fName)
                                SplashOutputDev *dev = new SplashOutputDev(splashModeXBGR8, 4, gFalse, bgColor, gTrue, gTrue);
                                dev->setVectorAntialias(gTrue);
                                dev->setFreeTypeHinting(gTrue, gFalse);
- dev->startDoc(pdfDoc);
+ dev->startDoc(pdfDoc->getXRef());
                                pdfDoc->displayPage(dev, 1, hDPI, vDPI, 0, gTrue, gFalse, gFalse);
                                SplashBitmap *bitmap = dev->getBitmap();
                                int bw = bitmap->getWidth();

ale

2012-11-21 16:20

manager   ~0029231

scribus/plugins/import/pdf/slaoutput.cpp also has errors...

jghali

2012-11-21 17:52

administrator   ~0029234

It seems you are using a too old (or too new) poppler version. Trunk currently compiles fine with poppler 0.20.x.

ale

2012-11-21 19:15

manager   ~0029237

probably too old, then...

please update the minimal poppler requirements if they are not correct anymore (currently 0.17, which is met by my 0.18)

fschmid

2012-11-21 19:17

administrator   ~0029238

The poppler version you are using is too old, please update to a new version. Your version must be 0.17.3 or something, current is 0.20.5 or 0.21.1

alex326

2012-11-21 21:32

reporter   ~0029243

I also met this error when building 1.5.0svn on Fedora 17 some days ago. And indeed I have poppler 0.18.4 (the one currently provided by Fedora 17).

cbradney

2012-11-21 21:59

administrator   ~0029244

Minimum poppler has been bumped to 0.19.0. Nuke your build tree, re-run cmake and try building.

christoph_s

2012-11-22 07:49

administrator   ~0029251

I ran across the same issue, and updating poppler solved it, so Craig's CMake update fixed the issue.

Issue History

Date Modified Username Field Change
2012-11-21 13:51 ale New Issue
2012-11-21 16:01 ale Note Added: 0029230
2012-11-21 16:20 ale Note Added: 0029231
2012-11-21 17:52 jghali Note Added: 0029234
2012-11-21 19:15 ale Note Added: 0029237
2012-11-21 19:17 fschmid Note Added: 0029238
2012-11-21 21:32 alex326 Note Added: 0029243
2012-11-21 21:59 cbradney Note Added: 0029244
2012-11-22 07:49 christoph_s Note Added: 0029251
2012-11-22 07:49 christoph_s Status new => resolved
2012-11-22 07:49 christoph_s Fixed in Version => 1.5.0svn
2012-11-22 07:49 christoph_s Resolution open => fixed
2012-11-22 07:49 christoph_s Assigned To => cbradney
2012-11-22 07:50 christoph_s Status resolved => closed