View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012005 | Scribus | Story Editor / Text Frames | public | 2014-01-22 13:39 | 2016-01-20 21:25 |
| Reporter | ale | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | new | Resolution | open | ||
| Summary | 0012005: GetText2? | ||||
| Description | with the xtg text loader plugin, a GetText2 function has been introduced. on the one side, the commit message does not specify why the new function has been introduced in gtgettext.cpp, if this method should be used in place of the GetText used by all the other text loading plugins. on the second side, when you load text content through a plugin that does not define it, you get a "GetText2" missing warning. not a nice thing. and on the third side, it's not clear to me what the improvement of GetText2 is. at a first sight, it looks like, passing textItem is a better option, but -- at the end -- the plugin only uses textItem to extract gWriter from there, which is the parameter of GetText. (ok, i guess that if it could also avoid to get the current document through a static call...). so, can somebody in the team have a look at it, and: - add some documentation in the code explaining why GetText2 is there, or - remove GetText2 and patch the xtg loader to use the good old (ok, old.) GetText? | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
