View Issue Details

IDProjectCategoryView StatusLast Update
0012527ScribusGeneralpublic2016-12-08 22:04
ReporterFirasH Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status confirmedResolutionopen 
Platformx86_64OSopenSUSEOS Version13.1
Product Version1.5.0svn 
Target Version1.5.4Fixed in Version 
Summary0012527: "Image Scaling" in Preferences/Document Setup not working
Description"Image Scaling" in Preferences/Document Setup not working.
Steps To Reproduce0) Create a new document
1) Go to: File > Document Setup... > Item Tools > Images
2) Set Vertical/Horizontal Scaling to 50%
3) Click OK
4) Insert an Image Frame
5) Load an image inside of the Image Frame

The image scaling is set to Free Scaling 100%.

Same behaviour changing File > Preferences.
Additional InformationIssue present on:
1.4.5.svn (19334)
1.5.0.svn (19342)
TagsHOST-Oman
PatchYes

Activities

Kunda

2014-07-15 21:03

manager   ~0032771

Confirmed on OSX 10.8.5 1.5.0.svn (19342)

cbradney

2014-07-15 21:48

administrator   ~0032773

Actually this work up until point 4. Loading an image into a frame resets all those values.

shamsa

2015-11-10 06:34

reporter   ~0037370

Hello
I worked on this last days.
I fix this by set the value of x,y scale of the image after loading the picture to the x, y scale values setted through document setup . And there is something else, when delete the image only from the frame, the frame scale change to 100% ( default value ) which is not correct, It must be the same value setted in document setup. This is fixed by set image x,y scales to document setup values instead of 100%.

Please check it. I hope it works fine with you

shamsa

2015-11-10 06:37

reporter  

Issue#0012527.patch (1,267 bytes)
Index: canvasmode_imageimport.cpp
===================================================================
--- canvasmode_imageimport.cpp	(revision 20478)
+++ canvasmode_imageimport.cpp	(working copy)
@@ -235,6 +235,7 @@
 	currItem->IRender = m_doc->cmsSettings().DefaultIntentImages;
 	qApp->processEvents(QEventLoop::ExcludeUserInputEvents);
 	m_doc->loadPict(fileName, currItem, false, true);
+	currItem->setImageXYScale((m_doc->itemToolPrefs().imageScaleX * 72 / currItem->pixm.imgInfo.xres), (m_doc->itemToolPrefs().imageScaleY* 72 / currItem->pixm.imgInfo.yres));
 	m_ScMW->propertiesPalette->imagePal->showScaleAndOffset(currItem->imageXScale(), currItem->imageYScale(), currItem->imageXOffset(), currItem->imageYOffset());
 	m_ScMW->repaint();
 	qApp->processEvents(QEventLoop::ExcludeUserInputEvents);
Index: pageitem_imageframe.cpp
===================================================================
--- pageitem_imageframe.cpp	(revision 20478)
+++ pageitem_imageframe.cpp	(working copy)
@@ -234,8 +234,8 @@
 	Pfile = "";
 	pixm = ScImage();
 
-	m_imageXScale = 1;
-	m_imageYScale = 1;
+	m_imageXScale = m_Doc->prefsData().itemToolPrefs.imageScaleX;
+	m_imageYScale = m_Doc->prefsData().itemToolPrefs.imageScaleY;
 	OrigW = 0;
 	OrigH = 0;
 	m_imageXOffset = 0;
Issue#0012527.patch (1,267 bytes)

Issue History

Date Modified Username Field Change
2014-07-15 17:02 FirasH New Issue
2014-07-15 21:03 Kunda Note Added: 0032771
2014-07-15 21:03 Kunda Status new => confirmed
2014-07-15 21:04 Kunda Target Version => 1.5.1
2014-07-15 21:48 cbradney Note Added: 0032773
2015-11-10 06:34 shamsa Note Added: 0037370
2015-11-10 06:34 shamsa Tag Attached: HOST-Oman
2015-11-10 06:37 shamsa File Added: Issue#0012527.patch
2016-01-23 17:16 cbradney Target Version 1.5.1 => 1.5.3
2016-05-25 04:10 Kunda Patch => Yes
2016-12-08 22:04 Kunda Target Version 1.5.3 => 1.5.4