View Issue Details

IDProjectCategoryView StatusLast Update
0012692ScribusGeneralpublic2014-10-21 21:55
ReporterFirasH Assigned Tocbradney  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Target Version1.5.0svnFixed in Version1.5.0svn 
Summary0012692: [PATCH] Palettes are enabled while in Polygon/Arc/Spiral mode
DescriptionPalettes are enabled while in Polygon/Arc/Spiral mode.
Steps To Reproduce0) Create a new document
1) Insert a Polygon/Arc/Spiral
2) Double-click on the Polygon/Arc/Spiral to enable Special edit mode
Most palettes are enabled and can cause a crash (example: Outline and Layers).

I suggest to disable the palettes as when editing nodes.
Additional Information1.5.0.svn (19507)
TagsNo tags attached.
Patch

Relationships

related to 0012666 closedcbradney [TESTED-PATCH] "Edit > Cut/Delete/Deselect All" crashes Scribus if Polygon/Arc/Spiral is in Edit mode 
related to 0012693 closedcbradney Some specific menu entries cause crash while in Polygon/Arc/Spiral mode 
related to 0012741 closedcbradney [TESTED-PATCH] Current page/layer cause crash while in Polygon/Arc/Spiral mode 
related to 0012672 closedFirasH Layers deleting + Table editing might lead to crash 

Activities

FirasH

2014-10-17 16:41

developer  

12692-Patch.diff (3,505 bytes)   
Index: scribus/appmodehelper.cpp
===================================================================
--- scribus/appmodehelper.cpp	(revisione 19588)
+++ scribus/appmodehelper.cpp	(copia locale)
@@ -356,6 +356,9 @@
		(*a_scrActions)["itemSendToPattern"]->setEnabled(false);
		(*a_scrActions)["itemSendToInline"]->setEnabled(false);
	}
+	scmw->enablePalettes(!doc->inAnEditMode());
+	scmw->pageSelector->setEnabled(!doc->inAnEditMode());
+	scmw->layerMenu->setEnabled(!doc->inAnEditMode());
	emit AppModeChanged(oldMode, newMode);
	a_actMgr->connectModeActions();
	PluginManager::instance().enablePluginActionsForSelection(scmw);
@@ -894,6 +897,9 @@
		(*a_scrActions)["itemLock"]->setChecked(currItem->locked());
		(*a_scrActions)["itemLockSize"]->setChecked(currItem->sizeLocked());
		(*a_scrActions)["itemPrintingEnabled"]->setChecked(currItem->printEnabled());
+		scmw->enablePalettes(!inAnEditMode);
+		scmw->pageSelector->setEnabled(!inAnEditMode);
+		scmw->layerMenu->setEnabled(!inAnEditMode);
	}

 }
Index: scribus/scribus.cpp
===================================================================
--- scribus/scribus.cpp	(revisione 19588)
+++ scribus/scribus.cpp	(copia locale)
@@ -5653,6 +5653,22 @@
	view->requestMode(i);
 }

+void ScribusMainWindow::enablePalettes(bool b)
+{
+	if(doc->appMode == modeEdit) //Keep Palettes enabled when editing text
+		return;
+	layerPalette->setEnabled(b);
+	outlinePalette->setEnabled(b);
+	guidePalette->setEnabled(b);
+	scrapbookPalette->setEnabled(b);
+	pagePalette->setEnabled(b);
+	bookmarkPalette->setEnabled(b);
+	docCheckerPalette->setEnabled(b);
+	inlinePalette->setEnabled(b);
+	symbolPalette->setEnabled(b);
+	alignDistributePalette->setEnabled(b);
+}
+
 void ScribusMainWindow::ToggleFrameEdit()
 {
	if (!doc)
@@ -5674,17 +5690,8 @@
	connect(view, SIGNAL(PolyStatus(int, uint)), nodePalette, SLOT(PolyStatus(int, uint)));
	doc->nodeEdit.reset();
	appModeHelper->setFrameEditMode(true);
-	layerPalette->setEnabled(false);
-	outlinePalette->setEnabled(false);
-	guidePalette->setEnabled(false);
-	scrapbookPalette->setEnabled(false);
-	pagePalette->setEnabled(false);
-	bookmarkPalette->setEnabled(false);
-	docCheckerPalette->setEnabled(false);
-	inlinePalette->setEnabled(false);
-	symbolPalette->setEnabled(false);
+	enablePalettes(false);
	styleManager->setEnabled(false);
-	alignDistributePalette->setEnabled(false);
	pageSelector->setEnabled(false);
	layerMenu->setEnabled(false);
	if (!doc->m_Selection->isEmpty())
@@ -5729,17 +5736,8 @@
	scrActions["toolsSelect"]->setChecked(true);
	scrActions["toolsEditContents"]->setChecked(false);
	scrActions["toolsEditWithStoryEditor"]->setChecked(false);
-	layerPalette->setEnabled(true);
-	outlinePalette->setEnabled(true);
-	guidePalette->setEnabled(true);
-	scrapbookPalette->setEnabled(true);
-	pagePalette->setEnabled(true);
-	bookmarkPalette->setEnabled(true);
-	docCheckerPalette->setEnabled(true);
+	enablePalettes(true);
	styleManager->setEnabled(true);
-	alignDistributePalette->setEnabled(true);
-	symbolPalette->setEnabled(true);
-	inlinePalette->setEnabled(true);
	pageSelector->setEnabled(true);
	layerMenu->setEnabled(true);
	if (HaveDoc)
Index: scribus/scribus.h
===================================================================
--- scribus/scribus.h	(revisione 19588)
+++ scribus/scribus.h	(copia locale)
@@ -575,6 +575,7 @@
	void testQT_slot4();
	//void adjustCMS();
	void changePreviewQuality(int index);
+	void enablePalettes(bool b);
	void ToggleFrameEdit();
	void NoFrameEdit();

12692-Patch.diff (3,505 bytes)   

FirasH

2014-10-17 16:45

developer   ~0034037

The patch works as it should, tested.
I hope its not too messy...

FirasH

2014-10-21 21:55

developer   ~0034109

Cannot reproduce in 1.5.0.svn (19604).

Issue History

Date Modified Username Field Change
2014-09-14 13:54 FirasH New Issue
2014-09-14 13:54 FirasH Relationship added related to 0012666
2014-09-14 14:01 FirasH Relationship added related to 0012693
2014-10-02 12:19 FirasH Relationship added related to 0012741
2014-10-04 15:01 FirasH Target Version => 1.5.0svn
2014-10-17 16:28 FirasH File Added: 12692-Patch.diff
2014-10-17 16:30 FirasH File Deleted: 12692-Patch.diff
2014-10-17 16:41 FirasH File Added: 12692-Patch.diff
2014-10-17 16:45 FirasH Note Added: 0034037
2014-10-17 16:45 FirasH Summary Palettes are enabled while in Polygon/Arc/Spiral mode => [PATCH] Palettes are enabled while in Polygon/Arc/Spiral mode
2014-10-18 16:37 FirasH Relationship added related to 0012672
2014-10-21 19:24 cbradney Status new => resolved
2014-10-21 19:24 cbradney Fixed in Version => 1.5.0svn
2014-10-21 19:24 cbradney Resolution open => fixed
2014-10-21 19:24 cbradney Assigned To => cbradney
2014-10-21 21:55 FirasH Note Added: 0034109
2014-10-21 21:55 FirasH Status resolved => closed