View Issue Details

IDProjectCategoryView StatusLast Update
0013905ScribusUser Interfacepublic2016-04-04 16:45
ReporterFirasH Assigned ToFirasH  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.2.svn 
Target Version1.5.2Fixed in Version1.5.2.svn 
Summary0013905: Add missing ellipsis in "Item" menu (where dialogs are opened)
DescriptionAdd missing ellipsis in "Item" menu (where dialogs are opened).
This patch is always aimed at fixing UI inconsistencies.
Additional Information1.5.2.svn (21154)
TagsNo tags attached.
PatchYes

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

FirasH

2016-04-03 10:38

developer  

13905-Patch.diff (610 bytes)

diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1558,7 +1558,7 @@
 	//Item Menu
 	(*scrActions)["itemDuplicate"]->setTexts( tr("D&uplicate"));
 	(*scrActions)["itemMulDuplicate"]->setTexts( tr("&Multiple Duplicate..."));
-	(*scrActions)["itemTransform"]->setTexts( tr("&Transform"));
+	(*scrActions)["itemTransform"]->setTexts( tr("&Transform..."));
 	(*scrActions)["itemDelete"]->setTexts( tr("&Delete"));
 	(*scrActions)["itemGroup"]->setTexts( tr("&Group"));
 	(*scrActions)["itemUngroup"]->setTexts( tr("&Ungroup"));
13905-Patch.diff (610 bytes)

FirasH

2016-04-03 10:54

developer  

13905-PatchV2.diff (1,404 bytes)

diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1558,7 +1558,7 @@
 	//Item Menu
 	(*scrActions)["itemDuplicate"]->setTexts( tr("D&uplicate"));
 	(*scrActions)["itemMulDuplicate"]->setTexts( tr("&Multiple Duplicate..."));
-	(*scrActions)["itemTransform"]->setTexts( tr("&Transform"));
+	(*scrActions)["itemTransform"]->setTexts( tr("&Transform..."));
 	(*scrActions)["itemDelete"]->setTexts( tr("&Delete"));
 	(*scrActions)["itemGroup"]->setTexts( tr("&Group"));
 	(*scrActions)["itemUngroup"]->setTexts( tr("&Ungroup"));
@@ -1600,8 +1600,8 @@
 	(*scrActions)["itemPreviewLow"]->setTexts( tr("&Low Resolution"));
 	(*scrActions)["itemPDFIsBookmark"]->setTexts( tr("Is PDF &Bookmark"));
 	(*scrActions)["itemPDFIsAnnotation"]->setTexts( tr("Is PDF A&nnotation"));
-	(*scrActions)["itemPDFAnnotationProps"]->setTexts( tr("Annotation P&roperties"));
-	(*scrActions)["itemPDFFieldProps"]->setTexts( tr("Field P&roperties"));
+	(*scrActions)["itemPDFAnnotationProps"]->setTexts( tr("Annotation P&roperties..."));
+	(*scrActions)["itemPDFFieldProps"]->setTexts( tr("Field P&roperties..."));
 	(*scrActions)["itemShapeEdit"]->setTexts( tr("&Edit Shape..."));
 	(*scrActions)["itemAttachTextToPath"]->setTexts( tr("&Attach Text to Path"));
 	(*scrActions)["itemDetachTextFromPath"]->setTexts( tr("&Detach Text from Path"));
13905-PatchV2.diff (1,404 bytes)

FirasH

2016-04-03 10:54

developer   ~0039729

Uploaded V2 of the patch which fixes missing ellipsis also for PDF items menu.

FirasH

2016-04-03 15:24

developer  

13905-PatchV3.diff (2,703 bytes)

diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1477,7 +1477,7 @@
 	createDefaultNonMenuNames();
 
 	//File Menu
-	(*scrActions)["fileNew"]->setTexts( tr("&New"));
+	(*scrActions)["fileNew"]->setTexts( tr("&New..."));
 	(*scrActions)["fileNewFromTemplate"]->setTexts( tr("New &from Template..."));
 	(*scrActions)["fileOpen"]->setTexts( tr("&Open..."));
 	(*scrActions)["fileClose"]->setTexts( tr("&Close"));
@@ -1498,7 +1498,7 @@
 //	(*scrActions)["filePreferences"]->setTexts( tr("P&references (old)..."));
 	(*scrActions)["filePreferences150"]->setTexts( tr("P&references..."));
 	(*scrActions)["filePrint"]->setTexts( tr("&Print..."));
-	(*scrActions)["PrintPreview"]->setTexts( tr("Print Previe&w"));
+	(*scrActions)["PrintPreview"]->setTexts( tr("Print Previe&w..."));
 	(*scrActions)["fileQuit"]->setTexts( tr("&Quit"));
 	//Edit Menu
 	(*scrActions)["editUndoAction"]->setTexts( tr("&Undo"));
@@ -1558,7 +1558,7 @@
 	//Item Menu
 	(*scrActions)["itemDuplicate"]->setTexts( tr("D&uplicate"));
 	(*scrActions)["itemMulDuplicate"]->setTexts( tr("&Multiple Duplicate..."));
-	(*scrActions)["itemTransform"]->setTexts( tr("&Transform"));
+	(*scrActions)["itemTransform"]->setTexts( tr("&Transform..."));
 	(*scrActions)["itemDelete"]->setTexts( tr("&Delete"));
 	(*scrActions)["itemGroup"]->setTexts( tr("&Group"));
 	(*scrActions)["itemUngroup"]->setTexts( tr("&Ungroup"));
@@ -1600,8 +1600,8 @@
 	(*scrActions)["itemPreviewLow"]->setTexts( tr("&Low Resolution"));
 	(*scrActions)["itemPDFIsBookmark"]->setTexts( tr("Is PDF &Bookmark"));
 	(*scrActions)["itemPDFIsAnnotation"]->setTexts( tr("Is PDF A&nnotation"));
-	(*scrActions)["itemPDFAnnotationProps"]->setTexts( tr("Annotation P&roperties"));
-	(*scrActions)["itemPDFFieldProps"]->setTexts( tr("Field P&roperties"));
+	(*scrActions)["itemPDFAnnotationProps"]->setTexts( tr("Annotation P&roperties..."));
+	(*scrActions)["itemPDFFieldProps"]->setTexts( tr("Field P&roperties..."));
 	(*scrActions)["itemShapeEdit"]->setTexts( tr("&Edit Shape..."));
 	(*scrActions)["itemAttachTextToPath"]->setTexts( tr("&Attach Text to Path"));
 	(*scrActions)["itemDetachTextFromPath"]->setTexts( tr("&Detach Text from Path"));
@@ -1732,7 +1732,7 @@
 #endif
 
 	//Extras Menu
-	(*scrActions)["extrasManageImages"]->setTexts( tr("&Manage Images"));
+	(*scrActions)["extrasManageImages"]->setTexts( tr("&Manage Images..."));
 	(*scrActions)["extrasHyphenateText"]->setTexts( tr("&Hyphenate Text"));
 	(*scrActions)["extrasDeHyphenateText"]->setTexts( tr("Dehyphenate Text"));
 	(*scrActions)["extrasGenerateTableOfContents"]->setTexts( tr("&Generate Table Of Contents"));
13905-PatchV3.diff (2,703 bytes)

FirasH

2016-04-04 16:45

developer   ~0039785

Thanks jghali!
Committed in 1.5.2.svn (21161).

Issue History

Date Modified Username Field Change
2016-04-03 10:38 FirasH New Issue
2016-04-03 10:38 FirasH File Added: 13905-Patch.diff
2016-04-03 10:43 FirasH Relationship added child of 0013906
2016-04-03 10:54 FirasH File Added: 13905-PatchV2.diff
2016-04-03 10:54 FirasH Note Added: 0039729
2016-04-03 10:56 FirasH Summary Add missing ellipsis in "Transform" menu selection (as it opens a dialog) => Add missing ellipsis in "Item" menu (where dialogs are opened)
2016-04-03 10:56 FirasH Description Updated View Revisions
2016-04-03 15:24 FirasH File Added: 13905-PatchV3.diff
2016-04-03 21:25 Kunda Target Version => 1.5.2
2016-04-04 11:30 jghali Status new => resolved
2016-04-04 11:30 jghali Fixed in Version => 1.5.2.svn
2016-04-04 11:30 jghali Resolution open => fixed
2016-04-04 11:30 jghali Assigned To => FirasH
2016-04-04 16:45 FirasH Note Added: 0039785
2016-04-04 16:45 FirasH Status resolved => closed