View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014212 | Scribus | Undo/Redo | public | 2016-07-11 10:14 | 2026-08-28 06:54 |
| Reporter | mvow | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Platform | Linux | OS | Ubuntu | OS Version | 14.04 LTS |
| Product Version | 1.5.2 | ||||
| Target Version | Future Release - Low Priority | ||||
| Summary | 0014212: Deleting an image with a long path or name, increases the width of the "Edit > Redo" dropdown menu item. | ||||
| Description | (Tested with: Ubuntu 14.04 LTS - Scribus 1.5.2) | ||||
| Steps To Reproduce | 1 - press "I" to switch to the "Image Frame" tool 2 - click and drag over the page to create a new image frame 3 - press "CTRL+I" to insert an image content, and browse for one with a very long path or name 4 - press "CTRL+SHIFT+DEL" to delete the just imported image 5 - try to go to main menu > "Edit" | ||||
| Additional Information | Actual Results: the width of the Edit dropdown menu increases to accomodate the Redo item text. Expected Results: the width of the Edit dropdown menu should remain unchanged. | ||||
| Tags | #easyhack, #please_test | ||||
| Attached Files | |||||
| Patch | No | ||||
|
|
Here is 1-line patch that fixed it for me. #Cause: The clear-image Undo state included the full image path in the action name, so Edit → Undo/Redo expanded to fit very long paths. #Fix: Keep the action name as Clear image frame content and move the image path to the Undo state description. #Rationale: Keeps the menu compact while preserving the path information for Undo history/details. clear-image-undo-menu-width-v1.0.patch (529 bytes)
Index: scribus/pageitem_imageframe.cpp
===================================================================
--- scribus/pageitem_imageframe.cpp (revision 27785)
+++ scribus/pageitem_imageframe.cpp (working copy)
@@ -215,7 +215,7 @@
{
if (UndoManager::undoEnabled())
{
- auto *is = new ScItemState<ScImageEffectList>(Um::ClearImage + "\n" + Pfile, "");
+ auto *is = new ScItemState<ScImageEffectList>(Um::ClearImage, Pfile);
is->set("CLEAR_IMAGE");
is->set("CI_PFILE", Pfile);
is->set("CI_FLIPPH",imageFlippedH());
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-07-11 10:14 | mvow | New Issue | |
| 2016-07-12 07:02 | mvow | File Added: 2016-07-12_Scribus-1.5.2_Edit-Redo_screenshot.jpg | |
| 2016-12-16 20:51 | Kunda | Status | new => confirmed |
| 2016-12-16 20:51 | Kunda | Target Version | => Future Release - Low Priority |
| 2016-12-16 20:51 | Kunda | Tag Attached: #easyhack | |
| 2026-08-28 06:54 | qirat | Note Added: 0054353 | |
| 2026-08-28 06:54 | qirat | File Added: clear-image-content-current.png | |
| 2026-08-28 06:54 | qirat | File Added: clear-image-content-patched.png | |
| 2026-08-28 06:54 | qirat | File Added: clear-image-undo-menu-width-v1.0.patch | |
| 2026-08-28 06:54 | qirat | Tag Attached: #please_test |