|
|
scribus-arabic-spell-bug.png (45,059 bytes) |
|
|
Previously, I ran scribus from an appimage. Now, I compiled from source to see what's happening and help trace it. I found that cmake couldn't find hunspell with message -- Could NOT find HUNSPELL (missing: HUNSPELL_LIBRARIES) Hunspell or its developer libraries NOT found - Disabling support for spell checking Then I checked FindHUNSPELL.cmake and it only search for 1.4 and lower where as my hunspell version is 1.5.4. I am running Arch Linux find_library(HUNSPELL_LIBRARIES NAMES hunspell-1.4 hunspell-1.3 hunspell-1.2 PATHS /opt/local/lib /usr/local/lib /usr/lib ) I tried to add it and recompile, hunspell is found and behaves much better now but still has some issues. Attached is an image which show a correct 2-letter Arabic word and how it behaves. I tested stand-alone hunspell with echo 'من' |hunspell -d ar Hunspell 1.5.4 * scribus-issue-14421.png (95,478 bytes) |
|
|
Thanks @munzirtaha Here the line of code in question: https://github.com/scribusproject/scribus/blob/master/cmake/modules/FindHUNSPELL.cmake#L12 find_library(HUNSPELL_LIBRARIES NAMES hunspell-1.4 hunspell-1.3 hunspell-1.2 PATHS /opt/local/lib /usr/local/lib /usr/lib ) |
|
|
@jghali or @cbradney If it's as easy as adding 'hunspell-1.5' to that line then here is the patch: https://patch-diff.githubusercontent.com/raw/scribusproject/scribus/pull/66.diff |
|
|
Committed |
|
|
Yes, this is exactly what I did but the bug is still valid. The next image I attached is after I patched scribus so it sees hunspell new version. BTW: couldn't you just link to libhunspell.so instead of listing every old, current and future versions of libhunspell? |
|
|
@munzirtaha does you patch differ then the one I offered ? Please attach it then |
|
|
It doesnt matter Kunda, I made that change myself. |
|
|
craig, is there a reason why you're keeping support for for older Hunspell versions? Also > BTW: couldn't you just link to libhunspell.so instead of listing every old, current and future versions of libhunspell? |
|
|
We link to whatever is on the system. That stuff is just cmake code to find the local lib. If someone wants to write a better hunspell finder, they can. For now, this works ok. |
|
|
@fahad can you weigh in on this issue ? |
|
|
@cbradney can we benefit from this: https://cgit.kde.org/lokalize.git/tree/cmake/FindHUNSPELL.cmake " FIND_PATH(HUNSPELL_INCLUDE_DIR hunspell/hunspell.hxx ) FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-2.0 hunspell-1.5 hunspell-1.4.1 hunspell-1.4 hunspell-1.3 hunspell-1.2 hunspell) " |
|
|
My understanding is there is no need for the version numbers. You can just use find_library(HUNSPELL_LIBRARIES NAMES hunspell PATHS /opt/local/lib /usr/local/lib /usr/lib ) After all, libhunspell.so -> libhunspell-1.5.so or whatever version on the system. |
|
|
This bug is about spelling, not about us finding hunspell. @Fahad.. yes, sure, our original file came from KDE based on that link I guess. Again, we just need to understand the spelling issue, not how we are finding hunspell. |
|
|
The good news is this bug is resolved now. Not sure which commit fixed it but I couldn't reproduce it. |
- Anonymous
