View Issue Details

IDProjectCategoryView StatusLast Update
0015108ScribusImport / Exportpublic2018-01-23 23:15
ReporterJLuc Assigned To 
PrioritylowSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformLinuxOSUbuntuOS Version14.04
Product Version1.5.4.svn 
Target VersionFixed in Version 
Summary0015108: No message when trying to save imported PDF
DescriptionAfter importing a PDF file, the title bar displays the name of the file with "(converti)*" as a suffix (with french UI).

Doing CTRL+S should save the current document with some default name or open a file dialog.
But AMOF it does nothing,
and no error message is issued.

This is confusing because silent behaviour is expected to be "Save with same current name whatever it is"
or"Save with default name".

Reporter proposes to
- either issue an error message when realy nothing can be done
- OR better open file dialog and propose to use some default name for saved file name

As for the default proposed name, keeping the "(converti)" suffix would be OK. Or not keeping it also.
TagsNo tags attached.
PatchNo

Activities

ale

2018-01-20 14:32

manager   ~0044861

repetita juvant: scribus should not open pdfs.

it should import them in an existing sla. eventually by automatically adding pages.

then, this bug would not even exist.

jurajF

2018-01-23 22:24

reporter   ~0044866

Currently Save action in File menu (the one activated with CTRL+S) is disabled for all converted documents (loaded non native formats to scribus). That is why scribus is silent when you press CTRL+S. However 'Save As' action is enabled so you can either chose this one from menu or use shortcut CTRL+Shift+S.
I have provided small patch that enables Save action as well, but I strongly advise not to use it. Instead I would close this ticket as 'Will not Fix'. Main reason is there is enabled 'Save As' action that should be used. Second, also very important: patch is small but i do not have idea if it break something in the future or it introduce some unwanted behaviour in other circumstances then I tested the patch. Anyway with patch enabled 'Save' behave exactly same as 'Save As' action.

0001-Enable-saving-converted-document.patch (1,409 bytes)
From 053f9fcca3cf3ca69a165882c20a6d01407276af Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Tue, 23 Jan 2018 22:54:47 +0100
Subject: [PATCH] Enable saving converted document

---
 scribus/appmodehelper.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scribus/appmodehelper.cpp b/scribus/appmodehelper.cpp
index 1bf83a759..67ebf310d 100644
--- a/scribus/appmodehelper.cpp
+++ b/scribus/appmodehelper.cpp
@@ -1362,7 +1362,7 @@ void AppModeHelper::changeLayer(ScribusDoc *doc, bool clipScrapHaveData)
 void AppModeHelper::mainWindowHasNewDoc(ScribusDoc *doc, bool clipScrapHaveData)
 {
 	(*a_scrActions)["filePrint"]->setEnabled(true);
-	(*a_scrActions)["fileSave"]->setEnabled(!doc->isConverted);
+	(*a_scrActions)["fileSave"]->setEnabled(true);
 	(*a_scrActions)["fileClose"]->setEnabled(true);
 	(*a_scrActions)["fileDocSetup150"]->setEnabled(true);
 	(*a_scrActions)["fileRevert"]->setEnabled(false);
@@ -1494,7 +1494,7 @@ void AppModeHelper::mainWindowSwitchWin(ScribusDoc *doc)
 		(*a_scrActions)["fileNewFromTemplate"]->setEnabled(true);
 		(*a_scrActions)["fileOpen"]->setEnabled(true);
 		(*a_scrActions)["fileClose"]->setEnabled(true);
-		(*a_scrActions)["fileSave"]->setEnabled(!doc->isConverted);
+		(*a_scrActions)["fileSave"]->setEnabled(true);
 		(*a_scrActions)["fileRevert"]->setEnabled(false);
 
 		if (!doc->isModified())
-- 
2.15.1

JLuc

2018-01-23 23:15

developer   ~0044869

IMO CTRL+S should never do nothing silently, because it is one of the most widely spread and known standard keyboard shortcut... and is used for saving the document.

Thanks Juraj for providing a patch. "Save" doing the same as "Save as" would be nice here.

In case scribus devs choose to not want "Save" to "Save as", Scribus should at least issue an error message, so as to prevent the user from believing that the current document is saved.

Issue History

Date Modified Username Field Change
2018-01-20 11:00 JLuc New Issue
2018-01-20 11:01 JLuc Description Updated View Revisions
2018-01-20 11:02 JLuc Description Updated View Revisions
2018-01-20 11:21 JLuc Description Updated View Revisions
2018-01-20 11:30 JLuc Description Updated View Revisions
2018-01-20 13:15 jghali Product Version 1.5.4 => 1.5.4.svn
2018-01-20 14:32 ale Note Added: 0044861
2018-01-23 22:24 jurajF File Added: 0001-Enable-saving-converted-document.patch
2018-01-23 22:24 jurajF Note Added: 0044866
2018-01-23 23:15 JLuc Note Added: 0044869