View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015344 | Scribus | - | public | 2018-05-31 13:56 | 2020-04-15 06:40 |
| Reporter | ale | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | assigned | Resolution | fixed | ||
| Fixed in Version | 1.4.9.svn | ||||
| Summary | 0015344: please document what is the legacy variable in pageitem_textframe.cpp | ||||
| Description | https://github.com/scribusproject/scribus/blob/master/scribus/pageitem_textframe.cpp#L383 what does the legacy variable? when can it be removed? can somebody please document it or remove it (+ the dead code) since it's always true... | ||||
| Tags | No tags attached. | ||||
| Patch | No | ||||
|
|
Looks like its gone so resolving |
|
|
ah not its not a class variable. legacy is for the old layout system |
|
|
the biggest issue i have with it,is that legacy is always true!!!!! why is the code always in legacy mode? i would understand a "legacy = false" as a left over... but a "static const legacy = true"? i fear that the non legacy code has never been really tested and that nowadays the rest of the code won't match it and we can safely through away a new thing that has been deprecated before it even got into production... |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-05-31 13:56 | ale | New Issue | |
| 2020-04-14 13:26 | cbradney | Assigned To | => cbradney |
| 2020-04-14 13:26 | cbradney | Status | new => resolved |
| 2020-04-14 13:26 | cbradney | Resolution | open => fixed |
| 2020-04-14 13:26 | cbradney | Fixed in Version | => 1.4.9.svn |
| 2020-04-14 13:26 | cbradney | Note Added: 0047525 | |
| 2020-04-14 13:29 | cbradney | Assigned To | cbradney => |
| 2020-04-14 13:29 | cbradney | Status | resolved => assigned |
| 2020-04-14 13:29 | cbradney | Note Added: 0047526 | |
| 2020-04-15 06:40 | ale | Note Added: 0047527 |
