View Issue Details

IDProjectCategoryView StatusLast Update
0015586ScribusGraphics / Image Framespublic2019-03-05 12:07
Reporterale Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status newResolutionopen 
Product Version1.5.5.svn 
Target VersionFixed in Version 
Summary0015586: use a specific scale type for images that cannot be manual scaled
Descriptioncurrently, the code is "full" of exception for images that are not images (render frame, ...).

instead of checking if an image frame is not a real image, we should add a new state in ScaleType / m_scaleMode.

currently, for those images you can move and rotate the content but not scale it.

personally, i think that no item edit should be possible, but i don't use those type of frames, so i'd like to ear the opinion of those who do...

we can name the state after the feature it enables (or does not enable) or after the type of frame.

of course, this type would not be shown in the image tab of the properties table (as it is now: all options are grayed out in the PP when i select a render frame)
TagsNo tags attached.
PatchNo

Activities

jghali

2019-03-05 11:40

administrator   ~0045960

>> instead of checking if an image frame is not a real image, we should add a new state in ScaleType / m_scaleMode

If you can do so with other pageitem attributes, that means you most likely don't need another state. Adding another state means you will need to handle this new value in all part of the code which use ScaleType / m_scaleMode and also ensure its consistency with the other attributes which were previously used to check for this "state". So basically you will in the end add even more code to keep things working correctly.

ale

2019-03-05 12:07

manager   ~0045961

just fyi, my next patch removes ScaleType and introduces an enum for the scale modes.

i don't have the feeling, that adding a fourth state will then mean more code...

soon, i will be uploading the patch for the "fill mode" and we can then re-discuss this...

Issue History

Date Modified Username Field Change
2019-03-05 07:58 ale New Issue
2019-03-05 11:40 jghali Note Added: 0045960
2019-03-05 12:07 ale Note Added: 0045961