View Issue Details

IDProjectCategoryView StatusLast Update
0015883ScribusGeneralpublic2019-10-31 23:24
Reporterale Assigned Tojghali  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionFixed in Version1.5.6.svn 
Summary0015883: The color picker should suggest the RGB color code as the default name
Descriptionsince the vector importers are creating colors by using the RGB code, i would suggest that the color picker should also use the RGB color as a default value.
TagsNo tags attached.
PatchYes

Activities

PeterBenedek

2019-10-29 09:13

developer   ~0046869

Nice idea!

ale

2019-10-29 09:39

manager   ~0046870

patch is attached

color-dropper.diff (772 bytes)
diff --git a/scribus/canvasmode_eyedropper.cpp b/scribus/canvasmode_eyedropper.cpp
index 9296f0f6f..434b9041e 100644
--- a/scribus/canvasmode_eyedropper.cpp
+++ b/scribus/canvasmode_eyedropper.cpp
@@ -168,7 +168,7 @@ void CanvasMode_EyeDropper::mouseReleaseEvent(QMouseEvent *m)
 		QString questionString="<qt>" + tr("The selected color does not exist in the document's color set. Please enter a name for this new color.") + "</qt>";
 		do
 		{
-			colorName = QInputDialog::getText(m_ScMW, tr("Color Not Found"), questionString, QLineEdit::Normal, QString(), &ok);
+			colorName = QInputDialog::getText(m_ScMW, tr("Color Not Found"), questionString, QLineEdit::Normal, selectedColor.name(), &ok);
 			if (ok)
 			{
 				if (m_doc->PageColors.contains(colorName))
color-dropper.diff (772 bytes)

jghali

2019-10-29 12:39

administrator   ~0046873

I just did a small change : the color name is prefixed with RGB (or its translation)

christoph_s

2019-10-31 23:24

administrator   ~0046893

Tested, fixed. Thanks.

Issue History

Date Modified Username Field Change
2019-10-29 08:18 ale New Issue
2019-10-29 09:09 jghali Category - => General
2019-10-29 09:13 PeterBenedek Note Added: 0046869
2019-10-29 09:39 ale File Added: color-dropper.diff
2019-10-29 09:39 ale Note Added: 0046870
2019-10-29 09:39 ale Summary The color picker should suggest the RGB color code as the default name => [PATCH] The color picker should suggest the RGB color code as the default name
2019-10-29 09:39 ale Patch No => Yes
2019-10-29 12:38 jghali Summary [PATCH] The color picker should suggest the RGB color code as the default name => The color picker should suggest the RGB color code as the default name
2019-10-29 12:39 jghali Assigned To => jghali
2019-10-29 12:39 jghali Status new => resolved
2019-10-29 12:39 jghali Resolution open => fixed
2019-10-29 12:39 jghali Fixed in Version => 1.5.6.svn
2019-10-29 12:39 jghali Note Added: 0046873
2019-10-31 23:24 christoph_s Status resolved => closed
2019-10-31 23:24 christoph_s Note Added: 0046893