View Issue Details

IDProjectCategoryView StatusLast Update
0015915ScribusProperties Palettepublic2023-12-13 06:03
Reporterale Assigned Toale  
PrioritynormalSeverityfeatureReproducibilityN/A
Status assignedResolutionopen 
Product Version1.7.0.svn 
Target Version1.7.0 
Summary0015915: Indigo UI: refactor the Color and Line panels
DescriptionMartin's proposal is to create a Fills panel (most of the current color panel) and a Line one (the line panel plus the stroke color selection).

On top of that I'd suggest:

- Using the XYZ basepoint (it can already indirectly be used... and with the new widget it's "trivia" to only show two or three base points)
- Moving the arrow properties to a new content panel for lines (and beziers)
TagsNo tags attached.
PatchNo

Relationships

related to 0003766 assignednitramr UI improvement proposals to reduce the number of clicks 
parent of 0003752 new move or replace hidden line basepoint setting in properties 
parent of 0012434 closednitramr basepoint: different widgets for shapes and lines 
parent of 0009483 assignedale [PATCH] Ability to choose a basepoint for a line 
parent of 0007287 new Add to ability change basepoint of lines 
parent of 0003751 new additional/clearer basepoint options for lines 
related to 0012439 closedale on canvas basepoint for rotation 
Not all the children of this issue are yet resolved or closed.

Activities

ale

2019-11-05 13:48

manager   ~0046973

one question: what is the use of "basepoint: end points"?

i see that it changes the width and height in x2 and y2...
is it all?

then i would suggest that for lines we replace the width chain button by a new button that switches between the width and x2, y2
the button would show "x2" in the normal state and "w" when checked.

ale

2019-11-05 13:56

manager   ~0046975

0003765 has an interesting proposal for allowing 5 basepoints for lines.

ale

2019-11-06 21:04

manager   ~0047002

martin is defining two widgets for the line panel.

since the arrow heads are moving to the content panel, and the "basepoint" drop down will be a button in the xyz panel, the advanced part shrinks to three buttons that we should integrate in the main panel.

now, one big issue i have in martin's proposal are the labels below and above the fields.

i think that the proposals i've created for the xyz and do well with less labels than martin did plan.

for the lines panel is a bit harder. does anybody want to make suggestions for improved layouts based on the considerations above and the screenshots down here?
indigo-martin-lines.png (6,158 bytes)   
indigo-martin-lines.png (6,158 bytes)   

ale

2019-11-06 21:07

manager   ~0047003

p.s.: martin has forgotten, that when the line type is custom, then a further widget popsup:
custom-type-of-line.png (4,848 bytes)   
custom-type-of-line.png (4,848 bytes)   

ale

2019-11-08 17:57

manager  

cp-lines.png (12,966 bytes)   
cp-lines.png (12,966 bytes)   

ale

2019-11-08 17:57

manager   ~0047035

friday evening... status report:

- the arrow heads are now in the content panel for the lines
- the easy part of the properties panel is done
- two screenshot attached and an appimaged linked: https://gitlab.com/a.l.e/scribus/-/jobs/345940624/artifacts/file/Scribus-nightly-x86_64.AppImage
- the color square shows the current color of the stroke but no pop up for setting the colors is there
- basepoint will go to the xyz panel
- the styles will be a fancy combobox...

one big question: i think that all fields are very clear... only for the shade (the 100%) i wonder if we can find an icon to put in front of it...
pp-lines.png (12,788 bytes)   
pp-lines.png (12,788 bytes)   

nitramr

2023-11-14 20:14

developer   ~0050462

That is my current implementation.

The color selection is still missing in top left corner. I like the idea of moving the base point selection to X,Y,Z panel. It could be a simple QToolButton instead on a QComboBox, because it just has two options.

ale

2023-11-15 06:42

manager   ~0050467

Last edited: 2023-11-15 06:47

nice.

two things from my side:

- do you plan to make the labels below the buttons optional? they look rather useless for my usage, but i guess they can be very useful for somebody starting with DTP.

- the arrows are probably a feature that are not that much used but take lot of space here... we could go with the same solution as in inkscape:
  - call them "Markers" (most of them are technically not arrows ....)
  - show the names when the drop down is open but not when it is closed
  Which would result in:

  
Markers: [    v] [      ]  [   v] [      ]

  (when no marker is selected, just show an empty field instead of None; disable the scale)

  
Markers: [<- v] [100%] [-() v] [100%]

  
  btw, i tend to really like the "in place" dialog with a "real" preview in the button. no idea if it's possible to do the same in qt.
  (at the end we could just have two buttons for the arrows on the first row of the dialog

  
[0.0003 mm] [------ v]  [<- v] [-> v]
     Width      Type       Markers

  )

nitramr

2023-11-20 20:03

developer   ~0050495

Last edited: 2023-11-20 20:05

>> do you plan to make the labels below the buttons optional? they look rather useless for my usage, but i guess they can be very useful for somebody starting with DTP. <<
=> yes

>> the arrows are probably a feature that are not that much used but take lot of space here... we could go with the same solution as in inkscape:<<
=> See attached screenshot. It is a first implementation. I think we should remove M and S size and just keep L, next to the scale input we could have 2x or 4x buttons for a predefined scaling.

Currently, I hide the marker buttons if no line item is selected.

What do you think?
line_markers.png (18,631 bytes)   
line_markers.png (18,631 bytes)   

ale

2023-11-21 11:24

manager   ~0050496

yeah!

not sure about the 2x and 4x buttons.
maybe rather a 1/2 and 2x button that halves / doubles the current value?

but, in my eyes, scribus is not a tool made for drawing arrows.
of course it must support arrows imported from inkscape, should be able to tweak them to the maximum extent and it should be possible to draw an arrow from time to time...
so i would focus on making the essential features easy to reach and not add further buttons for now.

nitramr

2023-11-22 22:51

developer   ~0050502

Ok, next update.

I redesigned the custom dash editor. In case the pattern should repeat correctly, you need an even amount of stops. If not, the dash and gap get inverted. There is a red and green color that indicates this error.
Line base point widget has been moved to XYZ panel.

I think a button to swap the start and end marker could be nice. At least InDesign and Affinity Publisher have such a feature.
error.png (33,095 bytes)   
error.png (33,095 bytes)   
ok.png (33,065 bytes)   
ok.png (33,065 bytes)   

ale

2023-11-23 06:40

manager   ~0050503

since your UI theme is mostly black and white: i would avoid using green for a correctly working line pattern. just set it to gray. (could be lighter than the gray currently in use)

on the other side, i'm fine with the area being red when the pattern is not "sound".
but i wonder if there shouldn't be some explanation of the reasons for the error (a tooltip might be enough).

a slightly different idea:
currently, the active triangle is red.
i wonder if in the new widget the triangle could be gray and black (one color for the active one, the other for the inactive...) and if there is an error, the last stop point gets red (instead of the "right" area)
that might show a bit better where the problem is

finally, since you're working on this widget:
while testing the current widget, i noticed that the cursor also changes to a + when hovering the line but one can only add stop points when the mouse is below the line, where the triangles are.
personally, i'd prefer to be able to add the stop points also on the pattern preview, but if that is not easy / possible, the mouse cursor should only to be set to a + when it's indeed possible to add a stop point.

ale

2023-11-23 06:45

manager   ~0050504

By the way, for the "Type of Line" I would also copy Inkscape and create a Table with two column and the full line and Custom at the top.

Currently, it's almost impossible to discover that "Custom" is even possible.

nitramr

2023-11-25 18:55

developer   ~0050514

>> i wonder if in the new widget the triangle could be gray and black (one color for the active one, the other for the inactive...) and if there is an error, the last stop point gets red (instead of the "right" area) <<
I agree, now the active stop uses the highlight color of the OS and the last stop get a red color if the stop count is not even.

I added a scale to get an idea of the pattern length. The value input only shows the relative distance from the previous stop and not an absolute position.
Also, I fixed an issue I found (at least I suspect it was a problem). The pattern doesn't always fit the width of the widget. It was possible to move stops out of the visible area. To edit or select these stops you had to make the properties window wider. Now everything always fits within the width of the widget and displays the pattern at a relative scale. At the end of the scale there is always a buffer of 1 unit (the gray area) so that you can move the last stop or add a new one.

ale

2023-11-25 19:08

manager   ~0050515

Last edited: 2023-11-25 19:08



looks perfect to me : - )

ale

2023-11-29 07:17

manager   ~0050534

nice summary in the wiki!

one first comment from my side:

i would explore the possibility to move the switch button to the pop up dialog and -- if the matching is possible -- add a button to make the opposite side to use the mirrored marker.

and i would not name the ui preference "professional mode" but "hide informational labels" or "compact view" (or "compact palettes view"; (and then explain in a tooltip what it does)

nitramr

2023-12-02 22:54

developer   ~0050545

The new UI is available for testing in 1.7.0svn r25847

>>i would explore the possibility to move the switch button to the pop up dialog<<
The popup just contains a setting for one line marker. IMO, a switch button is not the right place there. But I like the idea of a mirror button. I didn't check the implementation of such a feature, but I think it requires a change in sla file too to save that.

>>and i would not name the ui preference "professional mode" but "hide informational labels" or "compact view" <<
I renamed it to "Hide Informational Labels".

ale

2023-12-03 08:25

manager   ~0050546

yeah! we're getting close to a PP that is really usable!

really good work!

some comments:

- really, the "professional mode" is a good feature, but it needs a new name! (i think that we should have multiple "professional" feature that can be enabled or disabled...)
- i wonder what would be a good way to compact the list of the line styles
  would it be possible to let the listwidget grow up to a given maximal size (without scrollbars) and when that height is reached make it scrollable? (i google it a bit and it seems to be possible... but not a real future of the listwidget)
- would it be possible to get the panels to expand on a simple click on the label, not only on the double click? (the click on the chevron works well)
- on my screen the arrow heads in the markers popup are really big...
- i like it, that clicking on the markers does not close the dialog and the user can continue working on the the marker. but, then, it's not clear how the popup can be closed. it works but it's not really intuitive. ESC does work and that's good. the ENTER key does work if it gets hit two times: there is margin for improvement : - ). clicking somewhere else also works, which is fine. probably, double clicking on a marker head should also close the popup.
  also, there are good chances that once i have set "this" marker, i want to set the other one too.
  i wonder if at the top of the markers popup there could be a header row / tooblar with a few buttons:
  - a preview of the other marker and an edit button (that would switch to the other marker)
  - make the other marker the same (mirrored) as the current one
  - switch marker with the other end
  - close
  i'm not 100% sure that such a header row is a good idea... it might also be very clunky and confusing. but i think it is worth making some thoughts about it..

voilà.
again thank you for your excellent work!
compact-pp.png (136,510 bytes)   
compact-pp.png (136,510 bytes)   

ale

2023-12-03 08:32

manager   ~0050547

on more thing:

i think that i would remove the Z: (the rotation next to it is not a Z : - ).

and move left the lower part of the panel to the left...

that way the whole palette could get a bit slimmer

it will look really amazing without the item name!
xyz.png (23,181 bytes)   
xyz.png (23,181 bytes)   
xyz-noname.png (22,723 bytes)   
xyz-noname.png (22,723 bytes)   

cbradney

2023-12-03 12:47

administrator   ~0050550

Z is for level

nitramr

2023-12-03 13:12

developer   ~0050551

I will remove the Z label. Maybe that's thinking too far outside the box. From my point of view, you rotate around the Z-axis, so "rotation" is part of the Z-axis.

cbradney

2023-12-03 13:35

administrator   ~0050553

Martin - Level should be here too, so Z should stay

nitramr

2023-12-12 21:11

developer   ~0050592

I put the line styles in a combo box.

ale

2023-12-12 22:33

manager   ~0050593

better than now!
i'm just a bit bothered by the "drop down button" that his higher than normal buttons

@craig: the levels will not disappear from the xyz panel but, in my eyes, the Z label left of the rotation:

- does not make much sense (it's next to the rotation, not to the levels)
- few people will understand that Z is for levels
- if we remove that Z we can move the lines below a bit more to the left and those lines are the longest in the widget.

i'm fine with keeping the name XYZ, even if the Z is not a label in the dialog anymore.

nitramr

2023-12-12 22:43

developer   ~0050594

>>i'm just a bit bothered by the "drop down button" that his higher than normal buttons<<
It is bigger by purpose. I plan to use the drop-down button for other styles too, like character style or paragraph style. Each of the style drop-down could have a rendered preview. If the drop-down would have a normal size, it is not well readable. Right now, it is a first version of an improvement to "save space" in the UI.

ale

2023-12-13 06:03

manager   ~0050596

i'm not bothered because it uses more space, but because if feels different for no reason.
maybe it looks just a bit too similar to a dropdown?

what you explain makes sense and, it's possible (or even likely) that as soon as the same button is used on other context, then the eye sees the purpose and the difference does not stick out anymore.

Issue History

Date Modified Username Field Change
2019-11-05 13:43 ale New Issue
2019-11-05 13:43 ale Status new => assigned
2019-11-05 13:43 ale Assigned To => ale
2019-11-05 13:48 ale Note Added: 0046973
2019-11-05 13:52 ale Relationship added parent of 0003752
2019-11-05 13:53 ale Relationship added parent of 0012434
2019-11-05 13:54 ale Relationship added parent of 0009483
2019-11-05 13:56 ale Note Added: 0046975
2019-11-05 13:56 ale Relationship added parent of 0007287
2019-11-05 13:57 ale Relationship added parent of 0003751
2019-11-05 13:58 ale Relationship added related to 0012439
2019-11-06 21:04 ale File Added: indigo-martin-lines.png
2019-11-06 21:04 ale File Added: indigo-martin-lines-advanced.png
2019-11-06 21:04 ale Note Added: 0047002
2019-11-06 21:07 ale File Added: custom-type-of-line.png
2019-11-06 21:07 ale Note Added: 0047003
2019-11-07 13:35 ale Relationship added related to 0003766
2019-11-08 17:57 ale File Added: cp-lines.png
2019-11-08 17:57 ale File Added: pp-lines.png
2019-11-08 17:57 ale Note Added: 0047035
2023-11-14 20:05 nitramr Product Version 1.5.6.svn => 1.7.0.svn
2023-11-14 20:05 nitramr Target Version => 1.7.0
2023-11-14 20:14 nitramr Note Added: 0050462
2023-11-14 20:14 nitramr File Added: Bildschirmfoto vom 2023-11-13 23-21-01.png
2023-11-15 06:42 ale Note Added: 0050467
2023-11-15 06:45 ale Note Edited: 0050467
2023-11-15 06:45 ale Note Edited: 0050467
2023-11-15 06:46 ale Note Edited: 0050467
2023-11-15 06:46 ale Note Edited: 0050467
2023-11-15 06:47 ale Note Edited: 0050467
2023-11-20 20:03 nitramr Note Added: 0050495
2023-11-20 20:03 nitramr File Added: line_markers.png
2023-11-20 20:05 nitramr Note Edited: 0050495
2023-11-21 11:24 ale Note Added: 0050496
2023-11-22 22:51 nitramr Note Added: 0050502
2023-11-22 22:51 nitramr File Added: error.png
2023-11-22 22:51 nitramr File Added: ok.png
2023-11-23 06:40 ale Note Added: 0050503
2023-11-23 06:45 ale Note Added: 0050504
2023-11-25 18:55 nitramr Note Added: 0050514
2023-11-25 18:55 nitramr File Added: Bildschirmfoto vom 2023-11-25 19-40-24.png
2023-11-25 18:55 nitramr File Added: Bildschirmfoto vom 2023-11-25 19-40-35.png
2023-11-25 19:08 ale Note Added: 0050515
2023-11-25 19:08 ale Note Edited: 0050515
2023-11-29 07:17 ale Note Added: 0050534
2023-12-02 22:54 nitramr Note Added: 0050545
2023-12-03 08:25 ale Note Added: 0050546
2023-12-03 08:25 ale File Added: compact-pp.png
2023-12-03 08:32 ale Note Added: 0050547
2023-12-03 08:32 ale File Added: xyz.png
2023-12-03 08:32 ale File Added: xyz-noname.png
2023-12-03 12:47 cbradney Note Added: 0050550
2023-12-03 13:12 nitramr Note Added: 0050551
2023-12-03 13:35 cbradney Note Added: 0050553
2023-12-12 21:11 nitramr Note Added: 0050592
2023-12-12 21:11 nitramr File Added: Bildschirmfoto vom 2023-12-12 22-06-38.png
2023-12-12 21:11 nitramr File Added: Bildschirmfoto vom 2023-12-12 22-09-23.png
2023-12-12 22:33 ale Note Added: 0050593
2023-12-12 22:43 nitramr Note Added: 0050594
2023-12-13 06:03 ale Note Added: 0050596