View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0015963 | Scribus | General | public | 2019-11-26 14:33 | 2019-11-26 14:37 |
Reporter | ale | Assigned To | ale | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | no change required | ||
Product Version | 1.5.6.svn | ||||
Summary | 0015963: ScImgDataLoader_JPEG::loadPicture(): a loop that seems to do nothing... | ||||
Description | in ScImgDataLoader_JPEG::loadPicture() the snippet below seems to do nothing: https://gitlab.com/scribus/scribus/blob/master/scribus/imagedataloaders/scimgdataloader_jpeg.cpp#L173 if (cinfo.output_components == 4) { QRgb *s; unsigned char cc, cm, cy, ck; for (int yit=0; yit < m_image.height(); ++yit) { s = (QRgb*)(m_image.scanLine( yit )); for (int xit=0; xit < m_image.width(); ++xit) { cc = 255 - qRed(*s); cm = 255 - qGreen(*s); cy = 255 - qBlue(*s); ck = qMin(qMin(cc, cm), cy); *s = qRgba(cc-ck,cm-ck,cy-ck,ck); s++; } } } it sets s, cc, cm, cy, and ck but they're all local variables and they cannot be used outsided of the if context. | ||||
Tags | No tags attached. | ||||
Patch | No | ||||