View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0015986 | Scribus | General | public | 2019-12-03 15:30 | 2019-12-04 07:16 |
Reporter | ale | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | no change required | ||
Product Version | 1.5.6.svn | ||||
Summary | 0015986: if = instead of == | ||||
Description | this popped up in my compile log... it's probably not important, but: really need to get a clean compilation, without any warning to catch such things... | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
canvas-rotate-equal.diff (433 bytes)
diff --git a/scribus/canvasmode_rotate.cpp b/scribus/canvasmode_rotate.cpp index b4e9a1dbd..95cec9dde 100644 --- a/scribus/canvasmode_rotate.cpp +++ b/scribus/canvasmode_rotate.cpp @@ -496,7 +496,7 @@ void CanvasMode_Rotate::keyReleaseEvent(QKeyEvent *e) if (e->modifiers() & Qt::ShiftModifier) increment /= 10; - if (increment = 0.0) + if (increment == 0.0) return; PageItem *currItem; if (GetItem(&currItem)) |
|
Your git code seems out of date. That change was already done is svn in r23388. |
|
well, it's not the git code outdated... but, probably, the local code on my computer... sorry, for the noise... |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-12-03 15:30 | ale | New Issue | |
2019-12-03 15:30 | ale | File Added: canvas-rotate-equal.diff | |
2019-12-04 05:58 | jghali | Assigned To | => jghali |
2019-12-04 05:58 | jghali | Status | new => resolved |
2019-12-04 05:58 | jghali | Resolution | open => no change required |
2019-12-04 05:58 | jghali | Note Added: 0047195 | |
2019-12-04 05:58 | jghali | Summary | [PATCH] if = instead of == => if = instead of == |
2019-12-04 05:59 | jghali | Status | resolved => closed |
2019-12-04 07:16 | ale | Note Added: 0047196 |