View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016352 | Scribus | User Interface | public | 2020-11-25 10:55 | 2021-03-21 15:31 |
| Reporter | bubu | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.7.svn | ||||
| Fixed in Version | 1.5.7.svn | ||||
| Summary | 0016352: Non-transparent scrollreas in preferences dialog | ||||
| Description | I found two other interfaces witch are similar to 0012964. 1) Preferences > Display > Colors = Document Setup > Display > Colors This is a hidden scrollable interface. I made two patches: make it transparent or completely remove the scrollarea. I think there is no need for scrolling. 2) Document Setup > Document Information > Further information This is exactly the same case as was in 0012964, I just didn't find it before. Please, review the patches. Thanks. I checked, there is no more affected scrollareas in Preferences / Document Setup. | ||||
| Tags | No tags attached. | ||||
| Attached Files | colors_panel_scrollarea_transparent.diff (1,856 bytes)
diff --git a/scribus/ui/prefs_display.cpp b/scribus/ui/prefs_display.cpp
index 2961ec1289b8d4eb6c92cd4af65848645da90c80..295196c9ee0a6c9d8af32f2871ddaf781e32217a 100644
--- a/scribus/ui/prefs_display.cpp
+++ b/scribus/ui/prefs_display.cpp
@@ -21,6 +21,9 @@ for which a new license (GPL+exception) is in place.
Prefs_Display::Prefs_Display(QWidget* parent, ScribusDoc* doc) : Prefs_Pane(parent), m_doc(doc)
{
setupUi(this);
+ scrollArea->viewport()->setAutoFillBackground(false);
+ scrollArea->widget()->setAutoFillBackground(false);
+
languageChange();
m_caption = tr("Display");
diff --git a/scribus/ui/prefs_displaybase.ui b/scribus/ui/prefs_displaybase.ui
index 806353475c197ff8058d7b621af94e63b79e6369..222d0904ec54550b53ffd872dcbb1d8e2ad53ce1 100644
--- a/scribus/ui/prefs_displaybase.ui
+++ b/scribus/ui/prefs_displaybase.ui
@@ -360,6 +360,9 @@
<layout class="QVBoxLayout" name="verticalLayout">
<item>
<widget class="QScrollArea" name="scrollArea">
+ <property name="frameShadow">
+ <enum>QFrame::Plain</enum>
+ </property>
<property name="widgetResizable">
<bool>true</bool>
</property>
@@ -376,6 +379,18 @@
<property name="fieldGrowthPolicy">
<enum>QFormLayout::FieldsStayAtSizeHint</enum>
</property>
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item row="0" column="0">
<widget class="QLabel" name="label_15">
<property name="text">
colors_panel_scrollarea_deleted.diff (10,724 bytes)
diff --git a/scribus/ui/prefs_displaybase.ui b/scribus/ui/prefs_displaybase.ui
index 806353475c197ff8058d7b621af94e63b79e6369..4157b6160c48b9d5b42d2f171f803056fa0487ae 100644
--- a/scribus/ui/prefs_displaybase.ui
+++ b/scribus/ui/prefs_displaybase.ui
@@ -359,166 +359,151 @@
</attribute>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
- <widget class="QScrollArea" name="scrollArea">
- <property name="widgetResizable">
- <bool>true</bool>
+ <layout class="QFormLayout" name="formLayout_2">
+ <property name="fieldGrowthPolicy">
+ <enum>QFormLayout::FieldsStayAtSizeHint</enum>
</property>
- <widget class="QWidget" name="scrollAreaWidgetContents">
- <property name="geometry">
- <rect>
- <x>0</x>
- <y>0</y>
- <width>212</width>
- <height>292</height>
- </rect>
- </property>
- <layout class="QFormLayout" name="formLayout_2">
- <property name="fieldGrowthPolicy">
- <enum>QFormLayout::FieldsStayAtSizeHint</enum>
- </property>
- <item row="0" column="0">
- <widget class="QLabel" name="label_15">
- <property name="text">
- <string>Page Fill:</string>
- </property>
- </widget>
- </item>
- <item row="0" column="1">
- <widget class="QPushButton" name="pageFillColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="1" column="0">
- <widget class="QLabel" name="label_2">
- <property name="text">
- <string>Scratch Space:</string>
- </property>
- </widget>
- </item>
- <item row="1" column="1">
- <widget class="QPushButton" name="scratchSpaceColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="2" column="0">
- <widget class="QLabel" name="label_13">
- <property name="text">
- <string>Selected Page Border:</string>
- </property>
- </widget>
- </item>
- <item row="2" column="1">
- <widget class="QPushButton" name="selectedPageBorderButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="3" column="0">
- <widget class="QLabel" name="label_14">
- <property name="text">
- <string>Frames:</string>
- </property>
- </widget>
- </item>
- <item row="3" column="1">
- <widget class="QPushButton" name="frameColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="4" column="0">
- <widget class="QLabel" name="label_16">
- <property name="text">
- <string>Locked Frames:</string>
- </property>
- </widget>
- </item>
- <item row="4" column="1">
- <widget class="QPushButton" name="frameLockedColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="5" column="0">
- <widget class="QLabel" name="label_17">
- <property name="text">
- <string>Selected Frames:</string>
- </property>
- </widget>
- </item>
- <item row="5" column="1">
- <widget class="QPushButton" name="frameSelectedColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="6" column="0">
- <widget class="QLabel" name="label_31">
- <property name="text">
- <string>Linked Frames:</string>
- </property>
- </widget>
- </item>
- <item row="6" column="1">
- <widget class="QPushButton" name="frameLinkedColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="7" column="0">
- <widget class="QLabel" name="label_30">
- <property name="text">
- <string>Grouped Frames:</string>
- </property>
- </widget>
- </item>
- <item row="7" column="1">
- <widget class="QPushButton" name="frameGroupedColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="8" column="0">
- <widget class="QLabel" name="label_29">
- <property name="text">
- <string>Annotation Frames:</string>
- </property>
- </widget>
- </item>
- <item row="8" column="1">
- <widget class="QPushButton" name="frameAnnotationColorButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item row="9" column="0">
- <widget class="QLabel" name="label_32">
- <property name="text">
- <string>Text Control Characters:</string>
- </property>
- </widget>
- </item>
- <item row="9" column="1">
- <widget class="QPushButton" name="textControlCharsButton">
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- </layout>
- </widget>
- </widget>
+ <item row="0" column="0">
+ <widget class="QLabel" name="label_15">
+ <property name="text">
+ <string>Page Fill:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QPushButton" name="pageFillColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="1" column="0">
+ <widget class="QLabel" name="label_2">
+ <property name="text">
+ <string>Scratch Space:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="1" column="1">
+ <widget class="QPushButton" name="scratchSpaceColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="2" column="0">
+ <widget class="QLabel" name="label_13">
+ <property name="text">
+ <string>Selected Page Border:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="2" column="1">
+ <widget class="QPushButton" name="selectedPageBorderButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="3" column="0">
+ <widget class="QLabel" name="label_14">
+ <property name="text">
+ <string>Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="3" column="1">
+ <widget class="QPushButton" name="frameColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="4" column="0">
+ <widget class="QLabel" name="label_16">
+ <property name="text">
+ <string>Locked Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="4" column="1">
+ <widget class="QPushButton" name="frameLockedColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="5" column="0">
+ <widget class="QLabel" name="label_17">
+ <property name="text">
+ <string>Selected Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="5" column="1">
+ <widget class="QPushButton" name="frameSelectedColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="6" column="0">
+ <widget class="QLabel" name="label_31">
+ <property name="text">
+ <string>Linked Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="6" column="1">
+ <widget class="QPushButton" name="frameLinkedColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="7" column="0">
+ <widget class="QLabel" name="label_30">
+ <property name="text">
+ <string>Grouped Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="7" column="1">
+ <widget class="QPushButton" name="frameGroupedColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="8" column="0">
+ <widget class="QLabel" name="label_29">
+ <property name="text">
+ <string>Annotation Frames:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="8" column="1">
+ <widget class="QPushButton" name="frameAnnotationColorButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ <item row="9" column="0">
+ <widget class="QLabel" name="label_32">
+ <property name="text">
+ <string>Text Control Characters:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="9" column="1">
+ <widget class="QPushButton" name="textControlCharsButton">
+ <property name="text">
+ <string/>
+ </property>
+ </widget>
+ </item>
+ </layout>
</item>
</layout>
</widget>
further_information_scrollarea_transparent.diff (1,543 bytes)
diff --git a/scribus/ui/prefs_documentinformation.cpp b/scribus/ui/prefs_documentinformation.cpp
index 3ad889b7c52fe9feb11beddbadcdcff5c57f14bf..029e8128f4fcb4aa0bdd23ceb997477544167a50 100644
--- a/scribus/ui/prefs_documentinformation.cpp
+++ b/scribus/ui/prefs_documentinformation.cpp
@@ -13,6 +13,9 @@ Prefs_DocumentInformation::Prefs_DocumentInformation(QWidget* parent, ScribusDoc
: Prefs_Pane(parent)
{
setupUi(this);
+ scrollArea->viewport()->setAutoFillBackground(false);
+ scrollArea->widget()->setAutoFillBackground(false);
+
languageChange();
m_caption = tr("Document Information");
diff --git a/scribus/ui/prefs_documentinformationbase.ui b/scribus/ui/prefs_documentinformationbase.ui
index f649193268ba73da34ad58a1ca9b4648dd515950..4bb66b78f396120d9c5e2a88152dd9dee4f44ed3 100644
--- a/scribus/ui/prefs_documentinformationbase.ui
+++ b/scribus/ui/prefs_documentinformationbase.ui
@@ -130,6 +130,18 @@
</rect>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item>
<layout class="QFormLayout" name="formLayout_2">
<item row="0" column="0">
| ||||
| Patch | Yes | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-11-25 10:55 | bubu | New Issue | |
| 2020-11-25 10:55 | bubu | File Added: colors_before-after.png | |
| 2020-11-25 10:55 | bubu | File Added: further_information_before-after.png | |
| 2020-11-25 10:55 | bubu | File Added: colors_panel_scrollarea_transparent.diff | |
| 2020-11-25 10:55 | bubu | File Added: colors_panel_scrollarea_deleted.diff | |
| 2020-11-25 10:55 | bubu | File Added: further_information_scrollarea_transparent.diff | |
| 2020-11-26 13:21 | jghali | Summary | Transparent ScrollAreas, 2nd set => Non-transparent scrollreas in preferences dialog |
| 2020-11-26 13:21 | jghali | Assigned To | => jghali |
| 2020-11-26 13:21 | jghali | Status | new => resolved |
| 2020-11-26 13:21 | jghali | Resolution | open => fixed |
| 2020-11-26 13:21 | jghali | Fixed in Version | => 1.5.7.svn |
| 2020-11-26 13:21 | jghali | Note Added: 0048495 | |
| 2021-03-21 15:31 | FirasH | Status | resolved => closed |
| 2021-03-21 15:31 | FirasH | Note Added: 0049036 |