View Issue Details

IDProjectCategoryView StatusLast Update
0016363ScribusUser Interfacepublic2020-11-28 22:39
Reporterbubu Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.7.svn 
Target VersionFixed in Version1.5.7.svn 
Summary0016363: Unify margins in Preferences > Fonts tabs
DescriptionIn Preferences dialog in general tab has standard 9 px margins. But in Preferences > Fonts tabs 2 of them has a 6px and 10px top left margin. (Other 2 has standard 9 px).

This patch removes custom margins. Please review it. Thanks.
TagsNo tags attached.
PatchYes

Activities

bubu

2020-11-28 12:51

reporter  

unify_margins_fonts.diff (1,455 bytes)
diff --git a/scribus/ui/prefs_fontsbase.ui b/scribus/ui/prefs_fontsbase.ui
index 8673da9c176efbef07e91299cbabfa87be3a771f..92446eda53cb1c47ae596c88d2e45763de6ad431 100644
--- a/scribus/ui/prefs_fontsbase.ui
+++ b/scribus/ui/prefs_fontsbase.ui
@@ -45,18 +45,6 @@
        <string>Available Fonts</string>
       </attribute>
       <layout class="QVBoxLayout" name="verticalLayout_2">
-       <property name="leftMargin">
-        <number>10</number>
-       </property>
-       <property name="topMargin">
-        <number>6</number>
-       </property>
-       <property name="rightMargin">
-        <number>10</number>
-       </property>
-       <property name="bottomMargin">
-        <number>10</number>
-       </property>
        <item>
         <widget class="FontListView" name="fontListTableView"/>
        </item>
@@ -67,18 +55,6 @@
        <string>Font Substitutions</string>
       </attribute>
       <layout class="QVBoxLayout" name="verticalLayout_3">
-       <property name="leftMargin">
-        <number>10</number>
-       </property>
-       <property name="topMargin">
-        <number>6</number>
-       </property>
-       <property name="rightMargin">
-        <number>10</number>
-       </property>
-       <property name="bottomMargin">
-        <number>10</number>
-       </property>
        <item>
         <widget class="QTableWidget" name="fontSubstitutionsTableWidget"/>
        </item>
unify_margins_fonts.diff (1,455 bytes)
unify_margins_fonts.gif (209,726 bytes)
unify_margins_fonts.gif (209,726 bytes)

Issue History

Date Modified Username Field Change
2020-11-28 12:51 bubu New Issue
2020-11-28 12:51 bubu File Added: unify_margins_fonts.diff
2020-11-28 12:51 bubu File Added: unify_margins_fonts.gif
2020-11-28 22:39 cbradney Assigned To => cbradney
2020-11-28 22:39 cbradney Status new => resolved
2020-11-28 22:39 cbradney Resolution open => fixed
2020-11-28 22:39 cbradney Fixed in Version => 1.5.7.svn