View Issue Details

IDProjectCategoryView StatusLast Update
0016364ScribusUser Interfacepublic2021-03-21 15:30
Reporterbubu Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016364: Remove empty groupbox label and groupbox from Document Item Attributes in Preferences dialog
DescriptionIn Preferences > Document Item Attributes there is an empty and hidden label on top of the table:

<widget class="QGroupBox" name="attributesGroupBox">
 <property name="title">
  <string/>
 </property>
 <layout class="QVBoxLayout">

This is the cause of the extra top space between the frame and the table.

In this patch is suggest to follow the simplicity of Document Section's layout: no QGroupBox, no QVBoxLayout, no frame around the table, just simple the title label, a line, the table and the buttons.

Please review the patch and commit it if you find it appropriate. Look at the before-after screenshot. The patch seems huge, but its simple removes these lines from the code (other differencees are just spaces):

<widget class="QGroupBox" name="attributesGroupBox">
 <property name="title">
  <string/>
 </property>
 <layout class="QVBoxLayout">
  <item>
   ...
  </item>
 </layout>
</widget>
TagsNo tags attached.
PatchYes

Activities

bubu

2020-11-28 16:55

reporter  

document_item_attributes.diff (5,826 bytes)   
diff --git a/scribus/ui/prefs_documentitemattributesbase.ui b/scribus/ui/prefs_documentitemattributesbase.ui
index fbda0731112d9437459ee970a55a317afd1f1cbc..30afce544389688f13c5f9baa1e3fe31ae339604 100644
--- a/scribus/ui/prefs_documentitemattributesbase.ui
+++ b/scribus/ui/prefs_documentitemattributesbase.ui
@@ -36,113 +36,104 @@
     </widget>
    </item>
    <item>
-    <widget class="QGroupBox" name="attributesGroupBox">
-     <property name="title">
-      <string/>
-     </property>
-     <layout class="QVBoxLayout">
-      <item>
-       <widget class="ScTableWidget" name="attributesTable">
-        <column>
-         <property name="text">
-          <string>Name</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Type</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Value</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Parameter</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Relationship</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Relationship To</string>
-         </property>
-        </column>
-        <column>
-         <property name="text">
-          <string>Auto Add To</string>
-         </property>
-        </column>
-       </widget>
-      </item>
-      <item>
-       <layout class="QHBoxLayout">
-        <item>
-         <spacer>
-          <property name="orientation">
-           <enum>Qt::Horizontal</enum>
-          </property>
-          <property name="sizeType">
-           <enum>QSizePolicy::Expanding</enum>
-          </property>
-          <property name="sizeHint" stdset="0">
-           <size>
-            <width>192</width>
-            <height>21</height>
-           </size>
-          </property>
-         </spacer>
-        </item>
-        <item>
-         <widget class="QPushButton" name="addButton">
-          <property name="text">
-           <string>&amp;Add</string>
-          </property>
-          <property name="shortcut">
-           <string>Alt+A</string>
-          </property>
-         </widget>
-        </item>
-        <item>
-         <widget class="QPushButton" name="copyButton">
-          <property name="text">
-           <string>&amp;Copy</string>
-          </property>
-          <property name="shortcut">
-           <string>Alt+C</string>
-          </property>
-         </widget>
-        </item>
-        <item>
-         <widget class="QPushButton" name="deleteButton">
-          <property name="text">
-           <string>&amp;Delete</string>
-          </property>
-          <property name="shortcut">
-           <string>Alt+D</string>
-          </property>
-         </widget>
-        </item>
-        <item>
-         <widget class="QPushButton" name="clearButton">
-          <property name="text">
-           <string>C&amp;lear</string>
-          </property>
-          <property name="shortcut">
-           <string>Alt+L</string>
-          </property>
-         </widget>
-        </item>
-       </layout>
-      </item>
-     </layout>
+    <widget class="ScTableWidget" name="attributesTable">
+     <column>
+      <property name="text">
+       <string>Name</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Type</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Value</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Parameter</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Relationship</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Relationship To</string>
+      </property>
+     </column>
+     <column>
+      <property name="text">
+       <string>Auto Add To</string>
+      </property>
+     </column>
     </widget>
    </item>
+   <item>
+    <layout class="QHBoxLayout">
+     <item>
+      <spacer>
+       <property name="orientation">
+        <enum>Qt::Horizontal</enum>
+       </property>
+       <property name="sizeType">
+        <enum>QSizePolicy::Expanding</enum>
+       </property>
+       <property name="sizeHint" stdset="0">
+        <size>
+         <width>192</width>
+         <height>21</height>
+        </size>
+       </property>
+      </spacer>
+     </item>
+     <item>
+      <widget class="QPushButton" name="addButton">
+       <property name="text">
+        <string>&amp;Add</string>
+       </property>
+       <property name="shortcut">
+        <string>Alt+A</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QPushButton" name="copyButton">
+       <property name="text">
+        <string>&amp;Copy</string>
+       </property>
+       <property name="shortcut">
+        <string>Alt+C</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QPushButton" name="deleteButton">
+       <property name="text">
+        <string>&amp;Delete</string>
+       </property>
+       <property name="shortcut">
+        <string>Alt+D</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QPushButton" name="clearButton">
+       <property name="text">
+        <string>C&amp;lear</string>
+       </property>
+       <property name="shortcut">
+        <string>Alt+L</string>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </item>
   </layout>
  </widget>
  <customwidgets>
document_item_attributes.diff (5,826 bytes)   
document_item_attributes.png (119,156 bytes)   
document_item_attributes.png (119,156 bytes)   

FirasH

2021-03-21 15:30

developer   ~0049032

Thanks!
Fixed in 1.5.7.svn (24298)

Issue History

Date Modified Username Field Change
2020-11-28 16:55 bubu New Issue
2020-11-28 16:55 bubu File Added: document_item_attributes.diff
2020-11-28 16:55 bubu File Added: document_item_attributes.png
2020-11-28 22:44 cbradney Assigned To => cbradney
2020-11-28 22:44 cbradney Status new => resolved
2020-11-28 22:44 cbradney Resolution open => fixed
2020-11-28 22:44 cbradney Fixed in Version => 1.5.7.svn
2021-03-21 15:30 FirasH Status resolved => closed
2021-03-21 15:30 FirasH Note Added: 0049032