View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016370 | Scribus | User Interface | public | 2020-12-01 10:27 | 2021-04-15 20:37 |
| Reporter | bubu | Assigned To | cbradney | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.7.svn | ||||
| Fixed in Version | 1.5.7.svn | ||||
| Summary | 0016370: [Patch] Rearrange Typography panel in Preferences dialog | ||||
| Description | With 0016367 I finished trivial small improvements in Preferences dialog. This time I try to do something non trivial. It is just an experiment and I need your comments, reaction. I try to avoid scrollable interfaces in Preferences dialog because I think a clear user interface is more usable, user can faster work with it. I choose first time the Typography panel. I tried to rearrange it into two columns. See my proposal below. I did not find any Human Interface Guide for Scribus. Are we following one? Please let me know if yes or your HIG preferences. Can we use two columns? Craig, Jean, please let me know if you are not open for such patches... or the direction is wrong... or quality is poor. I'm not a professional. I never used before Qt Designer. I want to help, but if my patches bother you, I won’t continue :-). | ||||
| Tags | No tags attached. | ||||
| Patch | Yes | ||||
| child of | 0013906 | acknowledged | Metabug: UI enhancement proposals (1.5.x.svn) |
|
|
typography.diff (8,318 bytes)
diff --git a/scribus/ui/prefs_typographybase.ui b/scribus/ui/prefs_typographybase.ui
index 349202078a7bfa5821f562aeffbab5a3c9eedca3..8ebd4a954bb3714bf87a4e8dfa2b97f34af3af70 100644
--- a/scribus/ui/prefs_typographybase.ui
+++ b/scribus/ui/prefs_typographybase.ui
@@ -36,20 +36,9 @@
</widget>
</item>
<item>
- <widget class="QScrollArea" name="scrollArea">
- <property name="widgetResizable">
- <bool>true</bool>
- </property>
- <widget class="QWidget" name="scrollAreaWidgetContents">
- <property name="geometry">
- <rect>
- <x>0</x>
- <y>0</y>
- <width>648</width>
- <height>624</height>
- </rect>
- </property>
- <layout class="QVBoxLayout" name="verticalLayout">
+ <layout class="QHBoxLayout" name="horizontalLayout_4">
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_5">
<item>
<widget class="QLabel" name="label_2">
<property name="font">
@@ -64,7 +53,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_4">
+ <widget class="Line" name="line_3">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -147,7 +136,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_3">
+ <widget class="Line" name="line_2">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -216,6 +205,73 @@
</property>
</spacer>
</item>
+ <item>
+ <widget class="QLabel" name="label_14">
+ <property name="font">
+ <font>
+ <weight>75</weight>
+ <bold>true</bold>
+ </font>
+ </property>
+ <property name="text">
+ <string>Small Caps</string>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <widget class="Line" name="line_5">
+ <property name="orientation">
+ <enum>Qt::Horizontal</enum>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <layout class="QFormLayout" name="formLayout_5">
+ <property name="fieldGrowthPolicy">
+ <enum>QFormLayout::FieldsStayAtSizeHint</enum>
+ </property>
+ <property name="formAlignment">
+ <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
+ </property>
+ <item row="0" column="0">
+ <widget class="QLabel" name="label_15">
+ <property name="text">
+ <string>Scaling:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QSpinBox" name="smallcapsScalingSpinBox">
+ <property name="suffix">
+ <string> %</string>
+ </property>
+ <property name="maximum">
+ <number>100</number>
+ </property>
+ </widget>
+ </item>
+ </layout>
+ </item>
+ </layout>
+ </item>
+ <item>
+ <spacer name="horizontalSpacer">
+ <property name="orientation">
+ <enum>Qt::Horizontal</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>9</width>
+ <height>20</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_3">
<item>
<widget class="QLabel" name="label_4">
<property name="font">
@@ -230,14 +286,14 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_2">
+ <widget class="Line" name="line_1">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
</widget>
</item>
<item>
- <layout class="QFormLayout" name="formLayout">
+ <layout class="QFormLayout" name="formLayout_1">
<property name="fieldGrowthPolicy">
<enum>QFormLayout::FieldsStayAtSizeHint</enum>
</property>
@@ -328,7 +384,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_5">
+ <widget class="Line" name="line_4">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -396,69 +452,6 @@
</item>
</layout>
</item>
- <item>
- <spacer name="verticalSpacer_5">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Fixed</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>20</height>
- </size>
- </property>
- </spacer>
- </item>
- <item>
- <widget class="QLabel" name="label_14">
- <property name="font">
- <font>
- <weight>75</weight>
- <bold>true</bold>
- </font>
- </property>
- <property name="text">
- <string>Small Caps</string>
- </property>
- </widget>
- </item>
- <item>
- <widget class="Line" name="line_6">
- <property name="orientation">
- <enum>Qt::Horizontal</enum>
- </property>
- </widget>
- </item>
- <item>
- <layout class="QFormLayout" name="formLayout_5">
- <property name="fieldGrowthPolicy">
- <enum>QFormLayout::FieldsStayAtSizeHint</enum>
- </property>
- <property name="formAlignment">
- <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
- </property>
- <item row="0" column="0">
- <widget class="QLabel" name="label_15">
- <property name="text">
- <string>Scaling:</string>
- </property>
- </widget>
- </item>
- <item row="0" column="1">
- <widget class="QSpinBox" name="smallcapsScalingSpinBox">
- <property name="suffix">
- <string> %</string>
- </property>
- <property name="maximum">
- <number>100</number>
- </property>
- </widget>
- </item>
- </layout>
- </item>
<item>
<spacer name="verticalSpacer_6">
<property name="orientation">
@@ -489,7 +482,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_7">
+ <widget class="Line" name="line_6">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -525,36 +518,35 @@
</item>
</layout>
</item>
- <item>
- <spacer name="verticalSpacer_3">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>34</height>
- </size>
- </property>
- </spacer>
- </item>
</layout>
- </widget>
- </widget>
+ </item>
+ </layout>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_3">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>34</height>
+ </size>
+ </property>
+ </spacer>
</item>
</layout>
</widget>
<tabstops>
- <tabstop>scrollArea</tabstop>
<tabstop>subscriptDisplacementSpinBox</tabstop>
<tabstop>subscriptScalingSpinBox</tabstop>
<tabstop>superscriptDisplacementSpinBox</tabstop>
<tabstop>superscriptScalingSpinBox</tabstop>
+ <tabstop>smallcapsScalingSpinBox</tabstop>
<tabstop>underlineDisplacementSpinBox</tabstop>
<tabstop>underlineLineWidthSpinBox</tabstop>
<tabstop>strikeoutDisplacementSpinBox</tabstop>
<tabstop>strikeoutLineWidthSpinBox</tabstop>
- <tabstop>smallcapsScalingSpinBox</tabstop>
<tabstop>automaticLineSpacingSpinBox</tabstop>
</tabstops>
<resources/>
|
|
|
I attach a new patch, but there are no visual changes. I ask a review for it. Thanks. 0001-Rearrange-Typography-panel-in-Preferences-dialog.patch (8,732 bytes)
From dc80a91981bfa079efb85be43e65ee5925750cfa Mon Sep 17 00:00:00 2001
Message-Id: <dc80a91981bfa079efb85be43e65ee5925750cfa.1617619823.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Mon, 5 Apr 2021 12:50:14 +0200
Subject: [PATCH] Rearrange Typography panel in Preferences dialog
---
scribus/ui/prefs_typographybase.ui | 192 ++++++++++++++---------------
1 file changed, 92 insertions(+), 100 deletions(-)
diff --git a/scribus/ui/prefs_typographybase.ui b/scribus/ui/prefs_typographybase.ui
index e159150a5..c70509de0 100644
--- a/scribus/ui/prefs_typographybase.ui
+++ b/scribus/ui/prefs_typographybase.ui
@@ -45,20 +45,9 @@
</widget>
</item>
<item>
- <widget class="QScrollArea" name="scrollArea">
- <property name="widgetResizable">
- <bool>true</bool>
- </property>
- <widget class="QWidget" name="scrollAreaWidgetContents">
- <property name="geometry">
- <rect>
- <x>0</x>
- <y>0</y>
- <width>648</width>
- <height>624</height>
- </rect>
- </property>
- <layout class="QVBoxLayout" name="verticalLayout">
+ <layout class="QHBoxLayout" name="horizontalLayout_4">
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_5">
<item>
<widget class="QLabel" name="label_2">
<property name="font">
@@ -73,7 +62,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_4">
+ <widget class="Line" name="line_3">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -156,7 +145,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_3">
+ <widget class="Line" name="line_2">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -225,6 +214,73 @@
</property>
</spacer>
</item>
+ <item>
+ <widget class="QLabel" name="label_14">
+ <property name="font">
+ <font>
+ <weight>75</weight>
+ <bold>true</bold>
+ </font>
+ </property>
+ <property name="text">
+ <string>Small Caps</string>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <widget class="Line" name="line_5">
+ <property name="orientation">
+ <enum>Qt::Horizontal</enum>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <layout class="QFormLayout" name="formLayout_5">
+ <property name="fieldGrowthPolicy">
+ <enum>QFormLayout::FieldsStayAtSizeHint</enum>
+ </property>
+ <property name="formAlignment">
+ <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
+ </property>
+ <item row="0" column="0">
+ <widget class="QLabel" name="label_15">
+ <property name="text">
+ <string>Scaling:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QSpinBox" name="smallcapsScalingSpinBox">
+ <property name="suffix">
+ <string> %</string>
+ </property>
+ <property name="maximum">
+ <number>100</number>
+ </property>
+ </widget>
+ </item>
+ </layout>
+ </item>
+ </layout>
+ </item>
+ <item>
+ <spacer name="horizontalSpacer">
+ <property name="orientation">
+ <enum>Qt::Horizontal</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>9</width>
+ <height>20</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_3">
<item>
<widget class="QLabel" name="label_4">
<property name="font">
@@ -239,14 +295,14 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_2">
+ <widget class="Line" name="line_1">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
</widget>
</item>
<item>
- <layout class="QFormLayout" name="formLayout">
+ <layout class="QFormLayout" name="formLayout_1">
<property name="fieldGrowthPolicy">
<enum>QFormLayout::FieldsStayAtSizeHint</enum>
</property>
@@ -337,7 +393,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_5">
+ <widget class="Line" name="line_4">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -405,69 +461,6 @@
</item>
</layout>
</item>
- <item>
- <spacer name="verticalSpacer_5">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Fixed</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>20</height>
- </size>
- </property>
- </spacer>
- </item>
- <item>
- <widget class="QLabel" name="label_14">
- <property name="font">
- <font>
- <weight>75</weight>
- <bold>true</bold>
- </font>
- </property>
- <property name="text">
- <string>Small Caps</string>
- </property>
- </widget>
- </item>
- <item>
- <widget class="Line" name="line_6">
- <property name="orientation">
- <enum>Qt::Horizontal</enum>
- </property>
- </widget>
- </item>
- <item>
- <layout class="QFormLayout" name="formLayout_5">
- <property name="fieldGrowthPolicy">
- <enum>QFormLayout::FieldsStayAtSizeHint</enum>
- </property>
- <property name="formAlignment">
- <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
- </property>
- <item row="0" column="0">
- <widget class="QLabel" name="label_15">
- <property name="text">
- <string>Scaling:</string>
- </property>
- </widget>
- </item>
- <item row="0" column="1">
- <widget class="QSpinBox" name="smallcapsScalingSpinBox">
- <property name="suffix">
- <string> %</string>
- </property>
- <property name="maximum">
- <number>100</number>
- </property>
- </widget>
- </item>
- </layout>
- </item>
<item>
<spacer name="verticalSpacer_6">
<property name="orientation">
@@ -498,7 +491,7 @@
</widget>
</item>
<item>
- <widget class="Line" name="line_7">
+ <widget class="Line" name="line_6">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
@@ -534,36 +527,35 @@
</item>
</layout>
</item>
- <item>
- <spacer name="verticalSpacer_3">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>34</height>
- </size>
- </property>
- </spacer>
- </item>
</layout>
- </widget>
- </widget>
+ </item>
+ </layout>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_3">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>34</height>
+ </size>
+ </property>
+ </spacer>
</item>
</layout>
</widget>
<tabstops>
- <tabstop>scrollArea</tabstop>
<tabstop>subscriptDisplacementSpinBox</tabstop>
<tabstop>subscriptScalingSpinBox</tabstop>
<tabstop>superscriptDisplacementSpinBox</tabstop>
<tabstop>superscriptScalingSpinBox</tabstop>
+ <tabstop>smallcapsScalingSpinBox</tabstop>
<tabstop>underlineDisplacementSpinBox</tabstop>
<tabstop>underlineLineWidthSpinBox</tabstop>
<tabstop>strikeoutDisplacementSpinBox</tabstop>
<tabstop>strikeoutLineWidthSpinBox</tabstop>
- <tabstop>smallcapsScalingSpinBox</tabstop>
<tabstop>automaticLineSpacingSpinBox</tabstop>
</tabstops>
<resources/>
--
2.27.0
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-12-01 10:27 | bubu | New Issue | |
| 2020-12-01 10:27 | bubu | File Added: typography.diff | |
| 2020-12-01 10:27 | bubu | File Added: typography.png | |
| 2020-12-12 16:51 | PeterBenedek | Relationship added | child of 0013906 |
| 2020-12-14 07:49 | PeterBenedek | Summary | Rearrange Typography panel in Preferences dialog => [Patch] Rearrange Typography panel in Preferences dialog |
| 2021-04-05 10:52 | bubu | Note Added: 0049076 | |
| 2021-04-05 10:52 | bubu | File Added: 0001-Rearrange-Typography-panel-in-Preferences-dialog.patch | |
| 2021-04-05 10:52 | bubu | File Added: typography.gif | |
| 2021-04-07 20:13 | cbradney | Assigned To | => cbradney |
| 2021-04-07 20:13 | cbradney | Status | new => resolved |
| 2021-04-07 20:13 | cbradney | Resolution | open => fixed |
| 2021-04-07 20:13 | cbradney | Fixed in Version | => 1.5.7.svn |
| 2021-04-15 20:37 | cbradney | Status | resolved => closed |
