View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016401 | Scribus | User Interface | public | 2021-01-02 10:57 | 2021-03-21 15:23 |
| Reporter | bubu | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.7.svn | ||||
| Fixed in Version | 1.5.7.svn | ||||
| Summary | 0016401: Update margins for Picture Browser | ||||
| Description | In this patch I propose to use the standard 9px margin and 6px spacing consistently in Picture Browser dialog. It will be a little smaller. I use 9px vertical splitter between folder and file panel (as in Preferences dialog). Please see the before-after screenshot. Please review the patch. Thanks. 2/5 part of 0016383. This patch overwrites that proposal. | ||||
| Tags | No tags attached. | ||||
| Attached Files | picture_browser.diff (4,820 bytes)
diff --git a/scribus/plugins/picbrowser/imagedialog.ui b/scribus/plugins/picbrowser/imagedialog.ui
index 0929d1a05c26982e5e8107151c3f37a146bd0465..2d6c686c83bd9dcf90bbad6355056fbe0ef94ae6 100644
--- a/scribus/plugins/picbrowser/imagedialog.ui
+++ b/scribus/plugins/picbrowser/imagedialog.ui
@@ -16,9 +16,6 @@
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="0" colspan="2">
<layout class="QHBoxLayout">
- <property name="spacing">
- <number>8</number>
- </property>
<item>
<widget class="QRadioButton" name="fitToWindowRadiobutton">
<property name="text">
diff --git a/scribus/plugins/picbrowser/picturebrowser.ui b/scribus/plugins/picbrowser/picturebrowser.ui
index 45e37a84f82c851c15002e58982a9494ec2c9c2e..ffe4b5934549e1500717727618776c78c40db0d5 100644
--- a/scribus/plugins/picbrowser/picturebrowser.ui
+++ b/scribus/plugins/picbrowser/picturebrowser.ui
@@ -14,21 +14,6 @@
<string>Picture Browser</string>
</property>
<layout class="QGridLayout">
- <property name="leftMargin">
- <number>3</number>
- </property>
- <property name="topMargin">
- <number>3</number>
- </property>
- <property name="rightMargin">
- <number>3</number>
- </property>
- <property name="bottomMargin">
- <number>3</number>
- </property>
- <property name="spacing">
- <number>2</number>
- </property>
<item row="0" column="0">
<widget class="QSplitter" name="splitter_2">
<property name="orientation">
@@ -53,6 +38,9 @@
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
+ <property name="handleWidth">
+ <number>9</number>
+ </property>
<widget class="QWidget" name="widget" native="true">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Preferred">
@@ -61,6 +49,18 @@
</sizepolicy>
</property>
<layout class="QVBoxLayout" name="verticalLayout_3">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item>
<widget class="QComboBox" name="navigationBox">
<item>
@@ -87,6 +87,21 @@
</property>
<widget class="QWidget" name="folderpage">
<layout class="QVBoxLayout" name="verticalLayout_2">
+ <property name="spacing">
+ <number>3</number>
+ </property>
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item>
<widget class="QCheckBox" name="subdirsCheckbox">
<property name="text">
@@ -135,6 +150,18 @@
</property>
<widget class="QWidget" name="page_5">
<layout class="QHBoxLayout" name="horizontalLayout_2">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item>
<widget class="QPushButton" name="collectionsNewCategoryButton">
<property name="minimumSize">
@@ -565,6 +592,18 @@
</sizepolicy>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
<item>
<layout class="QHBoxLayout" name="horizontalLayout">
<item>
| ||||
| Patch | No | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-01-02 10:57 | bubu | New Issue | |
| 2021-01-02 10:57 | bubu | File Added: picture_browser.diff | |
| 2021-01-02 10:57 | bubu | File Added: picture_browser.gif | |
| 2021-01-02 11:54 | PeterBenedek | Relationship added | related to 0016383 |
| 2021-01-02 11:54 | PeterBenedek | Relationship added | child of 0013906 |
| 2021-01-02 23:08 | jghali | Assigned To | => jghali |
| 2021-01-02 23:08 | jghali | Status | new => resolved |
| 2021-01-02 23:08 | jghali | Resolution | open => fixed |
| 2021-01-02 23:08 | jghali | Fixed in Version | => 1.5.7.svn |
| 2021-01-02 23:08 | jghali | Note Added: 0048611 | |
| 2021-03-21 15:23 | FirasH | Status | resolved => closed |
| 2021-03-21 15:23 | FirasH | Note Added: 0049018 |