View Issue Details

IDProjectCategoryView StatusLast Update
0016410ScribusUser Interfacepublic2024-12-11 22:02
Reporterchristoph_s Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx86-64OSLinuxOS VersionopenSUSE Tumblew
Product Version1.5.7.svn 
Fixed in Version1.7.0.svn 
Summary0016410: Note in PDF import dialogue is unreadable and probably needs a correction
DescriptionSee the attached screenshot. The tip is incomplete. I also suggest to replace "importing" with "Importing" (uppercase).
TagsNo tags attached.
PatchNo

Activities

christoph_s

2021-01-07 00:55

developer  

PDF_import_157svn_text.png (119,141 bytes)   
PDF_import_157svn_text.png (119,141 bytes)   

JLuc

2021-01-07 08:22

developer   ~0048641

It should be tiped "experimental"

jghali

2021-01-07 17:32

administrator   ~0048648

I've changed the alignment (to top) in the PDF text import mode groupbox so as to leave more space for the note. Not sure what we can do in this case as it seems Qt has given the dialog a too small size.

christoph_s

2021-01-15 01:29

developer   ~0048695

This looks much better now, but I'm not sure that it is the best solution.


Perhaps we should make the note shorter and use the warning sign icon instead of the word "Note"? The text would then be something like: "This option may result in problems with layouts involving text."


There should also be a tooltip for the text import checkbox: "Text import only works reliably in terms of preserving the original layout if the fonts used in a PDF file are either embedded or installed on your computer. Moreover, the import quality depends on the way the PDF file has been created and the version and/or subset of it. You'll probably need to experiment a bit to find out what's the best way to import PDFs with editable text."

luzpaz

2024-11-23 22:36

reporter   ~0051640

Here's how it looks in 1.7.0svn
Screenshot_20241123_173340.png (69,715 bytes)   
Screenshot_20241123_173340.png (69,715 bytes)   

luzpaz

2024-11-25 15:58

reporter   ~0051649

This ticket can be closed IMHO

ale

2024-11-25 20:38

manager   ~0051660

I would suggest that the Note should say (without saying it's a note):

(o) Import text as vectors

"Text will look exactly like in the PDF, but can't be edited (or selected) as text anymore.

(o) Import text as text

"Text will be imported in text frames and will be editable, but it might have different sizes, spacing, and fonts."

- The note could change according to the current selection, or
- The two notes could be placed each below the corresponding option, or
- No note is shown, and the hint goes to a tooltip; one for both or two different tooltips.

What do people prefer?

luzpaz

2024-11-26 19:44

reporter   ~0051662

> I would suggest that the Note should say (without saying it's a note)

+1

> The two notes could be placed each below the corresponding option

+1

ale

2024-11-28 11:04

manager   ~0051679

here is a patch...
pdf-import-labels.diff (6,939 bytes)   
diff --git a/scribus/plugins/import/pdf/pdfimportoptions.ui b/scribus/plugins/import/pdf/pdfimportoptions.ui
index f18744187..1d27fca38 100644
--- a/scribus/plugins/import/pdf/pdfimportoptions.ui
+++ b/scribus/plugins/import/pdf/pdfimportoptions.ui
@@ -7,31 +7,31 @@
     <x>0</x>
     <y>0</y>
     <width>477</width>
-    <height>468</height>
+    <height>563</height>
    </rect>
   </property>
   <property name="windowTitle">
    <string>PDF-Import</string>
   </property>
   <property name="sizeGripEnabled">
-   <bool>true</bool>
-  </property>
-  <layout class="QVBoxLayout" name="verticalLayout_5">
-   <property name="leftMargin">
-    <number>9</number>
-   </property>
-   <property name="topMargin">
-    <number>9</number>
-   </property>
-   <property name="rightMargin">
-    <number>9</number>
-   </property>
-   <property name="bottomMargin">
-    <number>9</number>
-   </property>
-   <item>
-    <layout class="QHBoxLayout" name="horizontalLayout_5">
-     <item>
+   <bool>true</bool>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout_5">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item>
+    <layout class="QHBoxLayout" name="horizontalLayout_5">
+     <item>
       <widget class="QLabel" name="label">
        <property name="sizePolicy">
         <sizepolicy hsizetype="Maximum" vsizetype="Preferred">
@@ -109,12 +109,12 @@
              <string>Choose Pages</string>
             </property>
            </widget>
-          </item>
-          <item>
-           <layout class="QHBoxLayout" name="horizontalLayout">
-            <property name="leftMargin">
-             <number>15</number>
-            </property>
+          </item>
+          <item>
+           <layout class="QHBoxLayout" name="horizontalLayout">
+            <property name="leftMargin">
+             <number>15</number>
+            </property>
             <item>
              <widget class="QLineEdit" name="pageRangeString">
               <property name="enabled">
@@ -184,42 +184,58 @@
          </layout>
         </widget>
        </item>
-       <item alignment="Qt::AlignTop">
+       <item alignment="Qt::AlignmentFlag::AlignTop">
         <widget class="QGroupBox" name="groupBox_2">
          <property name="sizePolicy">
           <sizepolicy hsizetype="Preferred" vsizetype="Maximum">
            <horstretch>0</horstretch>
            <verstretch>0</verstretch>
-          </sizepolicy>
-         </property>
-         <property name="title">
-          <string>Text</string>
-         </property>
-         <layout class="QVBoxLayout" name="verticalLayout_8">
-          <item>
+          </sizepolicy>
+         </property>
+         <property name="title">
+          <string>Text</string>
+         </property>
+         <layout class="QVBoxLayout" name="verticalLayout_8">
+          <item>
            <widget class="QRadioButton" name="textAsVectors">
             <property name="enabled">
              <bool>true</bool>
             </property>
             <property name="text">
-             <string>Import Text As Vectors</string>
+             <string>Import text as vectors</string>
             </property>
             <property name="checked">
              <bool>true</bool>
             </property>
            </widget>
           </item>
+          <item>
+           <widget class="QLabel" name="label_2">
+            <property name="minimumSize">
+             <size>
+              <width>0</width>
+              <height>21</height>
+             </size>
+            </property>
+            <property name="text">
+             <string>Text will look exactly like in the PDF, but can't be edited (or selected) as text anymore.</string>
+            </property>
+            <property name="wordWrap">
+             <bool>true</bool>
+            </property>
+           </widget>
+          </item>
           <item>
            <widget class="QRadioButton" name="textAsText">
             <property name="text">
-             <string>Import Text As Text</string>
+             <string>Import text as text</string>
             </property>
            </widget>
           </item>
           <item>
-           <widget class="QLabel" name="label_2">
+           <widget class="QLabel" name="label_3">
             <property name="text">
-             <string>Note: importing text as text may significantly alter PDF visual aspect</string>
+             <string>Text will be imported in text frames and will be editable, but it might have different sizes, spacing, and fonts.</string>
             </property>
             <property name="wordWrap">
              <bool>true</bool>
@@ -232,7 +248,7 @@
        <item>
         <spacer name="verticalSpacer">
          <property name="orientation">
-          <enum>Qt::Vertical</enum>
+          <enum>Qt::Orientation::Vertical</enum>
          </property>
          <property name="sizeHint" stdset="0">
           <size>
@@ -261,16 +277,16 @@
           </size>
          </property>
          <property name="frameShape">
-          <enum>QFrame::Panel</enum>
+          <enum>QFrame::Shape::Panel</enum>
          </property>
          <property name="frameShadow">
-          <enum>QFrame::Sunken</enum>
+          <enum>QFrame::Shadow::Sunken</enum>
          </property>
          <property name="text">
           <string/>
          </property>
          <property name="alignment">
-          <set>Qt::AlignCenter</set>
+          <set>Qt::AlignmentFlag::AlignCenter</set>
          </property>
         </widget>
        </item>
@@ -279,7 +295,7 @@
          <item>
           <spacer name="horizontalSpacer">
            <property name="orientation">
-            <enum>Qt::Horizontal</enum>
+            <enum>Qt::Orientation::Horizontal</enum>
            </property>
            <property name="sizeHint" stdset="0">
             <size>
@@ -295,7 +311,7 @@
          <item>
           <spacer name="horizontalSpacer_2">
            <property name="orientation">
-            <enum>Qt::Horizontal</enum>
+            <enum>Qt::Orientation::Horizontal</enum>
            </property>
            <property name="sizeHint" stdset="0">
             <size>
@@ -314,10 +330,10 @@
    <item>
     <widget class="QDialogButtonBox" name="buttonBox">
      <property name="orientation">
-      <enum>Qt::Horizontal</enum>
+      <enum>Qt::Orientation::Horizontal</enum>
      </property>
      <property name="standardButtons">
-      <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>
+      <set>QDialogButtonBox::StandardButton::Cancel|QDialogButtonBox::StandardButton::Ok</set>
      </property>
     </widget>
    </item>
pdf-import-labels.diff (6,939 bytes)   
pdf-import-labels.png (32,414 bytes)   
pdf-import-labels.png (32,414 bytes)   

luzpaz

2024-11-28 14:51

reporter   ~0051680

+1

Issue History

Date Modified Username Field Change
2021-01-07 00:55 christoph_s New Issue
2021-01-07 00:55 christoph_s File Added: PDF_import_157svn_text.png
2021-01-07 08:22 JLuc Note Added: 0048641
2021-01-07 17:32 jghali Note Added: 0048648
2021-01-15 01:29 christoph_s Note Added: 0048695
2024-11-23 22:36 luzpaz Note Added: 0051640
2024-11-23 22:36 luzpaz File Added: Screenshot_20241123_173340.png
2024-11-25 15:58 luzpaz Note Added: 0051649
2024-11-25 20:38 ale Note Added: 0051660
2024-11-26 19:44 luzpaz Note Added: 0051662
2024-11-28 11:04 ale Note Added: 0051679
2024-11-28 11:04 ale File Added: pdf-import-labels.diff
2024-11-28 11:04 ale File Added: pdf-import-labels.png
2024-11-28 14:51 luzpaz Note Added: 0051680
2024-12-10 21:21 cbradney Assigned To => cbradney
2024-12-10 21:21 cbradney Status new => resolved
2024-12-10 21:21 cbradney Resolution open => fixed
2024-12-10 21:21 cbradney Fixed in Version => 1.7.0.svn
2024-12-11 22:02 cbradney Status resolved => closed