View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0016415ScribusUser Interfacepublic2021-01-07 21:512021-03-21 15:22
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016415: Fix default dialog margins
DescriptionThis patch corrects my mistake discussed in 0016402:0048621: Qt default window margin is 11px instead of 9px.

I reviewed my all tickets/patches and where a dialog/window's margin wasn't explicitly declared I added them to get real 9px window margin:
0016371: Preferences
0016381: Style Manager
0016387: Insert Frames
0016388: Create Range
0016389: Multiple Duplicate
0016390: Manage Guides
0016400: About Plugins
0016401: Picture Browser

See the attached before-after screenshots. Please review it. Thanks. I am sorry for the mistake.
TagsNo tags attached.
PatchNo

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2021-01-07 21:51

reporter  

fix_default_dialog_margins.diff (7,800 bytes)    
diff --git a/scribus/plugins/picbrowser/imagedialog.ui b/scribus/plugins/picbrowser/imagedialog.ui
index 832b3bf37d0639332ba22f74eb155d5a2f8f3a03..1f412bf526b31c6aba2a49c21d824b8e32f95f89 100644
--- a/scribus/plugins/picbrowser/imagedialog.ui
+++ b/scribus/plugins/picbrowser/imagedialog.ui
@@ -13,12 +13,24 @@
   <property name="windowTitle">
    <string>Dialog</string>
   </property>
-  <layout class="QGridLayout" name="gridLayout">
-   <item row="0" column="0" colspan="2">
-    <layout class="QHBoxLayout">
-     <item>
-      <widget class="QRadioButton" name="fitToWindowRadiobutton">
-       <property name="text">
+  <layout class="QGridLayout" name="gridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item row="0" column="0" colspan="2">
+    <layout class="QHBoxLayout">
+     <item>
+      <widget class="QRadioButton" name="fitToWindowRadiobutton">
+       <property name="text">
         <string>Fit to Window</string>
        </property>
        <property name="checked">
diff --git a/scribus/plugins/picbrowser/picturebrowser.ui b/scribus/plugins/picbrowser/picturebrowser.ui
index 75fd2c5f8f638c80ec476040a0ae917cfc48041a..d640720104a5e12905186753dff74f306c710f1e 100644
--- a/scribus/plugins/picbrowser/picturebrowser.ui
+++ b/scribus/plugins/picbrowser/picturebrowser.ui
@@ -11,12 +11,24 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Picture Browser</string>
-  </property>
-  <layout class="QGridLayout">
-   <item row="0" column="0">
-    <widget class="QSplitter" name="splitter_2">
-     <property name="orientation">
+   <string>Picture Browser</string>
+  </property>
+  <layout class="QGridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item row="0" column="0">
+    <widget class="QSplitter" name="splitter_2">
+     <property name="orientation">
       <enum>Qt::Vertical</enum>
      </property>
      <widget class="QWidget" name="widget_3" native="true">
diff --git a/scribus/ui/aboutplugins.ui b/scribus/ui/aboutplugins.ui
index 6cb1ef4123c24930ef49cfdf4eb000591330082f..544a129c45807227507222a209016a580afd519d 100644
--- a/scribus/ui/aboutplugins.ui
+++ b/scribus/ui/aboutplugins.ui
@@ -13,6 +13,18 @@
    <string>Scribus: About Plug-ins</string>
   </property>
   <layout class="QVBoxLayout" >
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <widget class="QSplitter" name="splitter" >
      <property name="orientation" >
diff --git a/scribus/ui/createrange.ui b/scribus/ui/createrange.ui
index ce0583279fa3699884aadd1430925bc6810d827f..6f30f759400c4337517dc60769b759a5a476c5d4 100644
--- a/scribus/ui/createrange.ui
+++ b/scribus/ui/createrange.ui
@@ -14,6 +14,18 @@
    <string>Create Range</string>
   </property>
   <layout class="QGridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item row="0" column="0">
     <layout class="QHBoxLayout">
      <item>
diff --git a/scribus/ui/guidemanager.ui b/scribus/ui/guidemanager.ui
index f0ed65f4dcaad7a3ab6c36e6e482f5f0d21c022e..6aefa9f45bcbc9a424a85be13f0ee23c9fdea291 100644
--- a/scribus/ui/guidemanager.ui
+++ b/scribus/ui/guidemanager.ui
@@ -16,6 +16,18 @@
    <string>Guide Manager</string>
   </property>
   <layout class="QGridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item row="0" column="0">
     <widget class="QTabWidget" name="tabWidget">
      <property name="currentIndex">
diff --git a/scribus/ui/insertaframe.ui b/scribus/ui/insertaframe.ui
index 9dfab66bb56e36baff05251536da3e1142d3db3a..11ad3191f2efcd1e54876ad75a56430b4b9325f0 100644
--- a/scribus/ui/insertaframe.ui
+++ b/scribus/ui/insertaframe.ui
@@ -14,6 +14,18 @@
    <string>Insert Frames</string>
   </property>
   <layout class="QVBoxLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <widget class="QTabWidget" name="tabWidget">
      <property name="currentIndex">
diff --git a/scribus/ui/multipleduplicate.ui b/scribus/ui/multipleduplicate.ui
index fea6ba66bacae26cd7646bab1d09adf2bb8d51cc..fce61038f6fa6ec4deb7a44b56d53943590cd40e 100644
--- a/scribus/ui/multipleduplicate.ui
+++ b/scribus/ui/multipleduplicate.ui
@@ -26,12 +26,21 @@
    <bool>false</bool>
   </property>
   <layout class="QVBoxLayout">
-   <property name="spacing">
-    <number>7</number>
-   </property>
    <property name="sizeConstraint">
     <enum>QLayout::SetMinimumSize</enum>
    </property>
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <widget class="QTabWidget" name="tabWidget">
      <property name="sizePolicy">
diff --git a/scribus/ui/preferencesdialogbase.ui b/scribus/ui/preferencesdialogbase.ui
index 166665ff9ce48597e83b2a3756b9c73ccd95c980..c33b3668faef21f70722d0874c56f0ccab074ea6 100644
--- a/scribus/ui/preferencesdialogbase.ui
+++ b/scribus/ui/preferencesdialogbase.ui
@@ -14,6 +14,18 @@
    <string>Preferences</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <layout class="QHBoxLayout" name="frameHorizontalLayout">
      <property name="spacing">
diff --git a/scribus/ui/stylemanager.ui b/scribus/ui/stylemanager.ui
index df02987742b66e464e1ff5c426ba67ec7cd12c9d..1ad16b74f412cc3d3ed2b34680bfc6334f7dcc37 100644
--- a/scribus/ui/stylemanager.ui
+++ b/scribus/ui/stylemanager.ui
@@ -23,6 +23,18 @@
    <string>Style Manager</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <layout class="QHBoxLayout" name="horizontalLayout">
      <property name="spacing">
fix_default_dialog_margins.diff (7,800 bytes)   
about_plugins.gif (75,011 bytes)   
about_plugins.gif (75,011 bytes)   
create_range.gif (43,716 bytes)   
create_range.gif (43,716 bytes)   
insert_frames.gif (48,231 bytes)   
insert_frames.gif (48,231 bytes)   
manage_guides.gif (29,599 bytes)   
manage_guides.gif (29,599 bytes)   
multiple_duplicate.gif (31,088 bytes)   
multiple_duplicate.gif (31,088 bytes)   
picture_browser.gif (60,524 bytes)   
picture_browser.gif (60,524 bytes)   
preferences.gif (97,199 bytes)   
preferences.gif (97,199 bytes)   
style_manager.gif (129,189 bytes)   
style_manager.gif (129,189 bytes)   

jghali

2021-01-08 17:14

administrator   ~0048654

Applied, thanks!

FirasH

2021-03-21 15:22

reporter   ~0049014

Thanks!
Fixed in 1.5.7.svn (24386)

Issue History

Date Modified Username Field Change
2021-01-07 21:51 bubu New Issue
2021-01-07 21:51 bubu File Added: fix_default_dialog_margins.diff
2021-01-07 21:51 bubu File Added: about_plugins.gif
2021-01-07 21:51 bubu File Added: create_range.gif
2021-01-07 21:51 bubu File Added: insert_frames.gif
2021-01-07 21:51 bubu File Added: manage_guides.gif
2021-01-07 21:51 bubu File Added: multiple_duplicate.gif
2021-01-07 21:51 bubu File Added: picture_browser.gif
2021-01-07 21:51 bubu File Added: preferences.gif
2021-01-07 21:51 bubu File Added: style_manager.gif
2021-01-08 17:14 jghali Assigned To => jghali
2021-01-08 17:14 jghali Status new => resolved
2021-01-08 17:14 jghali Resolution open => fixed
2021-01-08 17:14 jghali Fixed in Version => 1.5.7.svn
2021-01-08 17:14 jghali Note Added: 0048654
2021-01-08 18:05 PeterBenedek Relationship added child of 0013906
2021-03-21 15:22 FirasH Status resolved => closed
2021-03-21 15:22 FirasH Note Added: 0049014