View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0016467ScribusUser Interfacepublic2021-02-09 22:572021-03-21 15:08
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016467: Unify margins and spacing for dialogs, set 6
DescriptionI propose a new set of trivial margin/spacing adjustment for dialogs.

In this set there are only window margins.
In marknote.ui there is a small layout fix too. Please se the screenshot.

Please review. Thanks.


TagsNo tags attached.
PatchNo

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2021-02-09 22:57

reporter  

0001-Unify-margins-and-spacing-for-dialogs-set-6.patch (5,375 bytes)    
From ff408bf210c6021e0e98eea5fc3c02ddee030882 Mon Sep 17 00:00:00 2001
Message-Id: <ff408bf210c6021e0e98eea5fc3c02ddee030882.1612911166.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Tue, 9 Feb 2021 23:52:34 +0100
Subject: [PATCH] Unify margins and spacing for dialogs, set 6

---
 scribus/ui/mark2item.ui        | 12 ++++++++++++
 scribus/ui/mark2mark.ui        | 12 ++++++++++++
 scribus/ui/markanchor.ui       | 12 ++++++++++++
 scribus/ui/marknote.ui         | 20 +++++++++++++-------
 scribus/ui/markvariabletext.ui | 12 ++++++++++++
 scribus/ui/weldeditbase.ui     | 12 ++++++++++++
 6 files changed, 73 insertions(+), 7 deletions(-)

diff --git a/scribus/ui/mark2item.ui b/scribus/ui/mark2item.ui
index 0a7aea32f..a9155c7ab 100644
--- a/scribus/ui/mark2item.ui
+++ b/scribus/ui/mark2item.ui
@@ -26,6 +26,18 @@
    <string>Dialog</string>
   </property>
   <layout class="QGridLayout" name="gridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item row="0" column="0">
     <layout class="QFormLayout" name="formLayout">
      <property name="fieldGrowthPolicy">
diff --git a/scribus/ui/mark2mark.ui b/scribus/ui/mark2mark.ui
index 9b7d0693c..3b8c74fd6 100644
--- a/scribus/ui/mark2mark.ui
+++ b/scribus/ui/mark2mark.ui
@@ -32,6 +32,18 @@
    <string>Dialog</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <widget class="QSplitter" name="splitter">
      <property name="orientation">
diff --git a/scribus/ui/markanchor.ui b/scribus/ui/markanchor.ui
index f152fcd42..ba111f4d2 100644
--- a/scribus/ui/markanchor.ui
+++ b/scribus/ui/markanchor.ui
@@ -32,6 +32,18 @@
    <string>Dialog</string>
   </property>
   <layout class="QGridLayout" name="gridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item row="0" column="0">
     <widget class="QLabel" name="label">
      <property name="text">
diff --git a/scribus/ui/marknote.ui b/scribus/ui/marknote.ui
index 1098160ed..60d4a0184 100644
--- a/scribus/ui/marknote.ui
+++ b/scribus/ui/marknote.ui
@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>358</width>
-    <height>80</height>
+    <height>76</height>
    </rect>
   </property>
   <property name="sizePolicy">
@@ -26,6 +26,18 @@
    <string>Dialog</string>
   </property>
   <layout class="QGridLayout" name="gridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item row="0" column="0">
     <layout class="QFormLayout" name="formLayout">
      <property name="fieldGrowthPolicy">
@@ -55,12 +67,6 @@
      </item>
      <item row="0" column="0">
       <widget class="QLabel" name="label_2">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="Preferred" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
        <property name="text">
         <string>Notes Style:</string>
        </property>
diff --git a/scribus/ui/markvariabletext.ui b/scribus/ui/markvariabletext.ui
index b21b0a4a0..4b00cc7de 100644
--- a/scribus/ui/markvariabletext.ui
+++ b/scribus/ui/markvariabletext.ui
@@ -32,6 +32,18 @@
    <string>Add new Mark for Variable Text</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <layout class="QHBoxLayout" name="labelLayout">
      <item>
diff --git a/scribus/ui/weldeditbase.ui b/scribus/ui/weldeditbase.ui
index 3c6e47e6e..346568a0d 100644
--- a/scribus/ui/weldeditbase.ui
+++ b/scribus/ui/weldeditbase.ui
@@ -14,6 +14,18 @@
    <string>Edit Weld</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
    <item>
     <widget class="QRadioButton" name="moveWeldPoint">
      <property name="text">
-- 
2.27.0
0001-Unify-margins-and-spacing-for-dialogs-set-6.patch (5,375 bytes)   
mark2item.gif (12,226 bytes)   
mark2item.gif (12,226 bytes)   
mark2mark.gif (12,124 bytes)   
mark2mark.gif (12,124 bytes)   
markanchor.gif (9,917 bytes)   
markanchor.gif (9,917 bytes)   
marknote.gif (11,834 bytes)   
marknote.gif (11,834 bytes)   
markvariabletext.gif (14,018 bytes)   
markvariabletext.gif (14,018 bytes)   
weldedit.gif (9,101 bytes)   
weldedit.gif (9,101 bytes)   

jghali

2021-02-10 17:42

administrator   ~0048819

Applied, thanks!

FirasH

2021-03-21 15:08

reporter   ~0048995

Thanks!
Fixed in 1.5.7.svn (24463)

Issue History

Date Modified Username Field Change
2021-02-09 22:57 bubu New Issue
2021-02-09 22:57 bubu File Added: 0001-Unify-margins-and-spacing-for-dialogs-set-6.patch
2021-02-09 22:57 bubu File Added: mark2item.gif
2021-02-09 22:57 bubu File Added: mark2mark.gif
2021-02-09 22:57 bubu File Added: markanchor.gif
2021-02-09 22:57 bubu File Added: marknote.gif
2021-02-09 22:57 bubu File Added: markvariabletext.gif
2021-02-09 22:57 bubu File Added: weldedit.gif
2021-02-10 05:30 PeterBenedek Relationship added child of 0013906
2021-02-10 17:42 jghali Assigned To => jghali
2021-02-10 17:42 jghali Status new => resolved
2021-02-10 17:42 jghali Resolution open => fixed
2021-02-10 17:42 jghali Fixed in Version => 1.5.7.svn
2021-02-10 17:42 jghali Note Added: 0048819
2021-03-21 15:08 FirasH Status resolved => closed
2021-03-21 15:08 FirasH Note Added: 0048995