View Issue Details

IDProjectCategoryView StatusLast Update
0016483ScribusInternalpublic2021-02-22 21:55
Reporterbubu Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version1.5.7.svn 
Target VersionFixed in Version 
Summary0016483: Clean up xtgdialog
DescriptionI guess that /scribus/plugins/gettext/xtgim/xtgdialog.cpp is out of use. I propose to remove it.
TagsNo tags attached.
PatchNo

Activities

jghali

2021-02-22 20:28

administrator   ~0048870

Not sure if xtgdialog is unfinished code or code which was used at one point of time and is now unused.

bubu

2021-02-22 21:55

reporter   ~0048872

Jean, if you decide to keep it, then please commit the attached patch.

0001-Unify-margins-a-spacing-for-XTG-dialog.patch (2,252 bytes)
From d7c6a50d26ee0e4205bbe8799e8f476cb6c0ac29 Mon Sep 17 00:00:00 2001
Message-Id: <d7c6a50d26ee0e4205bbe8799e8f476cb6c0ac29.1614030540.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Mon, 22 Feb 2021 22:48:33 +0100
Subject: [PATCH] Unify margins a spacing for XTG dialog

---
 scribus/plugins/gettext/xtgim/xtgdialog.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/scribus/plugins/gettext/xtgim/xtgdialog.cpp b/scribus/plugins/gettext/xtgim/xtgdialog.cpp
index 47dd22f4a..8dcad4707 100755
--- a/scribus/plugins/gettext/xtgim/xtgdialog.cpp
+++ b/scribus/plugins/gettext/xtgim/xtgdialog.cpp
@@ -44,12 +44,12 @@ XtgDialog::XtgDialog(bool prefix) : QDialog(0)
 	setWindowTitle( tr("Quark XPress Tags Importer Options"));
 
 	QBoxLayout* layout = new QVBoxLayout(this);
-	layout->setMargin(0);
-	layout->setSpacing(0);
+	layout->setContentsMargins(9, 9, 9, 9);
+	layout->setSpacing(6);
 
 	QBoxLayout* playout = new QHBoxLayout;
-	playout->setMargin(5);
-	playout->setSpacing(5);
+	playout->setContentsMargins(0, 0, 0, 0);
+	playout->setSpacing(6);
 	prefixCheck = new QCheckBox( tr("Use document name as a prefix for Styles"), this);
 	prefixCheck->setChecked(prefix);
 	prefixCheck->setToolTip( "<qt>" + tr("Prepend the document name to the Style name in Scribus") +"</qt>");
@@ -57,8 +57,8 @@ XtgDialog::XtgDialog(bool prefix) : QDialog(0)
 	layout->addLayout(playout);
 
 	QBoxLayout* dlayout = new QHBoxLayout;
-	dlayout->setMargin(5);
-	dlayout->setSpacing(5);
+	dlayout->setContentsMargins(0, 0, 0, 0);
+	dlayout->setSpacing(6);
 	doNotAskCheck = new QCheckBox( tr("Do not ask again"), this);
 	doNotAskCheck->setChecked(false);
 	doNotAskCheck->setToolTip( "<qt>" + tr("Make these settings the default and do not prompt again when importing an XPress Tags document") +"</qt>");
@@ -67,8 +67,8 @@ XtgDialog::XtgDialog(bool prefix) : QDialog(0)
 	layout->addLayout(dlayout);
 
 	QBoxLayout* blayout = new QHBoxLayout;
-	blayout->setMargin(5);
-	blayout->setSpacing(5);
+	blayout->setContentsMargins(0, 0, 0, 0);
+	blayout->setSpacing(6);
 	blayout->addStretch(10);
 	okButton = new QPushButton( tr("OK"), this);
 	blayout->addWidget(okButton);
-- 
2.27.0

Issue History

Date Modified Username Field Change
2021-02-19 21:48 bubu New Issue
2021-02-20 18:13 jghali Category General => Internal
2021-02-22 20:28 jghali Note Added: 0048870
2021-02-22 21:55 bubu File Added: 0001-Unify-margins-a-spacing-for-XTG-dialog.patch
2021-02-22 21:55 bubu Note Added: 0048872