View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0016504ScribusUser Interfacepublic2021-03-02 19:182021-03-21 14:54
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016504: Shrink minimal width for Line tab in Propeties Palette
DescriptionI propose a patch to shrink properties palette. Currently the most wide tab is Line. The layout is currently on 4 column grid and the critical row is "Scaling". I propose to insert two vertical layout to row "Scaling", and shrink main grid to 2 column.

Please see the attached screenshot. Please review the patch. Thanks.
TagsNo tags attached.
PatchNo

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2021-03-02 19:18

reporter  

0001-Shrink-minimal-width-for-Line-tab-in-Propeties-Palet.patch (8,140 bytes)    
From 2a549f1703ca90b91a0b8f80a834f8fcd386f115 Mon Sep 17 00:00:00 2001
Message-Id: <2a549f1703ca90b91a0b8f80a834f8fcd386f115.1614712034.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Tue, 2 Mar 2021 20:06:55 +0100
Subject: [PATCH] Shrink minimal width for Line tab in Propeties Palette

---
 scribus/ui/propertiespalette_linebase.ui | 174 +++++++++++++----------
 1 file changed, 100 insertions(+), 74 deletions(-)

diff --git a/scribus/ui/propertiespalette_linebase.ui b/scribus/ui/propertiespalette_linebase.ui
index 84b16bbec..c3e895c0e 100644
--- a/scribus/ui/propertiespalette_linebase.ui
+++ b/scribus/ui/propertiespalette_linebase.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>340</width>
+    <width>265</width>
     <height>421</height>
    </rect>
   </property>
@@ -29,27 +29,33 @@
    <property name="spacing">
     <number>3</number>
    </property>
-   <item row="0" column="0" colspan="2">
-    <widget class="QLabel" name="lineModeLabel">
+   <item row="1" column="0">
+    <widget class="QLabel" name="lineTypeLabel">
      <property name="text">
-      <string>&amp;Basepoint:</string>
+      <string>T&amp;ype of Line:</string>
      </property>
     </widget>
    </item>
-   <item row="0" column="2" colspan="2">
-    <widget class="QComboBox" name="lineMode"/>
-   </item>
-   <item row="1" column="0" colspan="2">
-    <widget class="QLabel" name="lineTypeLabel">
+   <item row="7" column="0">
+    <widget class="QLabel" name="lineWidthLabel">
      <property name="text">
-      <string>T&amp;ype of Line:</string>
+      <string>Line &amp;Width:</string>
      </property>
     </widget>
    </item>
-   <item row="1" column="2" colspan="2">
-    <widget class="LineCombo" name="lineType"/>
+   <item row="9" column="1">
+    <widget class="QComboBox" name="lineEndStyle"/>
+   </item>
+   <item row="8" column="1">
+    <widget class="QComboBox" name="lineJoinStyle"/>
    </item>
-   <item row="2" column="0" colspan="4">
+   <item row="10" column="0" colspan="2">
+    <widget class="QListWidget" name="lineStyles"/>
+   </item>
+   <item row="4" column="1">
+    <widget class="ArrowChooser" name="endArrow"/>
+   </item>
+   <item row="2" column="0" colspan="2">
     <widget class="DashEditor" name="dashEditor">
      <property name="frameShape">
       <enum>QFrame::StyledPanel</enum>
@@ -59,100 +65,120 @@
      </property>
     </widget>
    </item>
-   <item row="3" column="0">
-    <widget class="QLabel" name="startArrowLabel">
-     <property name="text">
-      <string>Start Arrow:</string>
+   <item row="7" column="1">
+    <widget class="ScrSpinBox" name="lineWidth">
+     <property name="specialValueText">
+      <string>Hairline</string>
      </property>
-    </widget>
-   </item>
-   <item row="3" column="2">
-    <widget class="QLabel" name="endArrowLabel">
-     <property name="text">
-      <string>End Arrow:</string>
+     <property name="maximum">
+      <double>300.000000000000000</double>
      </property>
     </widget>
    </item>
-   <item row="4" column="0" colspan="2">
+   <item row="4" column="0">
     <widget class="ArrowChooser" name="startArrow"/>
    </item>
-   <item row="4" column="2" colspan="2">
-    <widget class="ArrowChooser" name="endArrow"/>
+   <item row="1" column="1">
+    <widget class="LineCombo" name="lineType"/>
    </item>
-   <item row="5" column="0">
-    <widget class="QLabel" name="startArrowScaleLabel">
+   <item row="0" column="1">
+    <widget class="QComboBox" name="lineMode"/>
+   </item>
+   <item row="0" column="0">
+    <widget class="QLabel" name="lineModeLabel">
      <property name="text">
-      <string>Scaling:</string>
+      <string>&amp;Basepoint:</string>
      </property>
     </widget>
    </item>
+   <item row="5" column="0">
+    <layout class="QHBoxLayout" name="horizontalLayout">
+     <property name="spacing">
+      <number>3</number>
+     </property>
+     <item>
+      <widget class="QLabel" name="startArrowScaleLabel">
+       <property name="text">
+        <string>Scaling:</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="ScrSpinBox" name="startArrowScale">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="minimum">
+        <double>1.000000000000000</double>
+       </property>
+       <property name="maximum">
+        <double>300.000000000000000</double>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </item>
    <item row="5" column="1">
-    <widget class="ScrSpinBox" name="startArrowScale">
-     <property name="minimum">
-      <double>1.000000000000000</double>
-     </property>
-     <property name="maximum">
-      <double>300.000000000000000</double>
-     </property>
-    </widget>
+    <layout class="QHBoxLayout" name="horizontalLayout_2">
+     <property name="spacing">
+      <number>3</number>
+     </property>
+     <item>
+      <widget class="QLabel" name="endArrowScaleLabel">
+       <property name="text">
+        <string>Scaling:</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="ScrSpinBox" name="endArrowScale">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="minimum">
+        <double>1.000000000000000</double>
+       </property>
+       <property name="maximum">
+        <double>300.000000000000000</double>
+       </property>
+      </widget>
+     </item>
+    </layout>
    </item>
-   <item row="5" column="2">
-    <widget class="QLabel" name="endArrowScaleLabel">
+   <item row="3" column="0">
+    <widget class="QLabel" name="startArrowLabel">
      <property name="text">
-      <string>Scaling:</string>
-     </property>
-    </widget>
-   </item>
-   <item row="5" column="3">
-    <widget class="ScrSpinBox" name="endArrowScale">
-     <property name="minimum">
-      <double>1.000000000000000</double>
-     </property>
-     <property name="maximum">
-      <double>300.000000000000000</double>
+      <string>Start Arrow:</string>
      </property>
     </widget>
    </item>
-   <item row="6" column="0" colspan="2">
-    <widget class="QLabel" name="lineWidthLabel">
+   <item row="3" column="1">
+    <widget class="QLabel" name="endArrowLabel">
      <property name="text">
-      <string>Line &amp;Width:</string>
-     </property>
-    </widget>
-   </item>
-   <item row="6" column="2" colspan="2">
-    <widget class="ScrSpinBox" name="lineWidth">
-     <property name="specialValueText">
-      <string>Hairline</string>
-     </property>
-     <property name="maximum">
-      <double>300.000000000000000</double>
+      <string>End Arrow:</string>
      </property>
     </widget>
    </item>
-   <item row="7" column="0">
+   <item row="8" column="0">
     <widget class="QLabel" name="lineJoinLabel">
      <property name="text">
       <string>Ed&amp;ges:</string>
      </property>
     </widget>
    </item>
-   <item row="7" column="2" colspan="2">
-    <widget class="QComboBox" name="lineJoinStyle"/>
-   </item>
-   <item row="8" column="0">
+   <item row="9" column="0">
     <widget class="QLabel" name="lineEndLabel">
      <property name="text">
       <string>&amp;Endings:</string>
      </property>
     </widget>
    </item>
-   <item row="8" column="2" colspan="2">
-    <widget class="QComboBox" name="lineEndStyle"/>
-   </item>
-   <item row="9" column="0" colspan="4">
-    <widget class="QListWidget" name="lineStyles"/>
-   </item>
   </layout>
  </widget>
  <customwidgets>
-- 
2.27.0
0001-Shrink-minimal-width-for-Line-tab-in-Propeties-Palet.patch (8,140 bytes)   
pp_line.gif (37,884 bytes)   
pp_line.gif (37,884 bytes)   

jghali

2021-03-02 20:38

administrator   ~0048896

Applied, thanks!

FirasH

2021-03-21 14:54

reporter   ~0048980

Thanks!
Fixed in 1.5.7.svn (24543)

Issue History

Date Modified Username Field Change
2021-03-02 19:18 bubu New Issue
2021-03-02 19:18 bubu File Added: 0001-Shrink-minimal-width-for-Line-tab-in-Propeties-Palet.patch
2021-03-02 19:18 bubu File Added: pp_line.gif
2021-03-02 20:38 jghali Assigned To => jghali
2021-03-02 20:38 jghali Status new => resolved
2021-03-02 20:38 jghali Resolution open => fixed
2021-03-02 20:38 jghali Fixed in Version => 1.5.7.svn
2021-03-02 20:38 jghali Note Added: 0048896
2021-03-03 06:20 PeterBenedek Relationship added child of 0013906
2021-03-21 14:54 FirasH Status resolved => closed
2021-03-21 14:54 FirasH Note Added: 0048980