View Issue Details

IDProjectCategoryView StatusLast Update
0016522ScribusUser Interfacepublic2021-03-21 15:01
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016522: Cleanup, remove unused "..." text from toolbuttons
DescriptionI propose an another cleanup for .ui files: to remove default Qt designer's "..." text from toolbuttons.

There are several types of cases:
- image icon replaces "..." text
- "..." text is wanted on the button, but there is an "ellipsis" icon for this feature, unifying this case
- default tooltips

Comments:
- See screenshots to find the places.
- In some cases diff for .ui files are not clean, but there are no more but removing <property name="text"><string>...</string></property>
- ellipsis.png icon is missing from 1_5_1 and 1_5_1_dark (present in 1_5_0). Please add attached icons.
- In insertaframe.cpp slot iconSetChange was missing, I added it.
- positionsetter.ui → I think this UI is out of use. See 0016470 (no screeshot)
- prefs_documentsetupbase.ui → This button is hidden. See: prefs_documentsetupbase.cpp L46-47 (no screeshot)

There are no more such cases in the code that need to be fixed. That is all.
TagsNo tags attached.
PatchNo

Activities

bubu

2021-03-19 10:25

reporter  

0001-Cleanup-remove-unused-.-text-from-toolbuttons.patch (35,110 bytes)   
From 1e2afc7691cae693b655083d1156bb4324d53592 Mon Sep 17 00:00:00 2001
Message-Id: <1e2afc7691cae693b655083d1156bb4324d53592.1616148764.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Fri, 19 Mar 2021 11:10:24 +0100
Subject: [PATCH] Cleanup, remove unused "..." text from toolbuttons

---
 scribus/plugins/picbrowser/picturebrowser.cpp |   2 +
 scribus/plugins/picbrowser/picturebrowser.ui  | 219 +++++++++---------
 .../tools/pathfinder/pathfinderbase.ui        | 107 ++++-----
 scribus/ui/colorsandfillsbase.ui              | 113 +++++----
 scribus/ui/insertaframe.cpp                   |  12 +-
 scribus/ui/insertaframe.h                     |   1 +
 scribus/ui/insertaframe.ui                    |   9 -
 scribus/ui/multipleduplicate.ui               |   3 -
 scribus/ui/positionsetter.ui                  |   3 -
 scribus/ui/prefs_documentsetupbase.ui         |   3 -
 scribus/ui/prefs_itemtoolsbase.ui             |   3 -
 scribus/ui/prefs_pdfexportbase.ui             | 214 +++++++++--------
 scribus/ui/propertiespalette_imagebase.ui     |   6 -
 13 files changed, 326 insertions(+), 369 deletions(-)

diff --git a/scribus/plugins/picbrowser/picturebrowser.cpp b/scribus/plugins/picbrowser/picturebrowser.cpp
index eeedd2683..3064efd84 100644
--- a/scribus/plugins/picbrowser/picturebrowser.cpp
+++ b/scribus/plugins/picbrowser/picturebrowser.cpp
@@ -1627,6 +1627,8 @@ void PictureBrowser::loadIcons()
 	closeButton->setIcon(iconClose);
 
 	moreButton->setIcon(iconArrowDown);
+
+	filterSearchDirButton->setIcon(im.loadIcon("ellipsis.png"));
 }
 
 
diff --git a/scribus/plugins/picbrowser/picturebrowser.ui b/scribus/plugins/picbrowser/picturebrowser.ui
index f2b1218d9..9691b3552 100644
--- a/scribus/plugins/picbrowser/picturebrowser.ui
+++ b/scribus/plugins/picbrowser/picturebrowser.ui
@@ -8,30 +8,30 @@
     <y>0</y>
     <width>967</width>
     <height>482</height>
-   </rect>
-  </property>
-  <property name="windowTitle">
-   <string>Picture Browser</string>
-  </property>
-  <layout class="QGridLayout">
-   <property name="leftMargin">
-    <number>9</number>
-   </property>
-   <property name="topMargin">
-    <number>9</number>
-   </property>
-   <property name="rightMargin">
-    <number>9</number>
-   </property>
-   <property name="bottomMargin">
-    <number>9</number>
-   </property>
-   <item row="0" column="0">
-    <widget class="QSplitter" name="splitter_2">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <widget class="QWidget" name="widget_3" native="true">
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Picture Browser</string>
+  </property>
+  <layout class="QGridLayout">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item row="0" column="0">
+    <widget class="QSplitter" name="splitter_2">
+     <property name="orientation">
+      <enum>Qt::Vertical</enum>
+     </property>
+     <widget class="QWidget" name="widget_3" native="true">
       <layout class="QGridLayout">
        <property name="leftMargin">
         <number>0</number>
@@ -47,35 +47,35 @@
        </property>
        <item row="0" column="0">
         <widget class="QSplitter" name="splitter">
-         <property name="orientation">
-          <enum>Qt::Horizontal</enum>
-         </property>
-         <property name="handleWidth">
-          <number>9</number>
-         </property>
-         <widget class="QWidget" name="widget" native="true">
-          <property name="sizePolicy">
-           <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+         <property name="orientation">
+          <enum>Qt::Horizontal</enum>
+         </property>
+         <property name="handleWidth">
+          <number>9</number>
+         </property>
+         <widget class="QWidget" name="widget" native="true">
+          <property name="sizePolicy">
+           <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
             <horstretch>1</horstretch>
             <verstretch>0</verstretch>
-           </sizepolicy>
-          </property>
-          <layout class="QVBoxLayout" name="verticalLayout_3">
-           <property name="leftMargin">
-            <number>0</number>
-           </property>
-           <property name="topMargin">
-            <number>0</number>
-           </property>
-           <property name="rightMargin">
-            <number>0</number>
-           </property>
-           <property name="bottomMargin">
-            <number>0</number>
-           </property>
-           <item>
-            <widget class="QComboBox" name="navigationBox">
-             <item>
+           </sizepolicy>
+          </property>
+          <layout class="QVBoxLayout" name="verticalLayout_3">
+           <property name="leftMargin">
+            <number>0</number>
+           </property>
+           <property name="topMargin">
+            <number>0</number>
+           </property>
+           <property name="rightMargin">
+            <number>0</number>
+           </property>
+           <property name="bottomMargin">
+            <number>0</number>
+           </property>
+           <item>
+            <widget class="QComboBox" name="navigationBox">
+             <item>
               <property name="text">
                <string>Folder Browser</string>
               </property>
@@ -96,27 +96,27 @@
             <widget class="QStackedWidget" name="navigationStack">
              <property name="currentIndex">
               <number>0</number>
-             </property>
-             <widget class="QWidget" name="folderpage">
-              <layout class="QVBoxLayout" name="verticalLayout_2">
-               <property name="spacing">
-                <number>3</number>
-               </property>
-               <property name="leftMargin">
-                <number>0</number>
-               </property>
-               <property name="topMargin">
-                <number>0</number>
-               </property>
-               <property name="rightMargin">
-                <number>0</number>
-               </property>
-               <property name="bottomMargin">
-                <number>0</number>
-               </property>
-               <item>
-                <widget class="QCheckBox" name="subdirsCheckbox">
-                 <property name="text">
+             </property>
+             <widget class="QWidget" name="folderpage">
+              <layout class="QVBoxLayout" name="verticalLayout_2">
+               <property name="spacing">
+                <number>3</number>
+               </property>
+               <property name="leftMargin">
+                <number>0</number>
+               </property>
+               <property name="topMargin">
+                <number>0</number>
+               </property>
+               <property name="rightMargin">
+                <number>0</number>
+               </property>
+               <property name="bottomMargin">
+                <number>0</number>
+               </property>
+               <item>
+                <widget class="QCheckBox" name="subdirsCheckbox">
+                 <property name="text">
                   <string>Include Subdirectories</string>
                  </property>
                 </widget>
@@ -159,24 +159,24 @@
                  </property>
                  <property name="currentIndex">
                   <number>0</number>
-                 </property>
-                 <widget class="QWidget" name="page_5">
-                  <layout class="QHBoxLayout" name="horizontalLayout_2">
-                   <property name="leftMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="topMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="rightMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="bottomMargin">
-                    <number>0</number>
-                   </property>
-                   <item>
-                    <widget class="QPushButton" name="collectionsNewCategoryButton">
-                     <property name="minimumSize">
+                 </property>
+                 <widget class="QWidget" name="page_5">
+                  <layout class="QHBoxLayout" name="horizontalLayout_2">
+                   <property name="leftMargin">
+                    <number>0</number>
+                   </property>
+                   <property name="topMargin">
+                    <number>0</number>
+                   </property>
+                   <property name="rightMargin">
+                    <number>0</number>
+                   </property>
+                   <property name="bottomMargin">
+                    <number>0</number>
+                   </property>
+                   <item>
+                    <widget class="QPushButton" name="collectionsNewCategoryButton">
+                     <property name="minimumSize">
                       <size>
                        <width>23</width>
                        <height>23</height>
@@ -601,24 +601,24 @@
            <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
             <horstretch>3</horstretch>
             <verstretch>0</verstretch>
-           </sizepolicy>
-          </property>
-          <layout class="QVBoxLayout" name="verticalLayout">
-           <property name="leftMargin">
-            <number>0</number>
-           </property>
-           <property name="topMargin">
-            <number>0</number>
-           </property>
-           <property name="rightMargin">
-            <number>0</number>
-           </property>
-           <property name="bottomMargin">
-            <number>0</number>
-           </property>
-           <item>
-            <layout class="QHBoxLayout" name="horizontalLayout">
-             <item>
+           </sizepolicy>
+          </property>
+          <layout class="QVBoxLayout" name="verticalLayout">
+           <property name="leftMargin">
+            <number>0</number>
+           </property>
+           <property name="topMargin">
+            <number>0</number>
+           </property>
+           <property name="rightMargin">
+            <number>0</number>
+           </property>
+           <property name="bottomMargin">
+            <number>0</number>
+           </property>
+           <item>
+            <layout class="QHBoxLayout" name="horizontalLayout">
+             <item>
               <widget class="QComboBox" name="sortCombobox">
                <property name="currentIndex">
                 <number>0</number>
@@ -1295,9 +1295,6 @@
               <property name="toolTip">
                <string>Select a directory</string>
               </property>
-              <property name="text">
-               <string>...</string>
-              </property>
              </widget>
             </item>
            </layout>
diff --git a/scribus/plugins/tools/pathfinder/pathfinderbase.ui b/scribus/plugins/tools/pathfinder/pathfinderbase.ui
index 307422c19..25ec23b02 100644
--- a/scribus/plugins/tools/pathfinder/pathfinderbase.ui
+++ b/scribus/plugins/tools/pathfinder/pathfinderbase.ui
@@ -11,28 +11,28 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Boolean Path Operations</string>
-  </property>
-  <layout class="QVBoxLayout" name="verticalLayout_4">
-   <property name="leftMargin">
-    <number>9</number>
-   </property>
-   <property name="topMargin">
-    <number>9</number>
-   </property>
-   <property name="rightMargin">
-    <number>9</number>
-   </property>
-   <property name="bottomMargin">
-    <number>9</number>
-   </property>
-   <item>
-    <layout class="QHBoxLayout">
-     <item>
-      <layout class="QVBoxLayout">
-       <item>
-        <widget class="QLabel" name="sourceShape">
-         <property name="minimumSize">
+   <string>Boolean Path Operations</string>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout_4">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item>
+    <layout class="QHBoxLayout">
+     <item>
+      <layout class="QVBoxLayout">
+       <item>
+        <widget class="QLabel" name="sourceShape">
+         <property name="minimumSize">
           <size>
            <width>100</width>
            <height>100</height>
@@ -85,12 +85,12 @@
         </spacer>
        </item>
       </layout>
-     </item>
-     <item>
-      <layout class="QVBoxLayout">
-       <item>
-        <spacer>
-         <property name="orientation">
+     </item>
+     <item>
+      <layout class="QVBoxLayout">
+       <item>
+        <spacer>
+         <property name="orientation">
           <enum>Qt::Vertical</enum>
          </property>
          <property name="sizeHint" stdset="0">
@@ -132,12 +132,12 @@
         </spacer>
        </item>
       </layout>
-     </item>
-     <item>
-      <layout class="QVBoxLayout">
-       <item>
-        <widget class="QLabel" name="sourceShape2">
-         <property name="minimumSize">
+     </item>
+     <item>
+      <layout class="QVBoxLayout">
+       <item>
+        <widget class="QLabel" name="sourceShape2">
+         <property name="minimumSize">
           <size>
            <width>100</width>
            <height>100</height>
@@ -190,12 +190,12 @@
         </spacer>
        </item>
       </layout>
-     </item>
-     <item>
-      <layout class="QVBoxLayout">
-       <item>
-        <spacer>
-         <property name="orientation">
+     </item>
+     <item>
+      <layout class="QVBoxLayout">
+       <item>
+        <spacer>
+         <property name="orientation">
           <enum>Qt::Vertical</enum>
          </property>
          <property name="sizeHint" stdset="0">
@@ -295,17 +295,14 @@
        <item>
         <widget class="QGroupBox" name="groupBox">
          <property name="title">
-          <string>Operation</string>
-         </property>
-         <layout class="QHBoxLayout">
-          <item>
-           <widget class="QToolButton" name="opCombine">
-            <property name="toolTip">
+          <string>Operation</string>
+         </property>
+         <layout class="QHBoxLayout">
+          <item>
+           <widget class="QToolButton" name="opCombine">
+            <property name="toolTip">
              <string>Unites the shapes</string>
             </property>
-            <property name="text">
-             <string>...</string>
-            </property>
             <property name="checkable">
              <bool>true</bool>
             </property>
@@ -322,9 +319,6 @@
             <property name="toolTip">
              <string>Subtracts the second shape from the first shape</string>
             </property>
-            <property name="text">
-             <string>...</string>
-            </property>
             <property name="checkable">
              <bool>true</bool>
             </property>
@@ -338,9 +332,6 @@
             <property name="toolTip">
              <string>Intersection of the shapes</string>
             </property>
-            <property name="text">
-             <string>...</string>
-            </property>
             <property name="checkable">
              <bool>true</bool>
             </property>
@@ -354,9 +345,6 @@
             <property name="toolTip">
              <string>Result is the area where the two shapes do not intersect</string>
             </property>
-            <property name="text">
-             <string>...</string>
-            </property>
             <property name="checkable">
              <bool>true</bool>
             </property>
@@ -371,9 +359,6 @@
              <string>Break apart,
 The result is a combination of &quot;Intersection&quot; and &quot;Exclusion&quot;</string>
             </property>
-            <property name="text">
-             <string>...</string>
-            </property>
             <property name="checkable">
              <bool>true</bool>
             </property>
diff --git a/scribus/ui/colorsandfillsbase.ui b/scribus/ui/colorsandfillsbase.ui
index d869421e5..961b29dbf 100644
--- a/scribus/ui/colorsandfillsbase.ui
+++ b/scribus/ui/colorsandfillsbase.ui
@@ -11,37 +11,37 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Colors and Fills</string>
-  </property>
-  <property name="sizeGripEnabled">
-   <bool>false</bool>
-  </property>
-  <property name="modal">
-   <bool>true</bool>
-  </property>
-  <layout class="QHBoxLayout" name="horizontalLayout" stretch="1,0">
-   <property name="leftMargin">
-    <number>9</number>
-   </property>
-   <property name="topMargin">
-    <number>9</number>
-   </property>
-   <property name="rightMargin">
-    <number>9</number>
-   </property>
-   <property name="bottomMargin">
-    <number>9</number>
-   </property>
-   <item>
-    <widget class="QTreeWidget" name="dataTree">
-     <property name="toolTip">
-      <string>If color management is enabled, an exclamation mark indicates that the color may be outside of the color gamut of the current printer profile selected. What this means is the color may not print exactly as indicated on screen. Spot colors are indicated by a red circle. More hints about gamut warnings are in the online help under Color Management. Registration colors will have a registration mark next to the color. Use Registration only for printers marks and crop marks.</string>
-     </property>
-     <attribute name="headerVisible">
-      <bool>false</bool>
-     </attribute>
-     <column>
-      <property name="text">
+   <string>Colors and Fills</string>
+  </property>
+  <property name="sizeGripEnabled">
+   <bool>false</bool>
+  </property>
+  <property name="modal">
+   <bool>true</bool>
+  </property>
+  <layout class="QHBoxLayout" name="horizontalLayout" stretch="1,0">
+   <property name="leftMargin">
+    <number>9</number>
+   </property>
+   <property name="topMargin">
+    <number>9</number>
+   </property>
+   <property name="rightMargin">
+    <number>9</number>
+   </property>
+   <property name="bottomMargin">
+    <number>9</number>
+   </property>
+   <item>
+    <widget class="QTreeWidget" name="dataTree">
+     <property name="toolTip">
+      <string>If color management is enabled, an exclamation mark indicates that the color may be outside of the color gamut of the current printer profile selected. What this means is the color may not print exactly as indicated on screen. Spot colors are indicated by a red circle. More hints about gamut warnings are in the online help under Color Management. Registration colors will have a registration mark next to the color. Use Registration only for printers marks and crop marks.</string>
+     </property>
+     <attribute name="headerVisible">
+      <bool>false</bool>
+     </attribute>
+     <column>
+      <property name="text">
        <string>1</string>
       </property>
      </column>
@@ -112,33 +112,30 @@
        </property>
        <property name="text">
         <string>&amp;Remove Unused</string>
-       </property>
-      </widget>
-     </item>
-     <item>
-      <widget class="QGroupBox" name="groupBox_3">
-       <property name="title">
-        <string>Color Sets</string>
-       </property>
-       <layout class="QVBoxLayout" name="verticalLayout">
-        <item>
-         <widget class="QLabel" name="label">
-          <property name="text">
-           <string>Current Color Set:</string>
-          </property>
-         </widget>
-        </item>
-        <item>
-         <widget class="SwatchCombo" name="LoadColSet">
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QGroupBox" name="groupBox_3">
+       <property name="title">
+        <string>Color Sets</string>
+       </property>
+       <layout class="QVBoxLayout" name="verticalLayout">
+        <item>
+         <widget class="QLabel" name="label">
+          <property name="text">
+           <string>Current Color Set:</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <widget class="SwatchCombo" name="LoadColSet">
           <property name="sizePolicy">
            <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
             <horstretch>0</horstretch>
             <verstretch>0</verstretch>
            </sizepolicy>
           </property>
-          <property name="text">
-           <string>...</string>
-          </property>
           <property name="popupMode">
            <enum>QToolButton::MenuButtonPopup</enum>
           </property>
@@ -169,12 +166,12 @@
         </size>
        </property>
       </spacer>
-     </item>
-     <item>
-      <layout class="QVBoxLayout" name="verticalLayout_4">
-       <item>
-        <widget class="QPushButton" name="okButton">
-         <property name="toolTip">
+     </item>
+     <item>
+      <layout class="QVBoxLayout" name="verticalLayout_4">
+       <item>
+        <widget class="QPushButton" name="okButton">
+         <property name="toolTip">
           <string>Make the current colorset the default color set</string>
          </property>
          <property name="text">
diff --git a/scribus/ui/insertaframe.cpp b/scribus/ui/insertaframe.cpp
index 76eab3b52..3388becb5 100644
--- a/scribus/ui/insertaframe.cpp
+++ b/scribus/ui/insertaframe.cpp
@@ -44,8 +44,7 @@ InsertAFrame::InsertAFrame(QWidget* parent, ScribusDoc *doc) :
 	m_Doc(doc)
 {
 	setupUi(this);
-	
-	placementPagesRangeButton->setIcon(IconManager::instance().loadIcon("ellipsis.png"));
+	iconSetChange();
 	
 	//set tab order
 	QWidget::setTabOrder(radioButtonCustomPosition, xPosScrSpinBox);
@@ -270,3 +269,12 @@ void InsertAFrame::slotLinkToExistingFrame(int state)
 	sourceDocLineEdit->setEnabled(state == Qt::Unchecked);
 	selectDocFileButton->setEnabled(state == Qt::Unchecked);
 }
+
+void InsertAFrame::iconSetChange()
+{
+	IconManager& im = IconManager::instance();
+
+	placementPagesRangeButton->setIcon(im.loadIcon("ellipsis.png"));
+	selectDocFileButton->setIcon(im.loadIcon("ellipsis.png"));
+	selectImageFileButton->setIcon(im.loadIcon("ellipsis.png"));
+}
diff --git a/scribus/ui/insertaframe.h b/scribus/ui/insertaframe.h
index 8d9fec6fe..d7fd3692e 100644
--- a/scribus/ui/insertaframe.h
+++ b/scribus/ui/insertaframe.h
@@ -56,6 +56,7 @@ protected slots:
 	void slotLinkToExistingFrame(int state);
 	void locateImageFile();
 	void locateDocFile();
+	void iconSetChange();
 };
 
 #endif
diff --git a/scribus/ui/insertaframe.ui b/scribus/ui/insertaframe.ui
index 11ad3191f..0ed6cff64 100644
--- a/scribus/ui/insertaframe.ui
+++ b/scribus/ui/insertaframe.ui
@@ -140,9 +140,6 @@
               <property name="toolTip">
                <string/>
               </property>
-              <property name="text">
-               <string>...</string>
-              </property>
              </widget>
             </item>
            </layout>
@@ -568,9 +565,6 @@
              </item>
              <item>
               <widget class="QToolButton" name="selectDocFileButton">
-               <property name="text">
-                <string>...</string>
-               </property>
               </widget>
              </item>
             </layout>
@@ -610,9 +604,6 @@
              </item>
              <item>
               <widget class="QToolButton" name="selectImageFileButton">
-               <property name="text">
-                <string>...</string>
-               </property>
               </widget>
              </item>
             </layout>
diff --git a/scribus/ui/multipleduplicate.ui b/scribus/ui/multipleduplicate.ui
index fce61038f..c170ebd89 100644
--- a/scribus/ui/multipleduplicate.ui
+++ b/scribus/ui/multipleduplicate.ui
@@ -376,9 +376,6 @@
            </item>
            <item>
             <widget class="QToolButton" name="toolButtonPageRange">
-             <property name="text">
-              <string>...</string>
-             </property>
             </widget>
            </item>
           </layout>
diff --git a/scribus/ui/positionsetter.ui b/scribus/ui/positionsetter.ui
index 41ec19563..a63027d2b 100644
--- a/scribus/ui/positionsetter.ui
+++ b/scribus/ui/positionsetter.ui
@@ -97,9 +97,6 @@
            <verstretch>0</verstretch>
           </sizepolicy>
          </property>
-         <property name="text">
-          <string>...</string>
-         </property>
         </widget>
        </item>
       </layout>
diff --git a/scribus/ui/prefs_documentsetupbase.ui b/scribus/ui/prefs_documentsetupbase.ui
index bf517a6fd..55648eeab 100644
--- a/scribus/ui/prefs_documentsetupbase.ui
+++ b/scribus/ui/prefs_documentsetupbase.ui
@@ -139,9 +139,6 @@
            </item>
            <item>
             <widget class="QToolButton" name="pageSizeLinkToolButton">
-             <property name="text">
-              <string>...</string>
-             </property>
              <property name="arrowType">
               <enum>Qt::NoArrow</enum>
              </property>
diff --git a/scribus/ui/prefs_itemtoolsbase.ui b/scribus/ui/prefs_itemtoolsbase.ui
index 66a173198..817cf12da 100644
--- a/scribus/ui/prefs_itemtoolsbase.ui
+++ b/scribus/ui/prefs_itemtoolsbase.ui
@@ -940,9 +940,6 @@
                    <height>16777215</height>
                   </size>
                  </property>
-                 <property name="text">
-                  <string>...</string>
-                 </property>
                  <property name="checkable">
                   <bool>true</bool>
                  </property>
diff --git a/scribus/ui/prefs_pdfexportbase.ui b/scribus/ui/prefs_pdfexportbase.ui
index 3de0da9b1..5bac1bdbf 100644
--- a/scribus/ui/prefs_pdfexportbase.ui
+++ b/scribus/ui/prefs_pdfexportbase.ui
@@ -7,30 +7,30 @@
     <x>0</x>
     <y>0</y>
     <width>648</width>
-    <height>550</height>
-   </rect>
-  </property>
-  <property name="windowTitle">
-   <string notr="true">Form</string>
-  </property>
-  <layout class="QVBoxLayout" name="verticalLayout">
-   <property name="leftMargin">
-    <number>0</number>
-   </property>
-   <property name="topMargin">
-    <number>0</number>
-   </property>
-   <property name="rightMargin">
-    <number>0</number>
-   </property>
-   <property name="bottomMargin">
-    <number>0</number>
-   </property>
-   <item>
-    <widget class="QLabel" name="label">
-     <property name="font">
-      <font>
-       <pointsize>14</pointsize>
+    <height>550</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string notr="true">Form</string>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>
+   <item>
+    <widget class="QLabel" name="label">
+     <property name="font">
+      <font>
+       <pointsize>14</pointsize>
        <weight>75</weight>
        <bold>true</bold>
       </font>
@@ -194,9 +194,6 @@
          </item>
          <item>
           <widget class="QToolButton" name="pageMirrorHorizontalToolButton">
-           <property name="text">
-            <string>...</string>
-           </property>
            <property name="checkable">
             <bool>true</bool>
            </property>
@@ -204,9 +201,6 @@
          </item>
          <item>
           <widget class="QToolButton" name="pageMirrorVerticalToolButton">
-           <property name="text">
-            <string>...</string>
-           </property>
            <property name="checkable">
             <bool>true</bool>
            </property>
@@ -244,30 +238,30 @@
         </spacer>
        </item>
       </layout>
-     </widget>
-     <widget class="QWidget" name="tabFileOptions">
-      <attribute name="title">
-       <string>File Options</string>
-      </attribute>
-      <layout class="QVBoxLayout" name="verticalLayout_7">
-       <property name="leftMargin">
-        <number>0</number>
-       </property>
-       <property name="topMargin">
-        <number>0</number>
-       </property>
-       <property name="rightMargin">
-        <number>0</number>
-       </property>
-       <property name="bottomMargin">
-        <number>0</number>
-       </property>
-       <item>
-        <widget class="QScrollArea" name="scrollArea_3">
-         <property name="frameShape">
-          <enum>QFrame::NoFrame</enum>
-         </property>
-         <property name="frameShadow">
+     </widget>
+     <widget class="QWidget" name="tabFileOptions">
+      <attribute name="title">
+       <string>File Options</string>
+      </attribute>
+      <layout class="QVBoxLayout" name="verticalLayout_7">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
+       <item>
+        <widget class="QScrollArea" name="scrollArea_3">
+         <property name="frameShape">
+          <enum>QFrame::NoFrame</enum>
+         </property>
+         <property name="frameShadow">
           <enum>QFrame::Plain</enum>
          </property>
          <property name="lineWidth">
@@ -683,38 +677,38 @@
         </spacer>
        </item>
       </layout>
-     </widget>
-     <widget class="QWidget" name="tabColor">
-      <attribute name="title">
-       <string>Color</string>
-      </attribute>
-      <layout class="QVBoxLayout" name="verticalLayout_5">
-       <property name="leftMargin">
-        <number>0</number>
-       </property>
-       <property name="topMargin">
-        <number>0</number>
-       </property>
-       <property name="rightMargin">
-        <number>0</number>
-       </property>
-       <property name="bottomMargin">
-        <number>0</number>
-       </property>
-       <item>
-        <widget class="QScrollArea" name="scrollArea">
-         <property name="frameShape">
-          <enum>QFrame::NoFrame</enum>
-         </property>
-         <property name="frameShadow">
-          <enum>QFrame::Plain</enum>
-         </property>
-         <property name="lineWidth">
-          <number>0</number>
-         </property>
-         <property name="widgetResizable">
-          <bool>true</bool>
-         </property>
+     </widget>
+     <widget class="QWidget" name="tabColor">
+      <attribute name="title">
+       <string>Color</string>
+      </attribute>
+      <layout class="QVBoxLayout" name="verticalLayout_5">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
+       <item>
+        <widget class="QScrollArea" name="scrollArea">
+         <property name="frameShape">
+          <enum>QFrame::NoFrame</enum>
+         </property>
+         <property name="frameShadow">
+          <enum>QFrame::Plain</enum>
+         </property>
+         <property name="lineWidth">
+          <number>0</number>
+         </property>
+         <property name="widgetResizable">
+          <bool>true</bool>
+         </property>
          <widget class="QWidget" name="scrollAreaWidgetContents">
           <property name="geometry">
            <rect>
@@ -1022,30 +1016,30 @@
         </widget>
        </item>
       </layout>
-     </widget>
-     <widget class="QWidget" name="tabPrePress">
-      <attribute name="title">
-       <string>Pre-Press</string>
-      </attribute>
-      <layout class="QVBoxLayout" name="verticalLayout_6">
-       <property name="leftMargin">
-        <number>0</number>
-       </property>
-       <property name="topMargin">
-        <number>0</number>
-       </property>
-       <property name="rightMargin">
-        <number>0</number>
-       </property>
-       <property name="bottomMargin">
-        <number>0</number>
-       </property>
-       <item>
-        <widget class="QScrollArea" name="scrollArea_2">
-         <property name="frameShape">
-          <enum>QFrame::NoFrame</enum>
-         </property>
-         <property name="frameShadow">
+     </widget>
+     <widget class="QWidget" name="tabPrePress">
+      <attribute name="title">
+       <string>Pre-Press</string>
+      </attribute>
+      <layout class="QVBoxLayout" name="verticalLayout_6">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
+       <item>
+        <widget class="QScrollArea" name="scrollArea_2">
+         <property name="frameShape">
+          <enum>QFrame::NoFrame</enum>
+         </property>
+         <property name="frameShadow">
           <enum>QFrame::Plain</enum>
          </property>
          <property name="lineWidth">
diff --git a/scribus/ui/propertiespalette_imagebase.ui b/scribus/ui/propertiespalette_imagebase.ui
index 74d14f733..38a5aa008 100644
--- a/scribus/ui/propertiespalette_imagebase.ui
+++ b/scribus/ui/propertiespalette_imagebase.ui
@@ -145,9 +145,6 @@
         <property name="toolTip">
          <string>Keep the X and Y scaling the same</string>
         </property>
-        <property name="text">
-         <string>...</string>
-        </property>
         <property name="checkable">
          <bool>true</bool>
         </property>
@@ -234,9 +231,6 @@
           <height>32767</height>
          </size>
         </property>
-        <property name="text">
-         <string>...</string>
-        </property>
         <property name="checkable">
          <bool>true</bool>
         </property>
-- 
2.27.0

ellipsis_icon.zip (1,110 bytes)
colors_and_fills.png (41,447 bytes)   
colors_and_fills.png (41,447 bytes)   
image_properties.png (65,214 bytes)   
image_properties.png (65,214 bytes)   
insert_a_frame.png (44,596 bytes)   
insert_a_frame.png (44,596 bytes)   
multiple_duplicate.png (36,765 bytes)   
multiple_duplicate.png (36,765 bytes)   
path_operation.png (48,487 bytes)   
path_operation.png (48,487 bytes)   
pdf_export.png (108,912 bytes)   
pdf_export.png (108,912 bytes)   
picture_browser.png (75,039 bytes)   
picture_browser.png (75,039 bytes)   

bubu

2021-03-19 13:11

reporter   ~0048961

prefs_itemtools_images.png (119,292 bytes)   
prefs_itemtools_images.png (119,292 bytes)   

jghali

2021-03-20 11:04

administrator   ~0048964

Applied, thanks!

FirasH

2021-03-21 15:01

developer   ~0048988

Thanks!
Fixed in 1.5.7.svn (24576)

Issue History

Date Modified Username Field Change
2021-03-19 10:25 bubu New Issue
2021-03-19 10:25 bubu File Added: 0001-Cleanup-remove-unused-.-text-from-toolbuttons.patch
2021-03-19 10:25 bubu File Added: ellipsis_icon.zip
2021-03-19 10:25 bubu File Added: colors_and_fills.png
2021-03-19 10:25 bubu File Added: image_properties.png
2021-03-19 10:25 bubu File Added: insert_a_frame.png
2021-03-19 10:25 bubu File Added: multiple_duplicate.png
2021-03-19 10:25 bubu File Added: path_operation.png
2021-03-19 10:25 bubu File Added: pdf_export.png
2021-03-19 10:25 bubu File Added: picture_browser.png
2021-03-19 13:11 bubu Note Added: 0048961
2021-03-19 13:11 bubu File Added: prefs_itemtools_images.png
2021-03-20 11:04 jghali Assigned To => jghali
2021-03-20 11:04 jghali Status new => resolved
2021-03-20 11:04 jghali Resolution open => fixed
2021-03-20 11:04 jghali Fixed in Version => 1.5.7.svn
2021-03-20 11:04 jghali Note Added: 0048964
2021-03-21 15:01 FirasH Status resolved => closed
2021-03-21 15:01 FirasH Note Added: 0048988