View Issue Details

IDProjectCategoryView StatusLast Update
0016605Scribus3rd Partypublic2021-08-04 21:18
Reporterfsimonis Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version1.5.8.svn 
Fixed in Version1.5.8.svn 
Summary0016605: Compilation Error in lib2geom/path.h
DescriptionThe protected constructor BezierCurve(Point c[]) in lib2geom/path.h fails to compile with clang 12.0.1.
There is no matching overload for the assignment: "inner = Bezier(x, y);" in:

BezierCurve(Point c[]) {
  Coord x[order+1], y[order+1];
  for(unsigned i = 0; i <= order; i++) {
     x[i] = c[i][X]; y[i] = c[i][Y];
  }
  inner = Bezier(x, y); // ERROR <~~~
}


The attached patch removes this ctor.
TagsNo tags attached.
PatchYes

Activities

fsimonis

2021-08-03 15:32

reporter  

0001-Remove-broken-constructor.patch (956 bytes)   
From ada860c9cb59cad89120c9ddc6cdca32cd65a4a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Simonis?= <simonisfrederic@gmail.com>
Date: Tue, 3 Aug 2021 17:26:06 +0200
Subject: [PATCH] Remove broken constructor

---
 scribus/third_party/lib2geom/path.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/scribus/third_party/lib2geom/path.h b/scribus/third_party/lib2geom/path.h
index fab674ed3..b8d4a8847 100644
--- a/scribus/third_party/lib2geom/path.h
+++ b/scribus/third_party/lib2geom/path.h
@@ -250,15 +250,6 @@ public:
   double valueAt(double t, Dim2 d) const { return inner[d].valueAt(t); }
 
   D2<SBasis> toSBasis() const {return inner.toSBasis(); }
-
-protected:
-  BezierCurve(Point c[]) {
-    Coord x[order+1], y[order+1];
-    for(unsigned i = 0; i <= order; i++) {
-        x[i] = c[i][X]; y[i] = c[i][Y];
-    }
-    inner = Bezier(x, y);
-  }
 };
 
 // BezierCurve<0> is meaningless; specialize it out
-- 
2.32.0

jghali

2021-08-04 21:18

administrator   ~0049197

I commented out the code instead of removing it.

Issue History

Date Modified Username Field Change
2021-08-03 15:32 fsimonis New Issue
2021-08-03 15:32 fsimonis File Added: 0001-Remove-broken-constructor.patch
2021-08-04 21:18 jghali Note Added: 0049197
2021-08-04 21:18 jghali Assigned To => jghali
2021-08-04 21:18 jghali Status new => resolved
2021-08-04 21:18 jghali Resolution open => fixed
2021-08-04 21:18 jghali Fixed in Version => 1.5.8.svn