View Issue Details

IDProjectCategoryView StatusLast Update
0017317ScribusUser Interfacepublic2024-12-08 11:41
Reporterale Assigned Toale  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.7.0.svn 
Fixed in Version1.7.0.svn 
Summary0017317: [PATCH] Reverse the label for "Hide informational labels" and "Hide Labels of Inactive Palette Tabs"
DescriptionIt should be "Show informational labels" "Hide Labels of Inactive Palette Tabs" and they should be checked by default...
TagsNo tags attached.
PatchYes

Activities

ale

2024-11-21 19:26

manager   ~0051627

a minimal patch that only modifies the ui/ files
show-labels.diff (4,393 bytes)   
From 9eaf19f369905b112250816eccd30b5333948d30 Mon Sep 17 00:00:00 2001
From: ale rimoldi <ale@graphicslab.org>
Date: Thu, 21 Nov 2024 20:22:59 +0100
Subject: use a positive text for show labels


diff --git a/scribus/ui/prefs_userinterface.cpp b/scribus/ui/prefs_userinterface.cpp
index b790f1fb2..5caeaf046 100644
--- a/scribus/ui/prefs_userinterface.cpp
+++ b/scribus/ui/prefs_userinterface.cpp
@@ -72,8 +72,8 @@ void Prefs_UserInterface::languageChange()
 	//showSplashCheckBox->setToolTip( "<qt>" + tr( "" ) + "</qt>");
 	//showStartupDialogCheckBox->setToolTip( "<qt>" + tr( "" ) + "</qt>");
 	storyEditorUseSmartSelectionCheckBox->setToolTip( "<qt>" + tr( "The default behavior when double-clicking on a word is to select the word and the first following space. Smart selection will select only the word, without the following space." ) + "</qt>");
-	hideLabels->setToolTip("<qt>" + tr( "Hides informational labels on palettes." ) + "</qt>");
-	hideLabelsOfInactiveTabs->setToolTip("<qt>" + tr( "Hides labels of inactive palette tabs." ) + "</qt>");
+	showLabels->setToolTip("<qt>" + tr( "Shows informational labels on palettes." ) + "</qt>");
+	showLabelsOfInactiveTabs->setToolTip("<qt>" + tr( "Shows labels of inactive palette tabs." ) + "</qt>");
 }
 
 void Prefs_UserInterface::restoreDefaults(struct ApplicationPrefs *prefsData)
@@ -105,8 +105,8 @@ void Prefs_UserInterface::restoreDefaults(struct ApplicationPrefs *prefsData)
 	useTabsForDocumentsCheckBox->setChecked(prefsData->uiPrefs.useTabs);
 	showSplashCheckBox->setChecked(prefsData->uiPrefs.showSplashOnStartup);
 	useSmallWidgetsCheckBox->setChecked(prefsData->uiPrefs.useSmallWidgets);
-	hideLabels->setChecked(prefsData->uiPrefs.hideLabels);
-	hideLabelsOfInactiveTabs->setChecked(prefsData->uiPrefs.hideLabelsOfInactiveTabs);
+	showLabels->setChecked(!prefsData->uiPrefs.hideLabels);
+	showLabelsOfInactiveTabs->setChecked(!prefsData->uiPrefs.hideLabelsOfInactiveTabs);
 
 	storyEditorUseSmartSelectionCheckBox->setChecked(prefsData->storyEditorPrefs.smartTextSelection);
 	seFont.fromString(prefsData->storyEditorPrefs.guiFont);
@@ -128,8 +128,8 @@ void Prefs_UserInterface::saveGuiToPrefs(struct ApplicationPrefs *prefsData) con
 	prefsData->uiPrefs.useTabs = useTabsForDocumentsCheckBox->isChecked();
 	prefsData->uiPrefs.showSplashOnStartup = showSplashCheckBox->isChecked();
 	prefsData->uiPrefs.useSmallWidgets = useSmallWidgetsCheckBox->isChecked();
-	prefsData->uiPrefs.hideLabels = hideLabels->isChecked();
-	prefsData->uiPrefs.hideLabelsOfInactiveTabs = hideLabelsOfInactiveTabs->isChecked();
+	prefsData->uiPrefs.hideLabels = !showLabels->isChecked();
+	prefsData->uiPrefs.hideLabelsOfInactiveTabs = !showLabelsOfInactiveTabs->isChecked();
 
 	prefsData->storyEditorPrefs.guiFont = seFont.toString();
 	prefsData->storyEditorPrefs.smartTextSelection = storyEditorUseSmartSelectionCheckBox->isChecked();
diff --git a/scribus/ui/prefs_userinterfacebase.ui b/scribus/ui/prefs_userinterfacebase.ui
index 7b4be94a6..35b10be8b 100644
--- a/scribus/ui/prefs_userinterfacebase.ui
+++ b/scribus/ui/prefs_userinterfacebase.ui
@@ -128,16 +128,16 @@
           <widget class="QSpinBox" name="recentDocumentsSpinBox"/>
          </item>
          <item row="3" column="1">
-          <widget class="QCheckBox" name="hideLabels">
+          <widget class="QCheckBox" name="showLabels">
            <property name="text">
-            <string>Hide Informational Labels</string>
+            <string>Show Informational Labels</string>
            </property>
           </widget>
          </item>
          <item row="4" column="1">
-          <widget class="QCheckBox" name="hideLabelsOfInactiveTabs">
+          <widget class="QCheckBox" name="showLabelsOfInactiveTabs">
            <property name="text">
-            <string>Hide Labels of Inactive Palette Tabs</string>
+            <string>Show Labels of Inactive Palette Tabs</string>
            </property>
           </widget>
          </item>
@@ -451,7 +451,8 @@
   <tabstop>themeComboBox</tabstop>
   <tabstop>iconSetComboBox</tabstop>
   <tabstop>useSmallWidgetsCheckBox</tabstop>
-  <tabstop>hideLabels</tabstop>
+  <tabstop>showLabels</tabstop>
+  <tabstop>showLabelsOfInactiveTabs</tabstop>
   <tabstop>useTabsForDocumentsCheckBox</tabstop>
   <tabstop>recentDocumentsSpinBox</tabstop>
   <tabstop>languageComboBox</tabstop>
show-labels.diff (4,393 bytes)   

nitramr

2024-11-22 13:53

developer   ~0051633

I like the change.

cbradney

2024-11-24 20:33

administrator   ~0051648

Committed this but I also renamed the prefs variables so it all flows

Issue History

Date Modified Username Field Change
2024-11-21 19:04 ale New Issue
2024-11-21 19:25 ale Summary Reverse the label for "Hide informational labels" and "Hide Labels of Inactive Palette Tabs" => [PATCH] Reverse the label for "Hide informational labels" and "Hide Labels of Inactive Palette Tabs"
2024-11-21 19:25 ale Patch No => Yes
2024-11-21 19:26 ale Note Added: 0051627
2024-11-21 19:26 ale File Added: show-labels.diff
2024-11-22 13:53 nitramr Note Added: 0051633
2024-11-24 20:33 cbradney Assigned To => ale
2024-11-24 20:33 cbradney Status new => resolved
2024-11-24 20:33 cbradney Resolution open => fixed
2024-11-24 20:33 cbradney Fixed in Version => 1.7.0.svn
2024-11-24 20:33 cbradney Note Added: 0051648
2024-12-08 11:41 cbradney Status resolved => closed