View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017551 | Scribus | General | public | 2025-06-05 07:13 | 2025-06-05 20:53 |
Reporter | tgurr | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 1.6.4 | ||||
Fixed in Version | 1.6.5.svn | ||||
Summary | 0017551: 1.6.4 fails to build with popper 25.06.0 | ||||
Description | [...] [ 67%] Building CXX object scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o cd /var/tmp/paludis/build/app-office-scribus-1.6.4/work/build/scribus/plugins/import/pdf && /usr/bin/x86_64-pc-linux-gnu-c++ -DAPPDATADIR=\"/usr/share/metainfo/\" -DDESKTOPDIR=\"/usr/share/applications/\" -DDOCDIR=\"/usr/share/doc/scribus/\" -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_FREETYPE_H -DHAVE_UNISTD_H -DICONDIR=\"/usr/share/scribus/icons/\" -DLIBDIR=\"/usr/x86_64-pc-linux-gnu/lib/scribus/\" -DPLUGINDIR=\"/usr/x86_64-pc-linux-gnu/lib/scribus/plugins/\" -DQMLDIR=\"/usr/share/scribus/qml/\" -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x050E00 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DSAMPLESDIR=\"/usr/share/scribus/samples/\" -DSCRIPTSDIR=\"/usr/share/scribus/scripts/\" -DSHAREDIR=\"/usr/share/scribus/\" -DTEMPLATEDIR=\"/usr/share/scribus/templates/\" -Dimportpdf_EXPORTS -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/build/scribus/plugins/import/pdf -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/build/scribus/plugins/import/pdf/importpdf_autogen/include -I/usr/x86_64-pc-linux-gnu/include/GraphicsMagick -I/usr/x86_64-pc-linux-gnu/include/qt5/QtPrintSupport -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/build -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/build/scribus -I/usr/x86_64-pc-linux-gnu/include/libxml2 -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4 -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus -I/usr/x86_64-pc-linux-gnu/include/freetype2 -I/usr/x86_64-pc-linux-gnu/include/harfbuzz -I/usr/x86_64-pc-linux-gnu/include/libpng16 -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/third_party/hyphen -I/usr/x86_64-pc-linux-gnu/lib/openssl-3/include -I/usr/x86_64-pc-linux-gnu/include/cairo -I/usr/x86_64-pc-linux-gnu/include/poppler -I/var/tmp/paludis/build/app-office-scribus-1.6.4/work/build/scribus/scribus_autogen/include -isystem /usr/x86_64-pc-linux-gnu/include/qt5 -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtCore -isystem /usr/x86_64-pc-linux-gnu/lib/qt5/mkspecs/linux-g++ -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtWidgets -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtGui -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtXml -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtNetwork -isystem /usr/x86_64-pc-linux-gnu/include/qt5/QtOpenGL -march=native -O2 -pipe -O3 -DNDEBUG -O2 -Wall -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -fPIC -MD -MT scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o -MF CMakeFiles/importpdf.dir/slaoutput.cpp.o.d -o CMakeFiles/importpdf.dir/slaoutput.cpp.o -c /var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf/slaoutput.cpp /var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf/slaoutput.cpp: In member function 'bool SlaOutputDev::handleWidgetAnnot(Annot*, double, double, double, double)': /var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf/slaoutput.cpp:609:59: error: cannot convert 'std::shared_ptr<AnnotWidget>' to 'AnnotWidget*' in initialization 609 | AnnotWidget *ano = fm->getWidgetAnnotation(); | ~~~~~~~~~~~~~~~~~~~~~~~^~ | | | std::shared_ptr<AnnotWidget> /var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf/slaoutput.cpp: In member function 'virtual void SlaOutputDev::updateFont(GfxState*)': /var/tmp/paludis/build/app-office-scribus-1.6.4/work/scribus-1.6.4/scribus/plugins/import/pdf/slaoutput.cpp:3127:13: warning: unused variable 'faceIndex' [-Wunused-variable] 3127 | int faceIndex = 0; | ^~~~~~~~~ make[2]: *** [scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/build.make:150: scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:6451: scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 | ||||
Steps To Reproduce | 1. Install popper 25.06.0 2. Try to build scribus 1.6.4 | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
Already fixed in 1.6.5.svn |
|
Thanks. Could you please attach the commit as a patch and/or update the github mirror and/or fix https://scribus.net/websvn it's a real hassle to check if things have been fixed already before reporting such issues and to access the possible fixes if there are any. Again thanks in advance. |
|
The GitHub mirror is not managed by Scribus team, so unfortunately that's not in my power to update it. But here is the patch I applied to 1.6.x branch. 17551_fix_poppler_25_06.diff (634 bytes)
Index: slaoutput.cpp =================================================================== --- slaoutput.cpp (révision 26917) +++ slaoutput.cpp (révision 26918) @@ -606,7 +606,12 @@ FormWidget *fm = m_formWidgets->getWidget(i); if (!fm) continue; - AnnotWidget *ano = fm->getWidgetAnnotation(); +#if POPPLER_ENCODED_VERSION >= POPPLER_VERSION_ENCODE(25, 06, 0) + std::shared_ptr<AnnotWidget> anoSharedPtr = fm->getWidgetAnnotation(); + AnnotWidget* ano = anoSharedPtr.get(); +#else + AnnotWidget* ano = fm->getWidgetAnnotation(); +#endif if (!ano) continue; if (ano != (AnnotWidget*) annota) |
|
well, to be honest, the fix is from yesterday. the situation with the mirror that needs to be manually triggered is not optimal, but the alternative is not to have any access through git (and no visibility on an important platform like github). if somebody has an idea, how we could make the sync automatic or how we can automatically publish some sort of list of changes from svn, i can put some effort to get it to work... ... or we could get scribus to switch to git and have a modern platform for managing pull requests : - ) |
|
i've found two tools that seem to provide svn log without many dependencies: https://github.com/Diahon/Diahon.VersionControl.Subversion/tree/main https://codeberg.org/rofl0r/svn-lite if somebody wants to spend some time to understand them and see if it's possible to extract from them the code that would allow to have js (client side) or php that can do svn log without checking out the full repo... then i might be able to do something... |
Date Modified | Username | Field | Change |
---|---|---|---|
2025-06-05 07:13 | tgurr | New Issue | |
2025-06-05 18:29 | jghali | Assigned To | => jghali |
2025-06-05 18:29 | jghali | Status | new => resolved |
2025-06-05 18:29 | jghali | Resolution | open => fixed |
2025-06-05 18:29 | jghali | Fixed in Version | => 1.6.5.svn |
2025-06-05 18:29 | jghali | Note Added: 0052703 | |
2025-06-05 18:35 | tgurr | Note Added: 0052704 | |
2025-06-05 19:30 | jghali | Note Added: 0052705 | |
2025-06-05 19:30 | jghali | File Added: 17551_fix_poppler_25_06.diff | |
2025-06-05 20:23 | ale | Note Added: 0052706 | |
2025-06-05 20:53 | ale | Note Added: 0052708 |