View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017910 | Scribus | User Interface | public | 2026-08-05 13:25 | 2026-08-06 00:36 |
| Reporter | qirat | Assigned To | cbradney | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Fedora Workstation | OS Version | 44 |
| Product Version | 1.7.4.svn | ||||
| Fixed in Version | 1.7.4.svn | ||||
| Summary | 0017910: [PATCH] Line Style widget UI polished | ||||
| Description | As I mentioned in 0017909, I never saw this widget before. When I finally did today, I took some liberty to polish the UI a bit. Here is the patch, with screenshots showing before and after the changes. | ||||
| Tags | No tags attached. | ||||
| Attached Files | line-style-widget-ui-improvements-v1.3.patch (10,528 bytes)
Index: scribus/ui/smlinestylewidget.ui
===================================================================
--- scribus/ui/smlinestylewidget.ui (revision 27754)
+++ scribus/ui/smlinestylewidget.ui (working copy)
@@ -6,26 +6,26 @@
<rect>
<x>0</x>
<y>0</y>
- <width>469</width>
- <height>298</height>
- </rect>
- </property>
- <layout class="QVBoxLayout">
- <item>
- <layout class="QHBoxLayout">
- <property name="leftMargin">
- <number>0</number>
- </property>
- <property name="topMargin">
- <number>0</number>
- </property>
- <property name="rightMargin">
- <number>0</number>
- </property>
- <property name="bottomMargin">
- <number>0</number>
- </property>
- <item>
+ <width>500</width>
+ <height>345</height>
+ </rect>
+ </property>
+ <layout class="QVBoxLayout">
+ <item>
+ <layout class="QHBoxLayout">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
+ <item>
<widget class="QPushButton" name="addButton">
<property name="sizePolicy">
<sizepolicy hsizetype="Fixed" vsizetype="Fixed">
@@ -78,10 +78,10 @@
<item>
<spacer>
<property name="orientation">
- <enum>Qt::Horizontal</enum>
+ <enum>Qt::Orientation::Horizontal</enum>
</property>
<property name="sizeType">
- <enum>QSizePolicy::Expanding</enum>
+ <enum>QSizePolicy::Policy::Expanding</enum>
</property>
<property name="sizeHint" stdset="0">
<size>
@@ -92,22 +92,22 @@
</spacer>
</item>
</layout>
- </item>
- <item>
- <layout class="QHBoxLayout">
- <property name="leftMargin">
- <number>0</number>
- </property>
- <property name="topMargin">
- <number>0</number>
- </property>
- <property name="rightMargin">
- <number>0</number>
- </property>
- <property name="bottomMargin">
- <number>0</number>
- </property>
- <item>
+ </item>
+ <item>
+ <layout class="QHBoxLayout">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
+ <item>
<widget class="QListWidget" name="lineStyles">
<property name="maximumSize">
<size>
@@ -116,37 +116,61 @@
</size>
</property>
</widget>
- </item>
- <item>
- <layout class="QVBoxLayout">
- <property name="leftMargin">
- <number>0</number>
- </property>
- <property name="topMargin">
- <number>0</number>
- </property>
- <property name="rightMargin">
- <number>0</number>
- </property>
- <property name="bottomMargin">
- <number>0</number>
- </property>
- <item>
- <layout class="QGridLayout">
- <property name="leftMargin">
- <number>0</number>
- </property>
- <property name="topMargin">
- <number>0</number>
- </property>
- <property name="rightMargin">
- <number>0</number>
- </property>
- <property name="bottomMargin">
- <number>0</number>
- </property>
- <item row="1" column="0">
- <widget class="QComboBox" name="endCombo">
+ </item>
+ <item>
+ <layout class="QVBoxLayout">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
+ <item>
+ <layout class="QGridLayout">
+ <property name="leftMargin">
+ <number>0</number>
+ </property>
+ <property name="topMargin">
+ <number>0</number>
+ </property>
+ <property name="rightMargin">
+ <number>0</number>
+ </property>
+ <property name="bottomMargin">
+ <number>0</number>
+ </property>
+ <item row="3" column="0">
+ <widget class="QLabel" name="label_2">
+ <property name="text">
+ <string>Cap:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="4" column="0">
+ <widget class="QLabel" name="label_3">
+ <property name="text">
+ <string>Join:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="2" column="0">
+ <widget class="QLabel" name="label_4">
+ <property name="text">
+ <string>Colour:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="LineCombo" name="dashCombo"/>
+ </item>
+ <item row="3" column="1">
+ <widget class="QComboBox" name="endCombo">
<property name="sizePolicy">
<sizepolicy hsizetype="Expanding" vsizetype="Fixed">
<horstretch>0</horstretch>
@@ -155,7 +179,14 @@
</property>
</widget>
</item>
- <item row="2" column="0">
+ <item row="0" column="0">
+ <widget class="QLabel" name="label">
+ <property name="text">
+ <string>Style:</string>
+ </property>
+ </widget>
+ </item>
+ <item row="4" column="1">
<widget class="QComboBox" name="joinCombo">
<property name="sizePolicy">
<sizepolicy hsizetype="Expanding" vsizetype="Fixed">
@@ -165,27 +196,11 @@
</property>
</widget>
</item>
- <item row="0" column="0">
- <widget class="LineCombo" name="dashCombo"/>
+ <item row="2" column="1">
+ <widget class="ColorCombo" name="colorCombo"/>
</item>
- </layout>
- </item>
- <item>
- <layout class="QGridLayout">
- <property name="leftMargin">
- <number>0</number>
- </property>
- <property name="topMargin">
- <number>0</number>
- </property>
- <property name="rightMargin">
- <number>0</number>
- </property>
- <property name="bottomMargin">
- <number>0</number>
- </property>
- <item row="1" column="1">
- <widget class="QSpinBox" name="shadeBox">
+ <item row="2" column="2">
+ <widget class="QSpinBox" name="shadeBox">
<property name="sizePolicy">
<sizepolicy hsizetype="Minimum" vsizetype="Fixed">
<horstretch>0</horstretch>
@@ -212,7 +227,7 @@
</property>
</widget>
</item>
- <item row="0" column="0">
+ <item row="1" column="0">
<widget class="QLabel" name="textLabel2">
<property name="sizePolicy">
<sizepolicy hsizetype="Expanding" vsizetype="Preferred">
@@ -221,7 +236,7 @@
</sizepolicy>
</property>
<property name="text">
- <string>Line Width:</string>
+ <string>Width:</string>
</property>
<property name="wordWrap">
<bool>false</bool>
@@ -228,10 +243,7 @@
</property>
</widget>
</item>
- <item row="1" column="0">
- <widget class="ColorCombo" name="colorCombo"/>
- </item>
- <item row="0" column="1">
+ <item row="1" column="1">
<widget class="ScrSpinBox" name="lineWidth"/>
</item>
</layout>
@@ -239,10 +251,10 @@
<item>
<spacer>
<property name="orientation">
- <enum>Qt::Vertical</enum>
+ <enum>Qt::Orientation::Vertical</enum>
</property>
<property name="sizeType">
- <enum>QSizePolicy::Fixed</enum>
+ <enum>QSizePolicy::Policy::Fixed</enum>
</property>
<property name="sizeHint" stdset="0">
<size>
@@ -253,6 +265,13 @@
</spacer>
</item>
<item>
+ <widget class="QLabel" name="label_5">
+ <property name="text">
+ <string>Preview</string>
+ </property>
+ </widget>
+ </item>
+ <item>
<widget class="QLabel" name="previewLabel">
<property name="sizePolicy">
<sizepolicy hsizetype="Expanding" vsizetype="Preferred">
@@ -277,10 +296,10 @@
<item>
<spacer>
<property name="orientation">
- <enum>Qt::Vertical</enum>
+ <enum>Qt::Orientation::Vertical</enum>
</property>
<property name="sizeType">
- <enum>QSizePolicy::Expanding</enum>
+ <enum>QSizePolicy::Policy::Expanding</enum>
</property>
<property name="sizeHint" stdset="0">
<size>
@@ -290,19 +309,19 @@
</property>
</spacer>
</item>
- </layout>
- </item>
- </layout>
- </item>
- </layout>
- </widget>
- <customwidgets>
- <customwidget>
- <class>LineCombo</class>
- <extends>QComboBox</extends>
- <header>ui/linecombo.h</header>
- </customwidget>
+ </layout>
+ </item>
+ </layout>
+ </item>
+ </layout>
+ </widget>
+ <customwidgets>
<customwidget>
+ <class>LineCombo</class>
+ <extends>QComboBox</extends>
+ <header>ui/linecombo.h</header>
+ </customwidget>
+ <customwidget>
<class>ColorCombo</class>
<extends>QComboBox</extends>
<header>ui/colorcombo.h</header>
@@ -317,12 +336,6 @@
<tabstop>addButton</tabstop>
<tabstop>removeButton</tabstop>
<tabstop>lineStyles</tabstop>
- <tabstop>dashCombo</tabstop>
- <tabstop>endCombo</tabstop>
- <tabstop>joinCombo</tabstop>
- <tabstop>lineWidth</tabstop>
- <tabstop>colorCombo</tabstop>
- <tabstop>shadeBox</tabstop>
</tabstops>
<resources/>
<connections/>
| ||||
| Patch | Yes | ||||
|
|
No AI was used btw. |
|
|
Thanks qirat! |
|
|
Hey, thanks @cbradney. One more thing: in hindsight, I think it should be "Thickness" instead of "Width", don't you think? "Width" may be confused with how long a (horizontal) line is. Here is this minor change if you think the same. :) smlinestyle-minor.patch (490 bytes)
Index: scribus/ui/smlinestylewidget.ui
===================================================================
--- scribus/ui/smlinestylewidget.ui (revision 27760)
+++ scribus/ui/smlinestylewidget.ui (working copy)
@@ -236,7 +236,7 @@
</sizepolicy>
</property>
<property name="text">
- <string>Width:</string>
+ <string>Thickness:</string>
</property>
<property name="wordWrap">
<bool>false</bool>
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-08-05 13:25 | qirat | New Issue | |
| 2026-08-05 13:25 | qirat | File Added: line-style-current.png | |
| 2026-08-05 13:25 | qirat | File Added: line-style-proposed.png | |
| 2026-08-05 13:25 | qirat | File Added: line-style-widget-ui-improvements-v1.3.patch | |
| 2026-08-05 13:58 | qirat | Note Added: 0054152 | |
| 2026-08-05 19:21 | cbradney | Assigned To | => cbradney |
| 2026-08-05 19:21 | cbradney | Status | new => resolved |
| 2026-08-05 19:21 | cbradney | Resolution | open => fixed |
| 2026-08-05 19:21 | cbradney | Fixed in Version | => 1.7.4.svn |
| 2026-08-05 19:21 | cbradney | Note Added: 0054153 | |
| 2026-08-06 00:36 | qirat | Note Added: 0054158 | |
| 2026-08-06 00:36 | qirat | File Added: smlinestyle-minor.patch |
