|
|
Here is some screenshots to show what the issue was.
The 1.7.2 (flatpak) did not have the issue it is just for example (see filename) |
|
|
|
WAIT!
Here is a better one that fixes placeholder text in dark theme too. Since it is just one more line in the same file, I combined it.
dark-theme-palette-and-placeholder-text-fix-v1.1.patch (1,437 bytes)
Index: scribus/ui/factories/scribusproxystyle.cpp
===================================================================
--- scribus/ui/factories/scribusproxystyle.cpp (revision 27771)
+++ scribus/ui/factories/scribusproxystyle.cpp (working copy)
@@ -44,6 +44,7 @@
darkPalette.setColor(QPalette::ToolTipBase, Qt::white);
darkPalette.setColor(QPalette::ToolTipText, Qt::black);
darkPalette.setColor(QPalette::Text, Qt::white);
+ darkPalette.setColor(QPalette::PlaceholderText, QColor(127, 127, 127));
darkPalette.setColor(QPalette::Button, QColor(53, 53, 53));
darkPalette.setColor(QPalette::ButtonText, Qt::white);
darkPalette.setColor(QPalette::BrightText, Qt::red);
@@ -52,6 +53,14 @@
darkPalette.setColor(QPalette::HighlightedText, Qt::black);
darkPalette.setColor(QPalette::Shadow, Qt::black);
+ // Derive Light/Midlight/Dark/Mid from Window so palette(mid)/
+ // palette(light)/palette(dark) lookups in style sheets stay dark.
+ const QColor windowColor = darkPalette.color(QPalette::Window);
+ darkPalette.setColor(QPalette::Light, windowColor.lighter(150));
+ darkPalette.setColor(QPalette::Midlight, windowColor.lighter(120));
+ darkPalette.setColor(QPalette::Dark, windowColor.darker(150));
+ darkPalette.setColor(QPalette::Mid, windowColor.darker(120));
+
darkPalette.setColor(QPalette::Disabled, QPalette::Text, Qt::darkGray);
darkPalette.setColor(QPalette::Disabled, QPalette::ButtonText, Qt::darkGray);
|
|
|
|
Placeholder text before and after (screenshots) |
|
|
|
Here is a new improved version: adds proper placeholder/shading palette roles; avoids inherited light-theme colours.
The initial number in the filename suggests the order it is to go while testing my four dark theme fixes (tickets in order: 0017923, 0017924, 0017925, and 0017926).
1_dark-theme-palette-and-placeholder-text-fix-v1.13.patch (1,483 bytes)
Index: scribus/ui/factories/scribusproxystyle.cpp
===================================================================
--- scribus/ui/factories/scribusproxystyle.cpp (revision 27791)
+++ scribus/ui/factories/scribusproxystyle.cpp (working copy)
@@ -44,6 +44,9 @@
darkPalette.setColor(QPalette::ToolTipBase, Qt::white);
darkPalette.setColor(QPalette::ToolTipText, Qt::black);
darkPalette.setColor(QPalette::Text, Qt::white);
+ QColor placeholderTextColor = darkPalette.color(QPalette::Text);
+ placeholderTextColor.setAlpha(128);
+ darkPalette.setColor(QPalette::PlaceholderText, placeholderTextColor);
darkPalette.setColor(QPalette::Button, QColor(53, 53, 53));
darkPalette.setColor(QPalette::ButtonText, Qt::white);
darkPalette.setColor(QPalette::BrightText, Qt::red);
@@ -52,6 +55,13 @@
darkPalette.setColor(QPalette::HighlightedText, Qt::black);
darkPalette.setColor(QPalette::Shadow, Qt::black);
+ // Keep the palette's shading roles consistent with dark button surfaces.
+ const QColor buttonColor = darkPalette.color(QPalette::Button);
+ darkPalette.setColor(QPalette::Light, buttonColor.lighter(150));
+ darkPalette.setColor(QPalette::Midlight, buttonColor.lighter(120));
+ darkPalette.setColor(QPalette::Dark, buttonColor.darker(150));
+ darkPalette.setColor(QPalette::Mid, buttonColor.darker(120));
+
darkPalette.setColor(QPalette::Disabled, QPalette::Text, Qt::darkGray);
darkPalette.setColor(QPalette::Disabled, QPalette::ButtonText, Qt::darkGray);
|
|
|
|
My Fedora VM is currently broken, so I could not test your patch in Fedora. However it appears it also fixes issues when using KDE Breeze Qt theme in OpenSuse Tumbleweed, so I applied it. Thanks! |
|
