View Issue Details

IDProjectCategoryView StatusLast Update
0002197ScribusInternalpublic2005-07-09 18:44
Reporterjghali Assigned Toringerc 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformWindowsOSWindowsOS Version2000 SP4
Product Version1.3.0cvs 
Fixed in Version1.3.0cvs 
Summary0002197: Msvc compiler needs full type definition before destructor call
DescriptionSeveral file produce compiler warning C4150 : deletion of pointer to incomplete type 'name_of_file': no destructor called. This warning occur when a type is declared but not defined. For example :

class myClass;

void NoCall( myClass* pMyClass )
{
   delete pMyClass;
}

Possible consequence : memory leak. Attached diff include necessary files where needed. Additionnaly, in tocindexprefs.ui, please add "page.h" amongst file to be included in implementation.
TagsNo tags attached.
Attached Files
Msvc_C4150_13x.diff (8,001 bytes)   
Index: buttonicon.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/buttonicon.cpp,v
retrieving revision 1.10.2.4
diff -u -r1.10.2.4 buttonicon.cpp
--- buttonicon.cpp	3 Jul 2005 21:50:59 -0000	1.10.2.4
+++ buttonicon.cpp	6 Jul 2005 20:05:08 -0000
@@ -2,6 +2,7 @@
 #include "scfonts.h"
 #include "buttonicon.h"
 #include "buttonicon.moc"
+#include "scribusstructs.h"
 extern QPixmap loadIcon(QString nam);
 
 ButtonIcon::ButtonIcon(QWidget* parent, PageItem* ite)
Index: cpalette.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/cpalette.cpp,v
retrieving revision 1.25.2.12
diff -u -r1.25.2.12 cpalette.cpp
--- cpalette.cpp	1 Jul 2005 20:17:24 -0000	1.25.2.12
+++ cpalette.cpp	6 Jul 2005 20:04:33 -0000
@@ -35,6 +35,7 @@
 #include "mspinbox.h"
 #include "gradienteditor.h"
 #include "units.h"
+#include "page.h"
 
 
 extern QPixmap loadIcon(QString nam);
Index: dcolor.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/dcolor.cpp,v
retrieving revision 1.6.2.5
diff -u -r1.6.2.5 dcolor.cpp
--- dcolor.cpp	9 Jun 2005 00:07:01 -0000	1.6.2.5
+++ dcolor.cpp	6 Jul 2005 20:04:10 -0000
@@ -17,6 +17,7 @@
 #include <qiconset.h>
 
 #include "scribusdoc.h"
+#include "page.h"
 
 #include "dcolor.h"
 #include "dcolor.moc"
Index: documentchecker.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/Attic/documentchecker.cpp,v
retrieving revision 1.1.2.3
diff -u -r1.1.2.3 documentchecker.cpp
--- documentchecker.cpp	13 Jun 2005 23:34:35 -0000	1.1.2.3
+++ documentchecker.cpp	6 Jul 2005 20:03:45 -0000
@@ -19,6 +19,7 @@
 #include "pageitem.h"
 #include "scribusstructs.h"
 #include "scribusdoc.h"
+#include "page.h"
 
 void DocumentChecker::checkDocument(ScribusDoc *currDoc)
 {
Index: effectsdialog.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/Attic/effectsdialog.cpp,v
retrieving revision 1.1.2.10
diff -u -r1.1.2.10 effectsdialog.cpp
--- effectsdialog.cpp	9 Jun 2005 00:07:01 -0000	1.1.2.10
+++ effectsdialog.cpp	6 Jul 2005 20:03:09 -0000
@@ -16,6 +16,7 @@
 #include "scribusdoc.h"
 #include "shadebutton.h"
 #include "mspinbox.h"
+#include "page.h"
 
 extern QPixmap loadIcon(QString nam);
 
Index: fontcombo.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/fontcombo.cpp,v
retrieving revision 1.9.2.6
diff -u -r1.9.2.6 fontcombo.cpp
--- fontcombo.cpp	20 Jun 2005 21:36:12 -0000	1.9.2.6
+++ fontcombo.cpp	6 Jul 2005 20:02:44 -0000
@@ -22,6 +22,7 @@
 #include "scribusdoc.h"
 #include "fontcombo.h"
 #include "fontcombo.moc"
+#include "page.h"
 
 FontListItem::FontListItem(QComboBox* parent, QString f, QFont fo) : QListBoxItem(parent->listBox())
 {
Index: gtframestyle.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/gtframestyle.cpp,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 gtframestyle.cpp
--- gtframestyle.cpp	14 Jan 2005 23:40:45 -0000	1.1.2.1
+++ gtframestyle.cpp	6 Jul 2005 20:01:41 -0000
@@ -19,6 +19,7 @@
  ***************************************************************************/
 
 #include "gtframestyle.h"
+#include "scribusstructs.h"
 
 gtFrameStyle::gtFrameStyle(QString name) : gtParagraphStyle(name) 
 {
Index: gtparagraphstyle.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/gtparagraphstyle.cpp,v
retrieving revision 1.3.2.2
diff -u -r1.3.2.2 gtparagraphstyle.cpp
--- gtparagraphstyle.cpp	28 May 2005 16:15:19 -0000	1.3.2.2
+++ gtparagraphstyle.cpp	6 Jul 2005 20:01:41 -0000
@@ -19,6 +19,7 @@
  ***************************************************************************/
 
 #include "gtparagraphstyle.h"
+#include "scribusstructs.h"
 
 gtParagraphStyle::gtParagraphStyle(QString name) : gtStyle(name) 
 {
Index: gtwriter.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/gtwriter.cpp,v
retrieving revision 1.4.2.6
diff -u -r1.4.2.6 gtwriter.cpp
--- gtwriter.cpp	21 Apr 2005 23:18:14 -0000	1.4.2.6
+++ gtwriter.cpp	6 Jul 2005 20:00:17 -0000
@@ -21,6 +21,7 @@
 #include "gtwriter.h"
 //#include "scfonts.h"
 #include "pageitem.h"
+#include "scribusstructs.h"
 
 gtWriter::gtWriter(bool append)
 {
Index: inspage.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/inspage.cpp,v
retrieving revision 1.5.2.8
diff -u -r1.5.2.8 inspage.cpp
--- inspage.cpp	4 May 2005 23:27:10 -0000	1.5.2.8
+++ inspage.cpp	6 Jul 2005 19:59:35 -0000
@@ -17,6 +17,7 @@
 
 #include "inspage.h"
 #include "inspage.moc"
+#include "page.h"
 
 extern QPixmap loadIcon(QString nam);
 
Index: missing.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/missing.cpp,v
retrieving revision 1.11.2.5
diff -u -r1.11.2.5 missing.cpp
--- missing.cpp	16 Jan 2005 15:28:39 -0000	1.11.2.5
+++ missing.cpp	6 Jul 2005 19:58:44 -0000
@@ -9,6 +9,7 @@
 
 #include "fontcombo.h"
 #include "scribusdoc.h"
+#include "page.h"
 
 extern QPixmap loadIcon(QString nam);
 
Index: multiline.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/multiline.cpp,v
retrieving revision 1.25.2.4
diff -u -r1.25.2.4 multiline.cpp
--- multiline.cpp	3 Jul 2005 21:50:59 -0000	1.25.2.4
+++ multiline.cpp	6 Jul 2005 19:58:24 -0000
@@ -5,6 +5,7 @@
 #include <qmessagebox.h>
 
 #include "scribusdoc.h"
+#include "page.h"
 
 extern QPixmap loadIcon(QString nam);
 
Index: newtemp.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/newtemp.cpp,v
retrieving revision 1.7.2.2
diff -u -r1.7.2.2 newtemp.cpp
--- newtemp.cpp	8 Dec 2004 15:17:25 -0000	1.7.2.2
+++ newtemp.cpp	6 Jul 2005 19:58:02 -0000
@@ -1,5 +1,6 @@
 #include "newtemp.h"
 #include "newtemp.moc"
+#include "page.h"
 extern QPixmap loadIcon(QString nam);
 
 #include <qtooltip.h>
Index: spalette.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/spalette.cpp,v
retrieving revision 1.10.2.2
diff -u -r1.10.2.2 spalette.cpp
--- spalette.cpp	3 Jan 2005 14:08:54 -0000	1.10.2.2
+++ spalette.cpp	6 Jul 2005 19:57:27 -0000
@@ -20,6 +20,8 @@
 #include "spalette.h"
 #include "spalette.moc"
 
+#include "page.h"
+
 Spalette::Spalette(QWidget* parent) : QComboBox(true, parent, "Sfloat")
 {
 //	setMinimumSize(QSize(10,static_cast<int>(font().pointSize()*2.5)));
Index: tabmanager.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/tabmanager.cpp,v
retrieving revision 1.15.2.4
diff -u -r1.15.2.4 tabmanager.cpp
--- tabmanager.cpp	28 May 2005 16:15:19 -0000	1.15.2.4
+++ tabmanager.cpp	6 Jul 2005 19:57:26 -0000
@@ -7,6 +7,7 @@
 #include <qwhatsthis.h>
 #include "tabruler.h"
 #include "units.h"
+#include "scribusstructs.h"
 extern QPixmap loadIcon(QString nam);
 
 TabManager::TabManager( QWidget* parent, int dEin, QValueList<PageItem::TabRecord> inTab, double wid) : QDialog( parent, "TabManager", true, 0 )
Index: tabruler.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/tabruler.cpp,v
retrieving revision 1.3.2.11
diff -u -r1.3.2.11 tabruler.cpp
--- tabruler.cpp	6 Jun 2005 10:13:58 -0000	1.3.2.11
+++ tabruler.cpp	6 Jul 2005 19:56:16 -0000
@@ -13,6 +13,7 @@
 #include <qcursor.h>
 #include <qcolor.h>
 #include "units.h"
+#include "scribusstructs.h"
 extern QPixmap loadIcon(QString nam);
 
 RulerT::RulerT(QWidget *pa, int ein, QValueList<PageItem::TabRecord> Tabs, bool ind, double wid) : QWidget(pa)
Msvc_C4150_13x.diff (8,001 bytes)   
Patch

Relationships

related to 0002394 closedcbradney Fix msvc compatibility problem in scribusdoc.cpp 

Activities

Issue History

Date Modified Username Field Change
2005-07-06 18:24 jghali New Issue
2005-07-06 18:24 jghali File Added: Msvc_C4150_13x.diff
2005-07-07 03:07 ringerc Status new => assigned
2005-07-07 03:07 ringerc Assigned To => ringerc
2005-07-07 04:54 ringerc Status assigned => resolved
2005-07-07 04:54 ringerc Resolution open => fixed
2005-07-07 05:07 ringerc Fixed in Version => 1.3.0cvs
2005-07-09 18:44 cbradney Status resolved => closed
2005-08-05 17:36 ringerc Relationship added related to 0002394