View Issue Details

IDProjectCategoryView StatusLast Update
0006474ScribusPlug-inspublic2007-11-13 23:20
Reporterh_a_j_s Assigned Tosubik  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.5svn 
Target VersionFixed in Version1.3.5svn 
Summary0006474: myplugin failed to compile and
DescriptionThe example plugin "myplugin" does not compile and work after adding it with ADD_SUBDIRECTORY(myplugin) in scribus/plugins/CMakeLists.txt
Additional InformationI fixed it.
The attached patch correctly creates the moc-files so that all symbols are available.
Additionally I changed the code to remove the dependency on Qt3Suppport.
TagsNo tags attached.
Patch

Activities

2007-11-12 01:40

 

myplugin.patch (1,118 bytes)
diff -u trunk/scribus/plugins/myplugin/CMakeLists.txt work/scribus/plugins/myplugin/CMakeLists.txt
--- trunk/scribus/plugins/myplugin/CMakeLists.txt	2007-11-12 02:13:54.000000000 +0100
+++ work/scribus/plugins/myplugin/CMakeLists.txt	2007-11-12 02:04:26.000000000 +0100
@@ -15,7 +15,7 @@
 
 SET(SCRIBUS_MY_PLUGIN "myplugin")
 
-SCRIBUS_QT_WRAP_CPP(MY_PLUGIN_MOC_SOURCES ${MY_PLUGIN_MOC_CLASSES})
+QT4_WRAP_CPP(MY_PLUGIN_MOC_SOURCES ${MY_PLUGIN_MOC_CLASSES})
 
 ADD_LIBRARY(${SCRIBUS_MY_PLUGIN} MODULE ${MY_PLUGIN_SOURCES} ${MY_PLUGIN_MOC_SOURCES})
 
diff -u trunk/scribus/plugins/myplugin/mypluginimpl.cpp work/scribus/plugins/myplugin/mypluginimpl.cpp
--- trunk/scribus/plugins/myplugin/mypluginimpl.cpp	2007-11-12 02:13:54.000000000 +0100
+++ work/scribus/plugins/myplugin/mypluginimpl.cpp	2007-11-12 01:46:54.000000000 +0100
@@ -11,8 +11,9 @@
 #include <QMessageBox>
 
 // Initialize members here, if any
-MyPluginImpl::MyPluginImpl() : QObject(0, "MyPluginImpl")
+MyPluginImpl::MyPluginImpl() : QObject(0)
 {
+   setObjectName("MyPluginImpl");
 }
 
 bool MyPluginImpl::run(const QString & target, ScribusDoc* doc)
myplugin.patch (1,118 bytes)

2007-11-12 01:59

 

myplugin2.patch (1,657 bytes)
diff -u trunk/scribus/plugins/myplugin/CMakeLists.txt work/scribus/plugins/myplugin/CMakeLists.txt
--- trunk/scribus/plugins/myplugin/CMakeLists.txt	2007-11-12 02:13:54.000000000 +0100
+++ work/scribus/plugins/myplugin/CMakeLists.txt	2007-11-12 02:04:26.000000000 +0100
@@ -15,7 +15,7 @@
 
 SET(SCRIBUS_MY_PLUGIN "myplugin")
 
-SCRIBUS_QT_WRAP_CPP(MY_PLUGIN_MOC_SOURCES ${MY_PLUGIN_MOC_CLASSES})
+QT4_WRAP_CPP(MY_PLUGIN_MOC_SOURCES ${MY_PLUGIN_MOC_CLASSES})
 
 ADD_LIBRARY(${SCRIBUS_MY_PLUGIN} MODULE ${MY_PLUGIN_SOURCES} ${MY_PLUGIN_MOC_SOURCES})
 
diff -u trunk/scribus/plugins/myplugin/myplugin.h work/scribus/plugins/myplugin/myplugin.h
--- trunk/scribus/plugins/myplugin/myplugin.h	2007-11-12 02:13:54.000000000 +0100
+++ work/scribus/plugins/myplugin/myplugin.h	2007-11-12 02:55:43.000000000 +0100
@@ -4,8 +4,8 @@
 a copyright and/or license notice that predates the release of Scribus 1.3.2
 for which a new license (GPL+exception) is in place.
 */
-#ifndef COLORWHEEL_H
-#define COLORWHEEL_H
+#ifndef MYPLUGIN_H
+#define MYPLUGIN_H
 
 #include "pluginapi.h"
 #include "scplugin.h"
diff -u trunk/scribus/plugins/myplugin/mypluginimpl.cpp work/scribus/plugins/myplugin/mypluginimpl.cpp
--- trunk/scribus/plugins/myplugin/mypluginimpl.cpp	2007-11-12 02:13:54.000000000 +0100
+++ work/scribus/plugins/myplugin/mypluginimpl.cpp	2007-11-12 01:46:54.000000000 +0100
@@ -11,8 +11,9 @@
 #include <QMessageBox>
 
 // Initialize members here, if any
-MyPluginImpl::MyPluginImpl() : QObject(0, "MyPluginImpl")
+MyPluginImpl::MyPluginImpl() : QObject(0)
 {
+   setObjectName("MyPluginImpl");
 }
 
 bool MyPluginImpl::run(const QString & target, ScribusDoc* doc)
myplugin2.patch (1,657 bytes)

h_a_j_s

2007-11-12 01:59

developer   ~0017901

I added a new patch which also fixes a copy-paste error (#define COLORWHEEL_H...)

subik

2007-11-12 09:45

manager   ~0017902

thanks for this fix

Issue History

Date Modified Username Field Change
2007-11-12 01:40 h_a_j_s New Issue
2007-11-12 01:40 h_a_j_s File Added: myplugin.patch
2007-11-12 01:59 h_a_j_s File Added: myplugin2.patch
2007-11-12 01:59 h_a_j_s Note Added: 0017901
2007-11-12 09:40 subik Status new => assigned
2007-11-12 09:40 subik Assigned To => subik
2007-11-12 09:45 subik Status assigned => resolved
2007-11-12 09:45 subik Fixed in Version => 1.3.5svn
2007-11-12 09:45 subik Resolution open => fixed
2007-11-12 09:45 subik Note Added: 0017902
2007-11-13 23:20 cbradney Status resolved => closed