View Issue Details

IDProjectCategoryView StatusLast Update
0010974ScribusGeneralpublic2013-01-06 03:14
Reporterale Assigned Tofschmid  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0010974: [PATCH] page deleting updates the page selector on each itearation
DescriptionScribusMainWindow::deletePage(int from, int to) updates the page selector on each itearation and, then at the end again...

the attached patch removes from the loop the update of pageselector and deactivates the screen refresh while deleting the pages.
TagsNo tags attached.
Patch

Activities

ale

2012-07-30 19:42

manager  

page_delete_connection_selector.diff (1,180 bytes)   
Index: scribus.cpp
===================================================================
--- scribus.cpp	(revision 17742)
+++ scribus.cpp	(working copy)
@@ -6886,6 +6886,7 @@
 		page->guides.clearVerticals(GuideManagerCore::Standard);
 		page->guides.clearVerticals(GuideManagerCore::Auto);
 	}
+	view->updatesOn(false);
 	if (tmpSelection.count() != 0)
 		doc->itemSelection_DeleteItem(&tmpSelection);
 	for (int a = to - 1; a >= from - 1; a--)
@@ -6910,10 +6911,6 @@
 			doc->deleteMasterPage(a);
 		else
 			doc->deletePage(a);
-		disconnect(view->pageSelector, SIGNAL(GotoPage(int)), view, SLOT(GotoPa(int)));
-		view->pageSelector->setMaximum(doc->Pages->count());
-		view->pageSelector->GotoPg(0);
-		connect(view->pageSelector, SIGNAL(GotoPage(int)), view, SLOT(GotoPa(int)));
 		if (!isMasterPage) // Master pages are not added to sections when created
 			doc->removePageFromSection(a);
 	}
@@ -6921,6 +6918,7 @@
 	view->reformPagesView();
 	undoManager->setUndoEnabled(true); // ugly hack continues
 	view->GotoPage(qMin(doc->Pages->count()-1, oldPg));
+	view->updatesOn(true);
 	updateGUIAfterPagesChanged();
 	doc->rebuildMasterNames();
 	pagePalette->rebuildMasters();

Issue History

Date Modified Username Field Change
2012-07-30 19:42 ale New Issue
2012-07-30 19:42 ale File Added: page_delete_connection_selector.diff
2013-01-05 08:50 fschmid Status new => resolved
2013-01-05 08:50 fschmid Fixed in Version => 1.5.0svn
2013-01-05 08:50 fschmid Resolution open => fixed
2013-01-05 08:50 fschmid Assigned To => fschmid
2013-01-06 03:14 christoph_s Status resolved => closed