View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0010986 | Scribus | Graphics / Image Frames | public | 2012-08-01 13:49 | 2014-09-20 07:02 |
Reporter | cezaryece | Assigned To | christoph_s | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | unable to reproduce | ||
Product Version | 1.5.0svn | ||||
Summary | 0010986: EPS files generate transparency warning | ||||
Description | I have few simply EPS files I am using in 1.4 without any problems. But loaded into 1.5.svn each if them cause transparency warning in Preflight Checker. See attached example file. | ||||
Tags | PreflightChecker | ||||
Patch | |||||
|
|
|
Hmmm, i do not get any warning here... Do you use the poppler based importer or the ps/eps legacy importer? |
|
In fact I open in 1.5 file created by 1.4 and got lot of warnings with each EPS included there. I mean placing EPS file in image frame, not import postscript vectors. |
|
It doesn't matter. I got issue while import attached file to new doc created in 1.5. Maybe you have not enabled warnings with objects transparency in Preflight preferences? |
|
After some deeper investigation I have found problematic code. It is because of preview image in EPS file. Also I have notice that PDF file inserted in image frame always causes "partially filled image frame" warning and notice that if preview has resolution smaller than minimal resolution for images then it also cause false warning. Here you have diff solving these issues: diff --git a/Scribus/scribus/documentchecker.cpp b/Scribus/scribus/documentchecker.cpp index 46b813a..46002c9 100644 --- a/Scribus/scribus/documentchecker.cpp +++ b/Scribus/scribus/documentchecker.cpp @@ -485,16 +485,17 @@ bool DocumentChecker::checkDocument(ScribusDoc *currDoc) #endif { - // check image vs. frame sizes - if (checkerSettings.checkPartFilledImageFrames && isPartFilledImageFrame(currItem)) - { - itemError.insert(PartFilledImageFrame, 0); - } - if ((!currItem->PictureIsAvailable) && (checkerSettings.checkPictures)) itemError.insert(MissingImage, 0); else { + QFileInfo fi = QFileInfo(currItem->Pfile); + QString ext = fi.suffix().toLower(); + if (!extensionIndicatesEPSorPS(ext) && !extensionIndicatesPDF(ext)) + { + // check image vs. frame sizes + if (checkerSettings.checkPartFilledImageFrames && isPartFilledImageFrame(currItem)) + itemError.insert(PartFilledImageFrame, 0); if (currItem->PictureIsAvailable) { if (checkerSettings.checkTransparency && currItem->pixm.hasSmoothAlpha()) @@ -506,13 +507,11 @@ bool DocumentChecker::checkDocument(ScribusDoc *currDoc) if (((qRound(72.0 / currItem->imageXScale()) > checkerSettings.maxResolution) || (qRound(72.0 / currItem->imageYScale()) > checkerSettings.maxResolution)) && (currItem->isRaster) && (checkerSettings.checkResolution)) itemError.insert(ImageDPITooHigh, 0); - QFileInfo fi = QFileInfo(currItem->Pfile); - QString ext = fi.suffix().toLower(); - if (extensionIndicatesPDF(ext) && (checkerSettings.checkRasterPDF)) - itemError.insert(PlacedPDF, 0); if ((ext == "gif") && (checkerSettings.checkForGIF)) itemError.insert(ImageIsGIF, 0); - + } + if (extensionIndicatesPDF(ext) && (checkerSettings.checkRasterPDF)) + itemError.insert(PlacedPDF, 0); if (extensionIndicatesPDF(ext)) { PDFAnalyzer analyst(currItem->Pfile); Sorry it is from git again... |
|
Can not reproduce on several 1.5 platform (including OSX 10.8.5 Qt5.3.2 Poppler 0.26.4) Resolving for now unless needs to be re-opened |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-08-01 13:49 | cezaryece | New Issue | |
2012-08-01 13:49 | cezaryece | File Added: 13-12-15A-Lamigowki00.eps | |
2012-08-01 20:07 | jghali | Note Added: 0028718 | |
2012-08-02 04:59 | cezaryece | Note Added: 0028721 | |
2012-08-02 05:02 | cezaryece | Note Edited: 0028721 | |
2012-08-02 07:31 | cezaryece | Note Added: 0028728 | |
2012-08-02 08:10 | cezaryece | Note Added: 0028729 | |
2012-08-02 08:11 | cezaryece | Note Edited: 0028729 | |
2012-08-02 08:12 | cezaryece | Assigned To | => jghali |
2012-08-02 08:12 | cezaryece | Status | new => assigned |
2012-08-02 13:41 | cezaryece | Assigned To | jghali => |
2014-07-10 20:42 | JLuc | Tag Attached: PreflightChecker | |
2014-09-18 12:16 | Kunda | Note Added: 0033732 | |
2014-09-18 12:16 | Kunda | Status | assigned => resolved |
2014-09-18 12:16 | Kunda | Resolution | open => unable to reproduce |
2014-09-18 12:16 | Kunda | Assigned To | => Kunda |
2014-09-18 12:17 | Kunda | Assigned To | Kunda => |
2014-09-20 07:02 | christoph_s | Status | resolved => closed |
2014-09-20 07:02 | christoph_s | Assigned To | => christoph_s |
2015-09-17 20:10 | Kunda | Category | Graphics / Image Frames => Graphics/Img Frames |
2015-09-17 20:11 | Kunda | Category | Graphics/Img Frames => Graphics / Image Frames |