View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011250 | Scribus | Styles | public | 2012-12-13 15:34 | 2013-05-29 22:30 |
Reporter | pygmee | Assigned To | jghali | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86 | OS | Ubuntu | OS Version | 12.04 |
Product Version | 1.4.1 | ||||
Target Version | 1.5.0 | Fixed in Version | 1.5.0svn | ||
Summary | 0011250: Drop caps aren't correctly applied | ||||
Description | yesterday, during a workshop, someone wanted to use a drop cap on each group verse of a poem. It seemed that drop cap was applied on each text line, be they created by return or shift-return. In case of shift-return is used, the drop cap should be applied to the first line only. | ||||
Tags | No tags attached. | ||||
Patch | |||||
|
|
|
11250_dropcaps_linebreak.patch (550 bytes)
Index: scribus/pageitem_textframe.cpp =================================================================== --- scribus/pageitem_textframe.cpp (revision 17936) +++ scribus/pageitem_textframe.cpp (working copy) @@ -2271,8 +2271,7 @@ current.xPos = realEnd; //line break or end of column - if (( hl->ch == SpecialChars::PARSEP || hl->ch == SpecialChars::LINEBREAK) - && current.hasDropCap) + if (hl->ch == SpecialChars::PARSEP && current.hasDropCap) { current.hasDropCap = false; if (current.yPos < maxDY) |
|
It seems the fix is rather simple. I uploaded a test patch which fix the issue. It may need some adjustement tho in case of frame break or column break. |
|
Not sure we can fix that issue in 1.4.x. Setting target for 1.5.0. |
|
It seems to work perfectly here :) |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-12-13 15:34 | pygmee | New Issue | |
2012-12-13 15:34 | pygmee | File Added: BugDropCap.sla | |
2012-12-13 23:07 | jghali | File Added: 11250_dropcaps_linebreak.patch | |
2012-12-13 23:09 | jghali | Note Added: 0029366 | |
2012-12-13 23:11 | jghali | Note Added: 0029367 | |
2012-12-13 23:11 | jghali | Target Version | => 1.5.0 |
2013-04-11 13:29 | jghali | Status | new => resolved |
2013-04-11 13:29 | jghali | Fixed in Version | => 1.5.0svn |
2013-04-11 13:29 | jghali | Resolution | open => fixed |
2013-04-11 13:29 | jghali | Assigned To | => jghali |
2013-04-14 08:58 | pygmee | Note Added: 0030073 | |
2013-05-29 22:30 | jghali | Status | resolved => closed |